{"id":25552,"url":"https://patchwork.libcamera.org/api/patches/25552/?format=json","web_url":"https://patchwork.libcamera.org/patch/25552/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251214181646.573675-5-rui.wang@ideasonboard.com>","date":"2025-12-14T18:16:44","name":"[v5,4/6] ipa: rkisp1: algorithms: dpf: Simplify YAML key names","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fde55aa0a6763837f03fb63ade26c56bdd14db7e","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25552/mbox/","series":[{"id":5660,"url":"https://patchwork.libcamera.org/api/series/5660/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5660","date":"2025-12-14T18:16:40","name":"refactor DPF parsing and initialization","version":5,"mbox":"https://patchwork.libcamera.org/series/5660/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25552/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25552/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3FF36C326B\n\tfor ;\n\tSun, 14 Dec 2025 18:17:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0F756193F;\n\tSun, 14 Dec 2025 19:17:16 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC69161938\n\tfor ;\n\tSun, 14 Dec 2025 19:17:14 +0100 (CET)","from rui-Precision-7560.local (unknown [209.216.103.65])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4F19E10D4;\n\tSun, 14 Dec 2025 19:17:10 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v2RjsRHq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765736230;\n\tbh=tbXLX0IaNu+MSkL4pL7GcCFWMeiePHrCubMKvlW6h9A=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=v2RjsRHqfHpqJpTKWhqtMLW/ty8QZJQAcg+IpBNMqdsFA1EV8z+kh1Ca8bSzO72+S\n\tOrm2j7L1R9GnKtax5yrnuC9VksuESDI0l3CaCK8y+3mp4hNFYnKSaxZpN0F59TlW0H\n\t848wXKcZZ2CDtjVgZ1lmXQ7OQRP6RsWVvlJLq5hE=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v5 4/6] ipa: rkisp1: algorithms: dpf: Simplify YAML key names","Date":"Sun, 14 Dec 2025 13:16:44 -0500","Message-ID":"<20251214181646.573675-5-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251214181646.573675-1-rui.wang@ideasonboard.com>","References":"<20251214181646.573675-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename DPF tuning file keys to shorter, more concise names:\n- DomainFilter -> filter\n- NoiseLevelFunction -> nll\n- FilterStrength -> strength\n\nThis improves readability and reduces verbosity in tuning files\nwhile maintaining the same functionality. Error messages are\nupdated accordingly to reflect the new key names.\n\nSigned-off-by: Rui Wang \n---\n src/ipa/rkisp1/algorithms/dpf.cpp | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\nindex 677239ca..4818ef28 100644\n--- a/src/ipa/rkisp1/algorithms/dpf.cpp\n+++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n@@ -130,7 +130,7 @@ int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \t * The domain kernel is configured with a 9x9 kernel for the green\n \t * pixels, and a 13x9 or 9x9 kernel for red and blue pixels.\n \t */\n-\tconst YamlObject &dFObject = tuningData[\"DomainFilter\"];\n+\tconst YamlObject &dFObject = tuningData[\"filter\"];\n \n \t/*\n \t * For the green component, we have the 9x9 kernel specified\n@@ -152,7 +152,7 @@ int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \tvalues = dFObject[\"g\"].getList().value_or(std::vector{});\n \tif (values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS) {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'DomainFilter:g': expected \"\n+\t\t\t<< \"Invalid 'filter:g': expected \"\n \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS\n \t\t\t<< \" elements, got \" << values.size();\n \t\treturn -EINVAL;\n@@ -189,7 +189,7 @@ int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \tif (values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS &&\n \t values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS - 1) {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'DomainFilter:rb': expected \"\n+\t\t\t<< \"Invalid 'filter:rb': expected \"\n \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS - 1\n \t\t\t<< \" or \" << RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS\n \t\t\t<< \" elements, got \" << values.size();\n@@ -211,13 +211,13 @@ int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \t * which stores a piecewise linear function that characterizes the\n \t * sensor noise profile as a noise level function curve (NLF).\n \t */\n-\tconst YamlObject &rFObject = tuningData[\"NoiseLevelFunction\"];\n+\tconst YamlObject &rFObject = tuningData[\"nll\"];\n \n \tstd::vector nllValues;\n \tnllValues = rFObject[\"coeff\"].getList().value_or(std::vector{});\n \tif (nllValues.size() != RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS) {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'RangeFilter:coeff': expected \"\n+\t\t\t<< \"Invalid 'nll:coeff': expected \"\n \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS\n \t\t\t<< \" elements, got \" << nllValues.size();\n \t\treturn -EINVAL;\n@@ -233,13 +233,13 @@ int Dpf::parseSingleConfig(const YamlObject &tuningData,\n \t\tconfig.nll.scale_mode = RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC;\n \t} else {\n \t\tLOG(RkISP1Dpf, Error)\n-\t\t\t<< \"Invalid 'RangeFilter:scale-mode': expected \"\n+\t\t\t<< \"Invalid 'nll:scale-mode': expected \"\n \t\t\t<< \"'linear' or 'logarithmic' value, got \"\n \t\t\t<< scaleMode;\n \t\treturn -EINVAL;\n \t}\n \n-\tconst YamlObject &fSObject = tuningData[\"FilterStrength\"];\n+\tconst YamlObject &fSObject = tuningData[\"strength\"];\n \n \tstrengthConfig.r = fSObject[\"r\"].get().value_or(64);\n \tstrengthConfig.g = fSObject[\"g\"].get().value_or(64);\n","prefixes":["v5","4/6"]}