[{"id":37337,"web_url":"https://patchwork.libcamera.org/comment/37337/","msgid":"<855xabso6y.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-12T15:40:53","subject":"Re: [PATCH v8 23/26] ipa: software_isp: Call\n\tcreateSelfEnumeratingAlgorithm() to statically instantiate CCM algo","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/ipa/simple/soft_simple.cpp | 6 ++++++\n> 1 file changed, 6 insertions(+)\n>\n> diff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\n> index 2bbe271d9..d5474bb7a 100644\n> --- a/src/ipa/simple/soft_simple.cpp\n> +++ b/src/ipa/simple/soft_simple.cpp\n> @@ -137,6 +137,12 @@ int IPASoftSimple::init(const IPASettings &settings,\n> \tif (ret)\n> \t\treturn ret;\n> \n> +\tif (context_.gpuIspEnabled && !data->contains(\"ccm\")) {\n> +\t\tret = createSelfEnumeratingAlgorithm(context_, std::string(\"Ccm\"));\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\t}\n\nCCM doesn't work; the condition above is wrong. The following works for\nme:\n\n if (context_.gpuIspEnabled) {\n \tconst auto &list = (*data)[\"algorithms\"].asList();\n \tif (std::none_of(list.begin(), list.end(),\n \t\t\t [](const YamlObject &algorithm) { return algorithm.contains(\"Ccm\"); })) {\n \t\tret = createSelfEnumeratingAlgorithm(context_, std::string(\"Ccm\"));\n \t\tif (ret)\n \t\t\treturn ret;\n \t}\n }\n\n> +\n> \t*ccmEnabled = context_.ccmEnabled;\n> \n> \tparams_ = nullptr;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1510CBD1F1\n\tfor ;\n\tFri, 12 Dec 2025 15:41:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F0AEA61888;\n\tFri, 12 Dec 2025 16:41:00 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3F9CA6142F\n\tfor ;\n\tFri, 12 Dec 2025 16:40:59 +0100 (CET)","from mail-wm1-f72.google.com (mail-wm1-f72.google.com\n\t[209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-611-gG1Dbg9MOeW3bJG0iGdIqw-1; Fri, 12 Dec 2025 10:40:56 -0500","by mail-wm1-f72.google.com with SMTP id\n\t5b1f17b1804b1-47910af0c8bso11014975e9.2\n\tfor ;\n\tFri, 12 Dec 2025 07:40:56 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42fa8b8a97esm15323304f8f.31.2025.12.12.07.40.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 12 Dec 2025 07:40:54 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ixtRt2bm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1765554057;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=c8BBGzwfOjNgu3UuXw31nbKd266obbCDKZxs+fLHngA=;\n\tb=ixtRt2bmHys0+qjmTeBMp4jQpt/gkUa0LjdC1SckUfZ60o1ef60+Vry9Wv7drxQ+D8qJgl\n\twhG1rhrfQqEZovok5OYh0jnJcL8j34h0DMvyj1uZKLwNax61D4N+gHRThpt01JWLV6Olsz\n\tIt0rlH8vhtEDiUcoC3pae/LEpf0pTgs=","X-MC-Unique":"gG1Dbg9MOeW3bJG0iGdIqw-1","X-Mimecast-MFC-AGG-ID":"gG1Dbg9MOeW3bJG0iGdIqw_1765554055","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765554055; x=1766158855;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=c8BBGzwfOjNgu3UuXw31nbKd266obbCDKZxs+fLHngA=;\n\tb=Rul40aIHTXSEnwFEx+cg1mlr1NwVi5nsK5jMsIH1rtEszPmd4BakwDsuKOuTvKwdPv\n\tiT9Fo39lNo+oiTj3Jvnd5kbRctmuVwOjoQGpkX1uWNvtoV2UcafRwKwHhsIzkUb70e0E\n\tRDARfDrPWeO/Lpja8e73ZjYl2QlNyIvslajPO1h1hnmEAwjWerPQuOqnjV4ro8J6JvM0\n\tUIznTb7hu2Ry94ILZWnzj75LmXF3hKXDIVOiNcuUJLtgbza9hZVSH/YziTMJUD62ps2I\n\tkR7X4GCt7rGX6PoOzTCLiZrsqA+wkeuonvZUQoyBr/a3hIyUQvCIjDRrAYf2JOw1HqNn\n\tpSrA==","X-Gm-Message-State":"AOJu0YwXAtQmkbqtkPgbP0N1cLLs3HWpdnmT0WT63Kww/jhHGsNlzdkv\n\toLCdZeFNP+dpJu5D3MFOOR2w4VVbwIRdUwthgFdsRELfyNRNjMYya/AcIqXVKN3iaoGCa8PPiE6\n\to9O5y73nEQKPSFylgwpe0k5cTwtoRbxQ7Ej+0IVLzJWMRagSaL0FTuKDWtVco/Wgle0mGFI/4Wp\n\tc=","X-Gm-Gg":"AY/fxX6ArL3kZrF98tit+Tw+nw5/O06Qk4oTOJ7nHIOncNwsTxV36KqkMoLPEnwe5z/\n\tIK2w1du516H3Li0StRnaZhnKGV/Oyg5DbXy1/QwzPQqEWvjuPivencsyQn08C1125phoeRvw9f+\n\tpaivdeedXongH658mTwp4HVtr6gW92wKglPlubvvGDxfRQ58SwPToZIjN7J68HDC1AVvl/mO6zt\n\trVjrhsSeTwasFIa0YOmLPoonv5DZetIun8OZ5h9TlPdZKY9vIVS29bepyu1HBtauyfWdixfBwqM\n\toCQX0z+olpM6UJ4KzLqUkJ/16jARFaWxkpYJvm1TVvAiwGT05o6XUZ1hSuqOQZv+Z4ihNglV0rt\n\tOa/8LBLCP1MsBxbDZXjWWdf/kB8FqCZC1A4CX4hI9zIfGSMQudgofMRvcUD04bBc=","X-Received":["by 2002:a05:600c:a46:b0:477:58:7cf4 with SMTP id\n\t5b1f17b1804b1-47a8f8a7d03mr24879025e9.4.1765554055292; \n\tFri, 12 Dec 2025 07:40:55 -0800 (PST)","by 2002:a05:600c:a46:b0:477:58:7cf4 with SMTP id\n\t5b1f17b1804b1-47a8f8a7d03mr24878845e9.4.1765554054921; \n\tFri, 12 Dec 2025 07:40:54 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IEdgL+rZLrHWC3esUHD6rb8Wn57DUGKbVZ9M0Nk/3+ZXmhRW3nijTiPlukfUtl5T24pZfKYiw==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz","Subject":"Re: [PATCH v8 23/26] ipa: software_isp: Call\n\tcreateSelfEnumeratingAlgorithm() to statically instantiate CCM algo","In-Reply-To":"<20251212002937.3118-24-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Fri, 12 Dec 2025 00:29:34 +0000\")","References":"<20251212002937.3118-1-bryan.odonoghue@linaro.org>\n\t<20251212002937.3118-24-bryan.odonoghue@linaro.org>","Date":"Fri, 12 Dec 2025 16:40:53 +0100","Message-ID":"<855xabso6y.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"kHFcPkymB_ycgUL12x8cioLKf6zo5kHXeSmSOH_bXRo_1765554055","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37338,"web_url":"https://patchwork.libcamera.org/comment/37338/","msgid":"<7998e1f3-4117-4bc1-8dfd-827d97f9ecf5@linaro.org>","date":"2025-12-12T16:18:05","subject":"Re: [PATCH v8 23/26] ipa: software_isp: Call\n\tcreateSelfEnumeratingAlgorithm() to statically instantiate CCM algo","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 12/12/2025 15:40, Milan Zamazal wrote:\n> CCM doesn't work; the condition above is wrong. The following works for\n> me:\n> \n\nNo, how.\n\nI don't understand how that could have broken. Let me investigate.\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 47908C3257\n\tfor ;\n\tFri, 12 Dec 2025 16:18:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 816EC61852;\n\tFri, 12 Dec 2025 17:18:14 +0100 (CET)","from mail-pl1-x635.google.com (mail-pl1-x635.google.com\n\t[IPv6:2607:f8b0:4864:20::635])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B2C0A6142F\n\tfor ;\n\tFri, 12 Dec 2025 17:18:12 +0100 (CET)","by mail-pl1-x635.google.com with SMTP id\n\td9443c01a7336-298145fe27eso20281465ad.1\n\tfor ;\n\tFri, 12 Dec 2025 08:18:12 -0800 (PST)","from [10.237.118.45] (M106185144161.v4.enabler.ne.jp.\n\t[106.185.144.161]) by smtp.gmail.com with ESMTPSA id\n\td9443c01a7336-29eea016a4fsm57916605ad.47.2025.12.12.08.18.08\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 12 Dec 2025 08:18:10 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"rsX+B8uM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765556291; x=1766161091;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=/WtyQOD8LSKnjKvPrADPKH3sfEr10IUHbSp+HzC4T48=;\n\tb=rsX+B8uMEXJ0CyLFfvqY3PhaJ0VlIm0hl5Ik/wvEDv0SVlJ+6yP49OUSrdO6yOqSM9\n\tYLFX7l9bh5RUVSViKOiJHkjP8v0+65OyYlzdn0SKEa64esTLKqkB6Z/blfmTgsHvQ0SI\n\tuNfosAtmrba+/7yosGgchikMRZwTnAF0pyhTn2dmYkRIjaRSL4Fr7k/hOdv6hNug+cHP\n\tbnYVwsvQQNoEbqEZWq5DRI1pqRs9AqWQiDlwyFOGQWzITIxwsjnodzQJbtGu1EPRsaVr\n\t8f7AfAgi9RzPI13LLoYk3PJlewpvlN8XVgLjt5G7CiD7OXB5n9xSbCj3NTiaPS2EnhG3\n\tKsjw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765556291; x=1766161091;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=/WtyQOD8LSKnjKvPrADPKH3sfEr10IUHbSp+HzC4T48=;\n\tb=k+4vuKAGtqhYjHjUFlQ9LsFUOgmtG4FI5V5pRVXjbpXMKlTHhVtjwaO92Gk2tmovuj\n\tltTqw+D2n7K0LADkrhlVtZWJTGz9CK/qA8UlWKycsikKT4h3pEbxy3hak1XSyzjRAB9P\n\t1yyc1n/jCrQ3EUcxsNYK/s0iaLqeQtNm23LCmfCzwITR5xhkaxBzAckiH8Gufzdg3egi\n\tSzSczmdmud2scUOYZ2U9d8f9KlXSGRXMU3VGYvrW9RPLIldhHMJMVdT0WgI13MeSxOEt\n\tSgh1sSKnry2o4hw6fgsPqER7lU6FMts0I/e3CvOAztun8Kx9SdkRUjHtd2qR87EV2jSs\n\tiITg==","X-Gm-Message-State":"AOJu0YyhLTQS23OeSR3FhzpU0zdD07jmBXx/kYnuTKquPqTH+wpyRXo9\n\t/+q1E3w2+37N0OwUgLYsagg3j58VcI4rK6g+WHbLdZW7lYytEW6GSAyTG8m0yJpukBI=","X-Gm-Gg":"AY/fxX5jom8qBfvBlpyAWiIMsEIK7eND4hTVuCMcDweiJTVCtpK9i1xVeOx0vGAicDR\n\tW/CuRNfxdlx11aOyfu3ayPSeut1DyYN8sdckGFpAGamxmLQzNEA+/QLgg0HlKjlSKAXXN10avdQ\n\tcldNtMtMyPtYGfkVRsaLOT48gWSuHS270G+u0oPhjCBZrx0sSugXX1JVMTBSdyB3agWXNOq0/tx\n\trNwW+yVdxc41hjn7b1RxQaAmsOFw9akCFsp57zgMEJelald4OgOTf5AE/AyPHQ9Ix9q0RLR355Q\n\thymFnD2TSjhdg5j4YwNPQtV1hSp2YuV29PtJtl8diOkwN4K0dkGPKwhttjLoxwCa0+HuaYfBfZM\n\tsOwG5ZzbO+cH6Lcs0/d5MLE35679UHcQ0spMqgHNsC+UirjWEYgJ9mKXRPl3YxatYJUNmyy56zt\n\td/Hl6HjigMIbAlCPqIG6t2VkwqVHXbyOzaTjb1mGdkl8kBbYhjgbhD0BIQ40E=","X-Google-Smtp-Source":"AGHT+IG6sYnHJehWxJ4fziLDmEuakhJqJXBrl7LX7/FY9fnd7S3BCczIv1RsN2r0wwmj2nH5LcZR6w==","X-Received":"by 2002:a17:903:380f:b0:26d:d860:3dae with SMTP id\n\td9443c01a7336-29f23ae4459mr26718555ad.3.1765556290868; \n\tFri, 12 Dec 2025 08:18:10 -0800 (PST)","Message-ID":"<7998e1f3-4117-4bc1-8dfd-827d97f9ecf5@linaro.org>","Date":"Fri, 12 Dec 2025 16:18:05 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v8 23/26] ipa: software_isp: Call\n\tcreateSelfEnumeratingAlgorithm() to statically instantiate CCM algo","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz","References":"<20251212002937.3118-1-bryan.odonoghue@linaro.org>\n\t<20251212002937.3118-24-bryan.odonoghue@linaro.org>\n\t<855xabso6y.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Language":"en-US","From":"Bryan O'Donoghue ","In-Reply-To":"<855xabso6y.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37339,"web_url":"https://patchwork.libcamera.org/comment/37339/","msgid":"<01c591cb-457f-4ea2-9a0f-4cae6fe2a2ff@linaro.org>","date":"2025-12-12T16:19:46","subject":"Re: [PATCH v8 23/26] ipa: software_isp: Call\n\tcreateSelfEnumeratingAlgorithm() to statically instantiate CCM algo","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 12/12/2025 16:18, Bryan O'Donoghue wrote:\n> On 12/12/2025 15:40, Milan Zamazal wrote:\n>> CCM doesn't work; the condition above is wrong.  The following works for\n>> me:\n>>\n> \n> No, how.\n> \n> I don't understand how that could have broken. Let me investigate.\n> \n> ---\n> bod\n\nPardon, you mean for using a YAML based CCM not an automatically \ngenerated identity CCM right ?\n\n---\nbod","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 70AEBBD1F1\n\tfor ;\n\tFri, 12 Dec 2025 16:19:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2DBC26142F;\n\tFri, 12 Dec 2025 17:19:56 +0100 (CET)","from mail-pf1-x432.google.com (mail-pf1-x432.google.com\n\t[IPv6:2607:f8b0:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED8556142F\n\tfor ;\n\tFri, 12 Dec 2025 17:19:53 +0100 (CET)","by mail-pf1-x432.google.com with SMTP id\n\td2e1a72fcca58-7b22ffa2a88so1381967b3a.1\n\tfor ;\n\tFri, 12 Dec 2025 08:19:53 -0800 (PST)","from [10.237.118.45] (M106185144161.v4.enabler.ne.jp.\n\t[106.185.144.161]) by smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-7f4c2379972sm5732285b3a.9.2025.12.12.08.19.49\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tFri, 12 Dec 2025 08:19:51 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Wk/3RJkz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765556392; x=1766161192;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:cc:to:from:subject:user-agent:mime-version:date:message-id:from:to\n\t:cc:subject:date:message-id:reply-to;\n\tbh=Xr5RF2268kNrppgjAHucNiNq4NRserMJd7o8WSxiaD8=;\n\tb=Wk/3RJkzB3CwnFNk2zEiB2sXktns0DYIexs5rbK/9Ztx0JiioQEKAi3mAuxQ2hvTyi\n\tfRZVJPVSxhYj+I8njR/43As/LM/6zY4sPbj4/NPY7GvB63dndkd8VxpIM3SkOVP2ejt1\n\tppAgmxkQmigM8m69lL6Q9xUnmf/KuDqZmF/Yq5k0sSs8N9LgHC2/Fq42rk/ZQf33L9ZK\n\tURPdpA6o43Nfx7QznT1NS5DMDRoO0dTHMZ/6O2bfSyxj/ea0A7Up83PBz3aU62Iz4N+8\n\truQZJ+sP5hizMKuLgnFV19iEgEtragC/Ber0sccFoc/KDMoKEMmxMBeibBlvMUgVeSNO\n\t4n3g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765556392; x=1766161192;\n\th=content-transfer-encoding:in-reply-to:content-language:references\n\t:cc:to:from:subject:user-agent:mime-version:date:message-id:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=Xr5RF2268kNrppgjAHucNiNq4NRserMJd7o8WSxiaD8=;\n\tb=aoeSAfShWIlUDxl7RBIag7spH93gC2Dsx36llz4pMqkO2S8061/rPD7QL3tGHfhsHS\n\tvqGX8jzurmmH25u6i77smI/OMEQpWwzK6Zkk+ZZqoFOexBtfgIQIRo3rK2m9lSUvUS4x\n\tz4jiqs3+t3Jq4YezNZlgVn3xqHSIG8KXh5JszrL2pqpXecLjlRBjI2mBrDd6GF/xdLyS\n\twS348Pm0uhBblBHx7gaDScfHnwNzB9SpK4WTE2PuOFNzu9Fl/BvGPUVP2BqL8VwpcK+/\n\tnl67M82YJ3GPnO7RwlIfqkSqjyPOMG2Lfl9mSW+lPpx73DSPmoZRHKaGdrXXEnt2E7eg\n\t+YUw==","X-Gm-Message-State":"AOJu0Yyt+mxZU3Q7tTAxFCotUNWcsOJ2JIAB3mACeFzvVu/e86W57GIv\n\t7mx8GGVGZp7IzCabUAB+L8TKc8jtBl8v8iX3xkKZcuaa4VKZIZv0CbfUhWWZnC+qFuY=","X-Gm-Gg":"AY/fxX6+V13bjTsUacZWm0hKd6QQmMcV6eMoyMVj7K/nFkXn+HViz5TGl/HYin6l8tk\n\tnqBtmnazYzT56CsTNQ66KoyiUa2lbWMv6qrA9+TwqiNH/OUNaEN4wK7ddlPQUOA12+HWl1I8OoY\n\thCjD44lIZQlsVxFtgEQ97A+HsTGU7v1zYRh8w6wSnMJKQmcuwUtE1QZ/mI651HL99aZrOKDRt7k\n\t4cblOOTpwAOAy/geJQEWBGqqsSFb+LZOl74RP2wTj/nANWL0CedZg+Wc/m5s5XRSf8udHe8jibx\n\tTmk4i4ujz+5RHPNZkhsKMCgOW4G4xtlwAszCUOa72PSxbCUU0cKujP0t5mFhTEtzwtaKzNB0eE/\n\tX8uJzx0YZEQ1KiGe6HFga9fBhbGiWRvAzmB9L7hrnmaSEi0nr4kYoYkgBJ6Y8tDVSgqcUG7PPig\n\t6ou+RpFmCuh3x6xhN2rLguMYBTHZjI0rfvtpvc7GBwr0UkioVjJ2+vooOmpZw=","X-Google-Smtp-Source":"AGHT+IH/8Nb+ZDUppBay/PjXwcXGYPTdeqDl4kozU+MQQMDF9pnU29Y2QchA91Kw3l3ciU02w15v4w==","X-Received":"by 2002:a05:6a20:6a28:b0:361:4f82:e758 with SMTP id\n\tadf61e73a8af0-369afa035cfmr2579325637.52.1765556392307; \n\tFri, 12 Dec 2025 08:19:52 -0800 (PST)","Message-ID":"<01c591cb-457f-4ea2-9a0f-4cae6fe2a2ff@linaro.org>","Date":"Fri, 12 Dec 2025 16:19:46 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v8 23/26] ipa: software_isp: Call\n\tcreateSelfEnumeratingAlgorithm() to statically instantiate CCM algo","From":"Bryan O'Donoghue ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz","References":"<20251212002937.3118-1-bryan.odonoghue@linaro.org>\n\t<20251212002937.3118-24-bryan.odonoghue@linaro.org>\n\t<855xabso6y.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t<7998e1f3-4117-4bc1-8dfd-827d97f9ecf5@linaro.org>","Content-Language":"en-US","In-Reply-To":"<7998e1f3-4117-4bc1-8dfd-827d97f9ecf5@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37341,"web_url":"https://patchwork.libcamera.org/comment/37341/","msgid":"<851pkzsibv.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-12T17:47:32","subject":"Re: [PATCH v8 23/26] ipa: software_isp: Call\n\tcreateSelfEnumeratingAlgorithm() to statically instantiate CCM algo","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> On 12/12/2025 16:18, Bryan O'Donoghue wrote:\n>> On 12/12/2025 15:40, Milan Zamazal wrote:\n>>> CCM doesn't work; the condition above is wrong.  The following works for\n>>> me:\n>>>\n>> No, how.\n>> I don't understand how that could have broken. Let me investigate.\n>> ---\n>> bod\n>\n> Pardon, you mean for using a YAML based CCM not an automatically generated identity CCM right ?\n\nRight, when I want to use my CCM specified in uncalibrated.yaml with the\noriginal patch, it doesn't work and the default matrix is used instead.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6874BC3257\n\tfor ;\n\tFri, 12 Dec 2025 17:47:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7C6936142F;\n\tFri, 12 Dec 2025 18:47:40 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B6176142F\n\tfor ;\n\tFri, 12 Dec 2025 18:47:38 +0100 (CET)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-659-qFEBPZBqMQebSftByLyLnw-1; Fri, 12 Dec 2025 12:47:35 -0500","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-47918084ac1so16831175e9.2\n\tfor ;\n\tFri, 12 Dec 2025 09:47:35 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47a8f6f118esm17247925e9.3.2025.12.12.09.47.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 12 Dec 2025 09:47:33 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Y6NTjhme\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1765561657;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=pMqAF7ncolofon5mdFNWCzCjaM3uFG7Fgc/o/x4HBrY=;\n\tb=Y6NTjhmec5lDt//g8H/Greg8M6x36pdPKjjOnMM1uy2zhKIGXK0zgqGcBskhdDMJMXwIPh\n\teniq6FLDlN/Pp5O258s5IGUKM9nK+jT2QqHSoE7h2EzWFkc0pg2ISxl0CgclUaR7btDRhL\n\t7MLXMOpbgZVh+r+/SDbRZsR7EWbanTA=","X-MC-Unique":"qFEBPZBqMQebSftByLyLnw-1","X-Mimecast-MFC-AGG-ID":"qFEBPZBqMQebSftByLyLnw_1765561655","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765561654; x=1766166454;\n\th=content-transfer-encoding:mime-version:user-agent:message-id:date\n\t:references:in-reply-to:subject:cc:to:from:x-gm-gg\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=pMqAF7ncolofon5mdFNWCzCjaM3uFG7Fgc/o/x4HBrY=;\n\tb=ALQKbCJGZJNalqqy1YX5n1UMs/sq1AT2iH+jHgY3p7Z/MOBGvDTcwPR8deiokUfTy9\n\t7+xAGXkNpGwC5IMdiabQeb65eKoZ6ZB7QYYuqKdvauhb+OVcczwS5C0GHxl1DsC+k7g8\n\tChmHF81Ujx2uVq4i2+iZoAH7TNEkYI79364QJDnjLKB31vVgcWhtFD/U8ia+UqitCbN1\n\tAWHEfvV5FDF7jt+4K8t6g7AIiul0ZDsHTYns5OkGGjzXTsyH6g07ZtektQQMeizeN9Wp\n\tv5f5uW8z3klovSn0ZBJISEswxO8Hs2pg/vx9ept4JNZbpBiNm5lSjJQTirp0T1sekiHh\n\th2Dw==","X-Gm-Message-State":"AOJu0YxCRShO2UWkjA5jA/tRl5+CXz6LJVkxqv1MUMypu2Ns9NWuNZfF\n\tjxdpy6Nx5bU3C0OOH3J5GJLaNXs/6Ik5jJJOWe5vnRJLq5HOraTbLbUeMDn4RsoHbKWTxItF+U4\n\tj5rb9/EONNMk6uBjhOr9ns6PK+88Z/5byl16HRgwAKHGP/2WoXUr4vmOprZTBnstEXJ41lBGfkT\n\tfl0xxvAxw=","X-Gm-Gg":"AY/fxX7JZrIMSvDGuxnfbPCDXJo6tlQgF6phlcR2J/+CVPa7nBXAOsznSmfhJT2kmby\n\tUwvawmXgOMHLmoY0ScG7A9JTbyjS2b+3b3owbu6yZHoXS7bGOmByCqlxXn+kjJOLdv/8RItcemJ\n\trObAw/DPPw4DzfAt6DsKCZ4ivWCyfcynAyb0BlwrxS5E4zOrz98hzV59lKQD1gUPIz5sNCZrmSx\n\tyjuOQt9krm5I5vryeB1bJsA7kFBwFXKgz/bS3jgGsxXF016b6wKUZl/rJ7gdUV3AUN9/4KVqVhx\n\tOS3hVt68h+QmeSKIk+PYukTqTsc0EJr1JFuWoaHj8umNuGBCthQnnN8f6Y3ea2jZb81QnXnaTH2\n\tyhSq8ZRe+wm+95t/W7w1YtBMZaqIlQz6Q5vcqipPJVj5pmFCsTfjFOveGMYhK9xQ=","X-Received":["by 2002:a05:600c:6994:b0:46e:1a5e:211 with SMTP id\n\t5b1f17b1804b1-47a8f906511mr26454485e9.21.1765561654354; \n\tFri, 12 Dec 2025 09:47:34 -0800 (PST)","by 2002:a05:600c:6994:b0:46e:1a5e:211 with SMTP id\n\t5b1f17b1804b1-47a8f906511mr26454195e9.21.1765561653917; \n\tFri, 12 Dec 2025 09:47:33 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IEe0A0ja5F7hy9h3kvK8as9ZQbhhdwZCrkZ2hrg3SoyMO3cRJAbP1+y77muUJT6Au8OKVaz2Q==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz","Subject":"Re: [PATCH v8 23/26] ipa: software_isp: Call\n\tcreateSelfEnumeratingAlgorithm() to statically instantiate CCM algo","In-Reply-To":"<01c591cb-457f-4ea2-9a0f-4cae6fe2a2ff@linaro.org> (Bryan\n\tO'Donoghue's message of \"Fri, 12 Dec 2025 16:19:46 +0000\")","References":"<20251212002937.3118-1-bryan.odonoghue@linaro.org>\n\t<20251212002937.3118-24-bryan.odonoghue@linaro.org>\n\t<855xabso6y.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>\n\t<7998e1f3-4117-4bc1-8dfd-827d97f9ecf5@linaro.org>\n\t<01c591cb-457f-4ea2-9a0f-4cae6fe2a2ff@linaro.org>","Date":"Fri, 12 Dec 2025 18:47:32 +0100","Message-ID":"<851pkzsibv.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"sCqDBQn_QnkZHVoSjWPyGBS8uK_MqmxXVHVZB2HmG84_1765561655","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]