{"id":2553,"url":"https://patchwork.libcamera.org/api/patches/2553/?format=json","web_url":"https://patchwork.libcamera.org/patch/2553/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20200110193808.2266294-7-niklas.soderlund@ragnatech.se>","date":"2020-01-10T19:37:41","name":"[libcamera-devel,v3,06/33] v4l2: camera_proxy: Call V4L2Camera::getBufferFd() directly","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"dabb96393b9a568d134f2c473dcab30bc35a6047","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/2553/mbox/","series":[{"id":615,"url":"https://patchwork.libcamera.org/api/series/615/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=615","date":"2020-01-10T19:37:35","name":"libcamera: Rework buffer API","version":3,"mbox":"https://patchwork.libcamera.org/series/615/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/2553/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/2553/checks/","tags":{},"headers":{"Return-Path":"","Received":["from vsp-unauthed02.binero.net (vsp-unauthed02.binero.net\n\t[195.74.38.227])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 056D36067F\n\tfor ;\n\tFri, 10 Jan 2020 20:38:39 +0100 (CET)","from bismarck.berto.se (p54ac5d7b.dip0.t-ipconnect.de\n\t[84.172.93.123]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid cb486653-33e0-11ea-b6d8-005056917f90;\n\tFri, 10 Jan 2020 20:38:36 +0100 (CET)"],"X-Halon-ID":"cb486653-33e0-11ea-b6d8-005056917f90","Authorized-sender":"niklas@soderlund.pp.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 10 Jan 2020 20:37:41 +0100","Message-Id":"<20200110193808.2266294-7-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.24.1","In-Reply-To":"<20200110193808.2266294-1-niklas.soderlund@ragnatech.se>","References":"<20200110193808.2266294-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v3 06/33] v4l2: camera_proxy: Call\n\tV4L2Camera::getBufferFd() directly","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 10 Jan 2020 19:38:41 -0000"},"content":"From: Laurent Pinchart \n\nThe V4L2Camera::getBufferFd() method doesn't need to run in the camera\nthread. Call it directly.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \n---\n src/v4l2/v4l2_camera_proxy.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\nindex 3c8eba6b29be4811..838cbb4bfac17dfc 100644\n--- a/src/v4l2/v4l2_camera_proxy.cpp\n+++ b/src/v4l2/v4l2_camera_proxy.cpp\n@@ -92,8 +92,7 @@ void *V4L2CameraProxy::mmap(void *addr, size_t length, int prot, int flags,\n \t\treturn MAP_FAILED;\n \t}\n \n-\tint fd = vcam_->invokeMethod(&V4L2Camera::getBufferFd,\n-\t\t\t\t ConnectionTypeBlocking, index);\n+\tint fd = vcam_->getBufferFd(index);\n \tif (fd < 0) {\n \t\terrno = -fd;\n \t\treturn MAP_FAILED;\n","prefixes":["libcamera-devel","v3","06/33"]}