{"id":25524,"url":"https://patchwork.libcamera.org/api/patches/25524/?format=json","web_url":"https://patchwork.libcamera.org/patch/25524/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251212002937.3118-10-bryan.odonoghue@linaro.org>","date":"2025-12-12T00:29:20","name":"[v8,09/26] libcamera: shaders: Add support for Gamma","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"3b84f0f5b603856659bfecac8e4eaaab2a6d7aa8","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25524/mbox/","series":[{"id":5657,"url":"https://patchwork.libcamera.org/api/series/5657/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5657","date":"2025-12-12T00:29:11","name":"Add GLES 2.0 GPUISP to libcamera","version":8,"mbox":"https://patchwork.libcamera.org/series/5657/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25524/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25524/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DE4A7BD1F1\n\tfor ;\n\tFri, 12 Dec 2025 00:33:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 906236166C;\n\tFri, 12 Dec 2025 01:33:53 +0100 (CET)","from mail-pj1-x102c.google.com (mail-pj1-x102c.google.com\n\t[IPv6:2607:f8b0:4864:20::102c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3695C61635\n\tfor ;\n\tFri, 12 Dec 2025 01:33:52 +0100 (CET)","by mail-pj1-x102c.google.com with SMTP id\n\t98e67ed59e1d1-34374febdefso695891a91.0\n\tfor ;\n\tThu, 11 Dec 2025 16:33:52 -0800 (PST)","from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp.\n\t[153.246.134.249]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.33.47\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 16:33:50 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"G+Ua28eg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765499630; x=1766104430;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=ZRuITSMve+FWc8iDUneEG5zb0QDixsRjAIi5XBQ3RYM=;\n\tb=G+Ua28egfZ4IoQ0wIgUNMbJuI6rby+BqYfBD3+fvpjfYD4jGZxHXDvrskIzoXFCIGP\n\t2plQwVJCSuGjt9Uvx9vHyEKQyV2mzpbiLIKY3REkniejoA7omNUzPu0SYXE+HFEygtIH\n\tFPV1zmsqFpY78TSjywL0+/vrqBLAxUpxEmUrxWlZ8MO2+zz8xq+TlgxZlVZfRbPzkx10\n\tzAsK4QtNhQLOZdoBQeCBNjSKEU1HPN/saXJ5UahKtEa1GX9qBJSd7DzcgF/wt6dLx+aK\n\t/Y4l+pTJ6MuwvzGR7NIz34RuSR5bT9U622f/jLrxOEDycrmyce0iH3v91+i1GzXxsSju\n\tFKyw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765499630; x=1766104430;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=ZRuITSMve+FWc8iDUneEG5zb0QDixsRjAIi5XBQ3RYM=;\n\tb=FMr6esA/a+HaXWVScOdq/bZe4rlrPICdbCT/PmYQ+HUy1kNy/DfBw4yKwZJjL+vkkD\n\tf1S5tB5vCL9aNyqK4pU3WboDXUTvD4RKBTp49egl3xC61/1prtNcxHxvnwWwepdqmZvw\n\thZXhQQ/UDxnIJz+BQHs+SqjPEBm7yDzOcB+GOXMfMtF//ohDL0LDWpToEzPbVM4ZAgZs\n\ta1IYKecPvc+2jI237pXQ62v/o8Ppu9A8tGyt5/3joC3LMGAFI7QwudusMSBd0cJUj1Hb\n\tW9etZ1DVtKOidmvInOPgqzcSLjd5CsY9vCJxsG+mN/JR77LGT0KKvFsmlHSpbyGaXpQA\n\tKe0g==","X-Gm-Message-State":"AOJu0Yxxp8CgECVYq0Ya6HdvdhgG3rnvCAzIVvxvMWxEA5ayTwoES4LS\n\t5Udf8HhrH9PLu+z/JWSM2rjxIAFdiMqV5kTgNh2mRit+UwYl7xmsFQDMyRSCZ/pe00Th/JoWy3c\n\t1o/1y","X-Gm-Gg":"AY/fxX7ZfyJ54/73n8h2pwzV3q8KsSr4nowWD9i6k9Et/8Cu6QWb9h9qLTssgnjRd2W\n\tP8Tfs1yWdfVHtPhRv19iMk0evH9QVnq+uiwHAoorC8FT9utHatsdlA495lOW0uZjS7RLS/pI+sO\n\tM0NZ8wZzNkmAGks3tGbL2n4vexxDk2ggihWfJ+0Kl1G8dLDmqguHK5A8tINwLrMuhEWtVEI2aYd\n\tj+SUUH0AYao6zYkBElK04CuACgYMzdw2yzLvj180t0umgrU4DfINKQ6fz5YUy5r426t4Z4cjT8g\n\tXCzPQfYB6uANJo3QA+Nn1FTm08AyqPp22wkSB8b16uXnYaLtDOUGK+ORMIydYzgCA16ny4jv8gt\n\tE5O2+zzxJrjtGZpUeh6rUomGtJFTBfR57UTF1DYZXcwwqJbN7mP7aMQ9+N6P9BTgmzLoywfSmKX\n\tzw33ZMjUPhd0mpJD6wf/EORqeq7KV5wJLjN1w8NqbVjTl1pHPwTsyAES3QMo0=","X-Google-Smtp-Source":"AGHT+IHcFukGZ9huue0rHLReGc2lU4rqvel/uXgSOmeSJMnjzEXcI7Wf4OOEGyfNxZpKZKTRAlAhhg==","X-Received":"by 2002:a05:6a21:328a:b0:350:ee00:3cc1 with SMTP id\n\tadf61e73a8af0-369ae3977f7mr302450637.30.1765499630517; \n\tThu, 11 Dec 2025 16:33:50 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tMilan Zamazal ","Subject":"[PATCH v8 09/26] libcamera: shaders: Add support for Gamma","Date":"Fri, 12 Dec 2025 00:29:20 +0000","Message-ID":"<20251212002937.3118-10-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251212002937.3118-1-bryan.odonoghue@linaro.org>","References":"<20251212002937.3118-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add gamma compensation to the debayer shaders after colour correction is\napplied.\n\nSimilarly only apply the calculated Gamma curve when using the CCM as the\nlookup tables already contain the data.\n\nSuggested-by: Milan Zamazal \nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n src/libcamera/shaders/bayer_unpacked.frag | 4 ++++\n 2 files changed, 8 insertions(+)","diff":"diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex 7036fe278..77d9fbfa7 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -67,6 +67,7 @@ uniform vec2 tex_bayer_first_red;\n uniform sampler2D tex_y;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void)\n {\n@@ -260,6 +261,9 @@ void main(void)\n \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+\t/* Apply gamma after colour correction */\n+\trgb = pow(rgb, vec3(gamma));\n+\n #if defined (SWAP_BLUE)\n \tgl_FragColor = vec4(rgb.bgr, 1.0);\n #else\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex f0d8cd1e2..aba11a87f 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -26,6 +26,7 @@ varying vec4 yCoord;\n varying vec4 xCoord;\n uniform mat3 ccm;\n uniform vec3 blacklevel;\n+uniform float gamma;\n \n void main(void) {\n vec3 rgb;\n@@ -155,6 +156,9 @@ void main(void) {\n rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n \n+ /* Apply gamma after colour correction */\n+ rgb = pow(rgb, vec3(gamma));\n+\n #if defined (SWAP_BLUE)\n gl_FragColor = vec4(rgb.bgr, 1.0);\n #else\n","prefixes":["v8","09/26"]}