{"id":25519,"url":"https://patchwork.libcamera.org/api/patches/25519/?format=json","web_url":"https://patchwork.libcamera.org/patch/25519/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251212002937.3118-5-bryan.odonoghue@linaro.org>","date":"2025-12-12T00:29:15","name":"[v8,04/26] libcamera: shaders: Rename bayer_8 to bayer_unpacked","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"35a6d78fdb97510d821282384ecb89af3e2b1926","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25519/mbox/","series":[{"id":5657,"url":"https://patchwork.libcamera.org/api/series/5657/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5657","date":"2025-12-12T00:29:11","name":"Add GLES 2.0 GPUISP to libcamera","version":8,"mbox":"https://patchwork.libcamera.org/series/5657/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25519/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25519/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B7ACBD1F1\n\tfor ;\n\tFri, 12 Dec 2025 00:33:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0158F61635;\n\tFri, 12 Dec 2025 01:33:38 +0100 (CET)","from mail-pf1-x432.google.com (mail-pf1-x432.google.com\n\t[IPv6:2607:f8b0:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3258661613\n\tfor ;\n\tFri, 12 Dec 2025 01:33:36 +0100 (CET)","by mail-pf1-x432.google.com with SMTP id\n\td2e1a72fcca58-7f216280242so215865b3a.1\n\tfor ;\n\tThu, 11 Dec 2025 16:33:36 -0800 (PST)","from inspiron14p-linux (p99250-ipoefx.ipoe.ocn.ne.jp.\n\t[153.246.134.249]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-c0c26eb0f6bsm3317282a12.14.2025.12.11.16.33.31\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 16:33:33 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"nsYbYvld\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765499615; x=1766104415;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=lV+JLx0+P4aigKpifcEHa5VvxL7Qodjjb3+3JXtFVoo=;\n\tb=nsYbYvldMMkS4h+VoJ+thPz9kyICIq1qx0mT5jxyVNbdfWuM2Xmldzdd9vucK8Hpzu\n\tLp8+/88SVV1FaPXVsJVxoY40qfyR9WVzKlsMQId7siPn2ewuzO/y2zjVd7xf3WLVJTPG\n\t41d4O/a9y9Q69eNlEa2/uUw4LRYW9sI/daj1mSbfz4yyviMQaOUKpOmBrQuU3yjQEtWV\n\tOioAuT4MIvTQ7d0ULuvRPJ1Kpv7Yi1RcDyonKRFffrRY006Gsbu8iU/THCFLM20HfGLm\n\tfdfsNagCN6MboyqW7RD1yT9WloRi+ywrD/ZQ6Ej8KOBIX5HMausuOs4WTmeiaatJLp4f\n\th3bg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765499615; x=1766104415;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=lV+JLx0+P4aigKpifcEHa5VvxL7Qodjjb3+3JXtFVoo=;\n\tb=Z/gLx19lcfislLSGQmQY2JqfXOUv9ghDUS5Qem499RZrYKVkjNuDzrY+kJAD+Umyej\n\t6+rROoZBUIppUaf3RJuKPe049xM4ltNYRWe22ogYpRt05jWDPQEsX8vDpyiXtYYKWycD\n\tHge5dej8j+nNat9IjDXACfAyuIs8bsvaF+l2P3wrrQ/suo6L6rL0m3o19xrplgayxOPn\n\taK9V/g2XNWTatGugy53WbMj7Kb2ZQ4PLc3tT3qiSv02Y0pZBZ6QPg2YqOhc6A8hXdyJk\n\t0nreF4hDdg0yp6JT+d9+6/WhAmim2edWcD+AUfcPalbCBebFxHFmjyvAG3Q8c15acEgR\n\tkKhw==","X-Gm-Message-State":"AOJu0YwtuUvzvzyWtRyPbozCiLixmex/7FZUq4C3oTcarlFBRE4fh1Cg\n\tgxH6XqZZ8YWeYcccgTIPb1U/lv839ElONcCagMUUmEyM1dWJpeOe5tvbLTp48VJNKm92oG3rjY2\n\tlnNpH","X-Gm-Gg":"AY/fxX4cpRiH2eJx0hr45fvJhXwtcXS80xAUWiYuH7zWT6wyRP4ySrRAyOP3CHkp4Ry\n\tqL9kOgR+IFFqIKnmZj/5vet0i7bgcNiiltEkGAoJmsjgJIuYNDDm3W8C/Tsxjl8KzXBUZ534+LJ\n\t9iZ/ssNCOFMvJZrcQ5Ol2eiFm8tJfFoiuaRDX2yqmqVOnZw9FwTCsjLxrSrl0MvPlCNbDIDl+y7\n\tBoZUWsnrHj8eU+ZlPqQs1e5ccgL6oMJrRRuCC+5MtUQKL5D3cNaMh05IADmb9aqKd5iOKFRG26c\n\t7ABadLOoxV6woaE8YlIw9h2X2aRUH11j8YmCVUav3PSq7ullUj+5fW5laXilmTF261vpN7GZl92\n\t2wbMW8ASoK+QF4k+hdbLnX8iaUp+SmOQzyv5A5dw5gtIJz5wireg8IqYtk2U2WkIM9E1sUzT8R/\n\tdDQlFTODzeRL3P/CiiKGYidbwoI8lPXdl1N/LAOk5rDVAm+b25oNaSNWziOjI=","X-Google-Smtp-Source":"AGHT+IHUxIgzmVQQrJLQx1HGJTExHGTJFwcPhomuKaqCm56WYyHlnat7ucD7MKX/C0ctUKiHUlIeRg==","X-Received":"by 2002:a05:6a20:a123:b0:366:14b0:4afb with SMTP id\n\tadf61e73a8af0-368599a8d0bmr4775356637.34.1765499614489; \n\tThu, 11 Dec 2025 16:33:34 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Milan Zamazal ,\n\tKieran Bingham ,\n\tBryan O'Donoghue ","Subject":"[PATCH v8 04/26] libcamera: shaders: Rename bayer_8 to\n\tbayer_unpacked","Date":"Fri, 12 Dec 2025 00:29:15 +0000","Message-ID":"<20251212002937.3118-5-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251212002937.3118-1-bryan.odonoghue@linaro.org>","References":"<20251212002937.3118-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Milan Zamazal \n\nbayer_8.* shaders are now used for all unpacked sensor data formats,\nregardless of the pixel bit width. Let's rename the \"8-bit\" shaders to\navoid confusion.\n\nSigned-off-by: Milan Zamazal \nReviewed-by: Kieran Bingham \nSigned-off-by: Bryan O'Donoghue \n---\n src/apps/qcam/assets/shader/shaders.qrc | 4 ++--\n src/apps/qcam/viewfinder_gl.cpp | 16 ++++++++--------\n .../{bayer_8.frag => bayer_unpacked.frag} | 0\n .../{bayer_8.vert => bayer_unpacked.vert} | 0\n src/libcamera/shaders/meson.build | 4 ++--\n 5 files changed, 12 insertions(+), 12 deletions(-)\n rename src/libcamera/shaders/{bayer_8.frag => bayer_unpacked.frag} (100%)\n rename src/libcamera/shaders/{bayer_8.vert => bayer_unpacked.vert} (100%)","diff":"diff --git a/src/apps/qcam/assets/shader/shaders.qrc b/src/apps/qcam/assets/shader/shaders.qrc\nindex 7369cdbe8..f11a68ef2 100644\n--- a/src/apps/qcam/assets/shader/shaders.qrc\n+++ b/src/apps/qcam/assets/shader/shaders.qrc\n@@ -6,8 +6,8 @@\n \t../../../../../src/libcamera/shaders/YUV_3_planes.frag\n \t../../../../../src/libcamera/shaders/YUV_packed.frag\n \t../../../../../src/libcamera/shaders/bayer_1x_packed.frag\n-\t../../../../../src/libcamera/shaders/bayer_8.frag\n-\t../../../../../src/libcamera/shaders/bayer_8.vert\n+\t../../../../../src/libcamera/shaders/bayer_unpacked.frag\n+\t../../../../../src/libcamera/shaders/bayer_unpacked.vert\n \t../../../../../src/libcamera/shaders/identity.vert\n \n \ndiff --git a/src/apps/qcam/viewfinder_gl.cpp b/src/apps/qcam/viewfinder_gl.cpp\nindex 69b7c6e59..ea957dc65 100644\n--- a/src/apps/qcam/viewfinder_gl.cpp\n+++ b/src/apps/qcam/viewfinder_gl.cpp\n@@ -235,29 +235,29 @@ bool ViewFinderGL::selectFormat(const libcamera::PixelFormat &format)\n \tcase libcamera::formats::SBGGR8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGBRG8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(1.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SGRBG8:\n \t\tfirstRed_.setX(1.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SRGGB8:\n \t\tfirstRed_.setX(0.0);\n \t\tfirstRed_.setY(0.0);\n-\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_8.vert\";\n-\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_8.frag\";\n+\t\tvertexShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.vert\";\n+\t\tfragmentShaderFile_ = \":src/libcamera/shaders/bayer_unpacked.frag\";\n \t\ttextureMinMagFilters_ = GL_NEAREST;\n \t\tbreak;\n \tcase libcamera::formats::SBGGR10_CSI2P:\ndiff --git a/src/libcamera/shaders/bayer_8.frag b/src/libcamera/shaders/bayer_unpacked.frag\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.frag\nrename to src/libcamera/shaders/bayer_unpacked.frag\ndiff --git a/src/libcamera/shaders/bayer_8.vert b/src/libcamera/shaders/bayer_unpacked.vert\nsimilarity index 100%\nrename from src/libcamera/shaders/bayer_8.vert\nrename to src/libcamera/shaders/bayer_unpacked.vert\ndiff --git a/src/libcamera/shaders/meson.build b/src/libcamera/shaders/meson.build\nindex 386b342d0..dd441a577 100644\n--- a/src/libcamera/shaders/meson.build\n+++ b/src/libcamera/shaders/meson.build\n@@ -4,7 +4,7 @@\n # for the purposes of inclusion in OpenGL debayering\n shader_files = files([\n 'bayer_1x_packed.frag',\n- 'bayer_8.frag',\n- 'bayer_8.vert',\n+ 'bayer_unpacked.frag',\n+ 'bayer_unpacked.vert',\n 'identity.vert',\n ])\n","prefixes":["v8","04/26"]}