{"id":25511,"url":"https://patchwork.libcamera.org/api/patches/25511/?format=json","web_url":"https://patchwork.libcamera.org/patch/25511/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251211232246.31330-18-bryan.odonoghue@linaro.org>","date":"2025-12-11T23:22:42","name":"[v5,17/20] libcamera: software_isp: lut: Make CCM available in debayer params","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f9a37f61045bc5413e56d460d2e1b8c1956e3e48","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25511/mbox/","series":[{"id":5656,"url":"https://patchwork.libcamera.org/api/series/5656/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5656","date":"2025-12-11T23:22:25","name":"GPUISP precursor series","version":5,"mbox":"https://patchwork.libcamera.org/series/5656/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25511/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25511/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0459FC3257\n\tfor ;\n\tThu, 11 Dec 2025 23:24:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B17236166F;\n\tFri, 12 Dec 2025 00:24:10 +0100 (CET)","from mail-pf1-x431.google.com (mail-pf1-x431.google.com\n\t[IPv6:2607:f8b0:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C3E8661623\n\tfor ;\n\tFri, 12 Dec 2025 00:24:08 +0100 (CET)","by mail-pf1-x431.google.com with SMTP id\n\td2e1a72fcca58-7e1651ae0d5so553792b3a.1\n\tfor ;\n\tThu, 11 Dec 2025 15:24:08 -0800 (PST)","from inspiron14p-linux (M106185144161.v4.enabler.ne.jp.\n\t[106.185.144.161]) by smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-7f4c4ab52aasm3399933b3a.38.2025.12.11.15.24.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 15:24:06 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"evehav43\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765495447; x=1766100247;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=rnjAQII4Af7HGPERJUrMBWaxv6dQNSLGtLqN0TNNsL4=;\n\tb=evehav43uNg4e7xUo/EmZhYH2SudISZJU++6o5sHQLUD/776UUhzO0ZFZmohdMMf25\n\tcoYi7OFsNZ8zFqvLmly8tdSAymbMDReMzUW1tw0x8ZREnH/d1V1rAVfSRIzGEDZE2zbZ\n\tt2LGgFtYzAV3Ge8MT5qSyjZggrNOHh5tWY3uprtLphoOeAB96JvWT/oAL3BWEM9owAuf\n\tugPcR8WeC+n26WJGO7OJtutVGaKh+/YtALKdrd8YfudgX1shFTFN3ZUACtQ0KVQ9w8G2\n\tMWR6E2MYX7SUJ/TbamjYL7vZW1MnuNVrO+x3ueA+u9nmSqxDBDyiGwynXJu2dLM7pdjY\n\tK6Vw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765495447; x=1766100247;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=rnjAQII4Af7HGPERJUrMBWaxv6dQNSLGtLqN0TNNsL4=;\n\tb=xUKXqUx3rQWyrZ3ViGTT8OSAjqmMMPex1Y/T1ZHbuWiFa+la1e5GHxfWXVYGnL1qNI\n\tdrBZTgeJa/XaAL6+tRcsaEjD3vr+Osp5gDaMg3NVXSB2rpJjFtJHE2T68jZCKFcEZZ04\n\tb4hFS+YnIg/DrJwWQbRMuJFf/HdLJzLOdue657/Ci3JaP6SfnzoiS2yZp3lMhVu6lKY9\n\tra9Ye1jIdYwOMhX3ljjY2Rhm7OCKKIClz4qnm/fowJvlfKb+C/VevT8ysd2O1bHIvdW0\n\tB7O0DSSE9DNs9T4uun53cruy/okgGeFUOaiQ6IRDflXiwlM+dmVETgQGJy8W9vGQWlbq\n\t0IzQ==","X-Gm-Message-State":"AOJu0Yy/+2q+T6vYsGBJuF/M/rQbagEltIQ48hj2h7Fty89tEFaKssa4\n\t+qSB0fhVDqAe82u+Otph3SPnae7QEr7bfH/9CQJMCal7l43yDuikgl8Jvf7x9IhmYBiUF4KmtcK\n\twhWxd","X-Gm-Gg":"AY/fxX7c/00JTwSF8Tq8ikTZIljKGBFnlCRW98+hMMFuPA9BCv8GIj9ehuVX3b+3ySW\n\tD6wC7RhUEDP0vOs9jiEMzOxxxmaoe40mVMDGpNICp+czwEF907k7ln1deTnmsLp4anzWb8GsWgu\n\t6ZIL74Ze6B+OpHXsgbmvVrvtzEyTZI4ci1amMNyAwCMMhOknnRyECuFuknF2QCEOFIB/xEsp12M\n\tp27UoPG62aD5mL7Y9uZM6gVBidBvdG6BuDM004EAYhLXAPA1RkLTFMptfJSg2s1y5VVDnanAast\n\tW4T80eanMVUfdT1e8vrZR7phg7xr9aP6UqHWk3S3T4f9cJ4i116SxwKiKxzRlJJMKe+r4xOgkg4\n\tBEfAV1DsJy2g1783TMQGKBuFflfJaflDx7Qi6hKl6fNszZqroGjfLeRBb9j00s/sZN+MP1srqMi\n\tMJdauweTVWtTUWZzNoCpz0V6ctLgmNXL+in6wzRoaBjdl2EigXiUPBrZJShTOs3A==","X-Google-Smtp-Source":"AGHT+IGrSnpSrZTBc63v9u7rHJgnOzg38QSplE3h/Z3NeDVzGQvLwTKOn6j6XBAFFOEZCshVqXP0aA==","X-Received":"by 2002:a05:6a00:4192:b0:7e8:4587:e8d0 with SMTP id\n\td2e1a72fcca58-7f66a06b248mr183467b3a.67.1765495447176; \n\tThu, 11 Dec 2025 15:24:07 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ,\n\tMilan Zamazal ","Subject":"[PATCH v5 17/20] libcamera: software_isp: lut: Make CCM available in\n\tdebayer params","Date":"Thu, 11 Dec 2025 23:22:42 +0000","Message-ID":"<20251211232246.31330-18-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251211232246.31330-1-bryan.odonoghue@linaro.org>","References":"<20251211232246.31330-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide the CCM calculated in LUT to the debayer params structure for\nconsumption in the debayer shaders.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n include/libcamera/internal/software_isp/debayer_params.h | 7 +++++++\n src/ipa/simple/algorithms/lut.cpp | 1 +\n src/libcamera/software_isp/debayer.cpp | 5 +++++\n 3 files changed, 13 insertions(+)","diff":"diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\nindex 217cd5d92..4b203e211 100644\n--- a/include/libcamera/internal/software_isp/debayer_params.h\n+++ b/include/libcamera/internal/software_isp/debayer_params.h\n@@ -13,6 +13,8 @@\n #include \n #include \n \n+#include \"libcamera/internal/matrix.h\"\n+\n namespace libcamera {\n \n struct DebayerParams {\n@@ -49,6 +51,11 @@ struct DebayerParams {\n \tCcmLookupTable greenCcm;\n \tCcmLookupTable blueCcm;\n \tLookupTable gammaLut;\n+\n+\t/*\n+\t * Per frame corrections as calculated by the IPA\n+\t */\n+\tMatrix ccm;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex d4a79e101..49482d711 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -133,6 +133,7 @@ void Lut::prepare(IPAContext &context,\n \t\tauto &red = params->redCcm;\n \t\tauto &green = params->greenCcm;\n \t\tauto &blue = params->blueCcm;\n+\t\tparams->ccm = ccm;\n \t\tfor (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n \t\t\tred[i].r = ccmValue(i, ccm[0][0]);\n \t\t\tred[i].g = ccmValue(i, ccm[1][0]);\ndiff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 8b4b6cd74..4464bffb4 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -100,6 +100,11 @@ namespace libcamera {\n * \\brief Gamma lookup table used with color correction matrix\n */\n \n+/**\n+ * \\var DebayerParams::ccm\n+ * \\brief Per frame colour correction matrix for GPUISP\n+ */\n+\n /**\n * \\class Debayer\n * \\brief Base debayering class\n","prefixes":["v5","17/20"]}