{"id":25499,"url":"https://patchwork.libcamera.org/api/patches/25499/?format=json","web_url":"https://patchwork.libcamera.org/patch/25499/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251211232246.31330-6-bryan.odonoghue@linaro.org>","date":"2025-12-11T23:22:30","name":"[v5,05/20] libcamera: swstats_cpu: Drop patternSize_ documentation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"59741e75c523b0031de9169f512623c1b3987ba1","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25499/mbox/","series":[{"id":5656,"url":"https://patchwork.libcamera.org/api/series/5656/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5656","date":"2025-12-11T23:22:25","name":"GPUISP precursor series","version":5,"mbox":"https://patchwork.libcamera.org/series/5656/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25499/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25499/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4ABE0C3257\n\tfor ;\n\tThu, 11 Dec 2025 23:23:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 043E761643;\n\tFri, 12 Dec 2025 00:23:31 +0100 (CET)","from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com\n\t[IPv6:2607:f8b0:4864:20::42f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 51BE961624\n\tfor ;\n\tFri, 12 Dec 2025 00:23:29 +0100 (CET)","by mail-pf1-x42f.google.com with SMTP id\n\td2e1a72fcca58-7bf0ad0cb87so775939b3a.2\n\tfor ;\n\tThu, 11 Dec 2025 15:23:29 -0800 (PST)","from inspiron14p-linux (M106185144161.v4.enabler.ne.jp.\n\t[106.185.144.161]) by smtp.gmail.com with ESMTPSA id\n\td2e1a72fcca58-7f4c4ab52aasm3399933b3a.38.2025.12.11.15.23.23\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 11 Dec 2025 15:23:27 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"D+P7FXHY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765495408; x=1766100208;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=KNhdXYMCXvgUlmVf+twHe8rkAmqCTfmIboT5GgzpZy8=;\n\tb=D+P7FXHYXc6zQ2G34+i1560BqFLkAk8yDEhAcGE1PZpv89XhHyGe3UdNJIIsrANqd1\n\tdkr40FiRS2xyWluirvCVtTv8rUB4mlbcN0JvyW2ctFjC3VGRCsNHq8EuaR2WOFEJEOZ2\n\txy8RhxDozYGDT5j7UcHNUGDAcA+52Goz5OlA98oVwbQsDIuVMtTGA7WfVawoPqVtsiHP\n\tK76ff+i340+xesY2G8xO2pgyU911az3eji8DJWkkoBcTyoaNGMyeh5vzeBviikORl/De\n\t5zAnwAYAY8wCfAcu0CYWLKRgG3KZTMEWvMwsZevElC2tPGeFs51ZTneDbdD3OqERns5/\n\tfuhg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765495408; x=1766100208;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=KNhdXYMCXvgUlmVf+twHe8rkAmqCTfmIboT5GgzpZy8=;\n\tb=NUMsKzPXmpher7zh1FPA+FiNlcc67Y8eKl0hDZLfszZzngt7chdUO8EwfA5i7cGm5B\n\tJUGJ6z3urPe1y1fSNtibX+XN0qKoJ98ad7qWZ5qGLuXimw2OrlpxIBmUXxktTjZ+L/OP\n\t4bPBqkt9A+obAUMQ0e4dgHOaani7seOLWVQkxMa901lKwLYEdykPXEY4EAeckuyXb9L0\n\tMO70ow7AkKpk3GZw7JdWMrMr0mHxDF4/sFpU2zBpdJROyIZ01vp5sj6nPNpbDsDt9AT/\n\tD+JpBWW17UgTXP2NXv8zkX6PwO7m2nXhEn5Cg6EBX0l4jy/3foNcE95uVQhYbXbrqOzm\n\t8i7g==","X-Gm-Message-State":"AOJu0Yw/n0bXz04JTYH3cWWOOWHvl7SLYUJhLtNA5C8avrKOJ5bepUug\n\tbRiKt3KdQ6kHzuZXKUnMTGSG8tEAGZcXoEBlh6anFlWzWHxPVS/n9cyTEViXKhRIOpCiH6XGkZ6\n\tDo3fo","X-Gm-Gg":"AY/fxX68qHLq2I3/E1Mbk6F9wWmOJqafRkf1UAfe6LLeDi4G5XKG+41pL4nRURs+550\n\tnPvqF3qVB15FWKEJ+6lwKZ8x50SZNnVESOGDE2ZJQRwbtF+hGACQKkQd8c3WVfWe+TSe441+UP0\n\tIT5TuoIuuOD4GlbKBxKVNFlhhAgZLPBuMJY2NA7xLE5wgil7KA1egUCJj3AweTdIkAZ50oVFSaK\n\t/UcWqW0shCD6SvVvzKwWrMRPOefCQlDjpqKt4F+QZlRIMwrWNZtUrn0iwGYPsZdpblAHGbZtqud\n\t3TleRH/c+5zvxhu65Rtj3z8cWYTe0qA2mXKiSM49zsfh8lPruQGarmQidny76adborKsAGZXdA3\n\tGv2zh0iSusvJKakQq1melwoXRwa/MWaBUl6uIrQxcZu4K8QfOcUdsxzhoWFQVqjSkSLIIbijVow\n\t1q8p6dO5GQImh5AcJMga+ZiYbacYLPAFe1BsF8LPGZjaqeWuqqYQc+bILxtbtqHg==","X-Google-Smtp-Source":"AGHT+IFjEMSfksX8YOUokIGNJI4d0X+ICu4z2N5KEoe9QVsLJbdkPPdNUntGIyU22MkijuNMjn96Vg==","X-Received":"by 2002:a05:6a00:4216:b0:7e8:43f5:bd27 with SMTP id\n\td2e1a72fcca58-7f669c81ff2mr178725b3a.60.1765495407640; \n\tThu, 11 Dec 2025 15:23:27 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Hans de Goede ,\n\tKieran Bingham ,\n\tMilan Zamazal ,\n\tBryan O'Donoghue ","Subject":"[PATCH v5 05/20] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation","Date":"Thu, 11 Dec 2025 23:22:30 +0000","Message-ID":"<20251211232246.31330-6-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251211232246.31330-1-bryan.odonoghue@linaro.org>","References":"<20251211232246.31330-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Hans de Goede \n\npatternSize_ is a private variable and its meaning is already documented\nin the patternSize() getter documentation.\n\nMove the list of valid sizes to the patternSize() getter documentation\nand drop the patternSize_ documentation.\n\nWhile at it also add 1x1 as valid size for use with future support\nof single plane non Bayer input data.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Milan Zamazal \nSigned-off-by: Hans de Goede \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)","diff":"diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex 9c03338a0..1b33ffa71 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -58,6 +58,8 @@ namespace libcamera {\n * also indicates if processLine2() should be called or not.\n * This may only be called after a successful configure() call.\n *\n+ * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n+ *\n * \\return The pattern size\n */\n \n@@ -133,13 +135,6 @@ namespace libcamera {\n * \\brief Statistics window, set by setWindow(), used every line\n */\n \n-/**\n- * \\var Size SwStatsCpu::patternSize_\n- * \\brief The size of the bayer pattern\n- *\n- * Valid sizes are: 2x2, 4x2 or 4x4.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::xShift_\n * \\brief The offset of x, applied to window_.x for bayer variants\n","prefixes":["v5","05/20"]}