[{"id":37320,"web_url":"https://patchwork.libcamera.org/comment/37320/","msgid":"<176548158664.2563912.17968173103483386814@ping.linuxembedded.co.uk>","date":"2025-12-11T19:33:06","subject":"Re: [PATCH v3 3/6] include: linux: media-bus-format.h: Update to\n\tv6.18","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2025-12-11 09:07:26)\n> Update media-bus-format.h to Linux kernel version v6.18.\n> \n> Mainline has introduced two new media bus codes whose definition\n> conflicts with the downstream definition of\n> MEDIA_BUS_FMT_RGB202020_1X60.\n> \n> Update the definition of MEDIA_BUS_FMT_RGB202020_1X60 not to conflict\n> with the newly added symbol.\n> \n> MEDIA_BUS_FMT_RGB202020_1X60, which is used by the Mali C55 ISP,\n> will land in v6.19 with value 0x1029, so this change actually\n> aligns the downstream definition with the forthcoming upstream\n> support for Mali C55.\n> \n> Signed-off-by: Jacopo Mondi \n> Acked-by: Barnabás Pőcze \n> Reviewed-by: Laurent Pinchart \n> ---\n> include/linux/media-bus-format.h | 6 ++++--\n> 1 file changed, 4 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/linux/media-bus-format.h b/include/linux/media-bus-format.h\n> index bf467168d4651fc93459a943605865d6acf8091d..6903d9bb298b969a9c99199e4541c82ea11bbe5c 100644\n> --- a/include/linux/media-bus-format.h\n> +++ b/include/linux/media-bus-format.h\n> @@ -34,7 +34,7 @@\n> \n> #define MEDIA_BUS_FMT_FIXED 0x0001\n> \n> -/* RGB - next is 0x1027 */\n> +/* RGB - next is 0x1029 */\n> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016\n> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001\n> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002\n> @@ -68,11 +68,13 @@\n> #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d\n> #define MEDIA_BUS_FMT_RGB888_1X32_PADHI 0x100f\n> #define MEDIA_BUS_FMT_RGB101010_1X30 0x1018\n> +#define MEDIA_BUS_FMT_RGB101010_1X7X5_SPWG 0x1026\n> +#define MEDIA_BUS_FMT_RGB101010_1X7X5_JEIDA 0x1027\n> #define MEDIA_BUS_FMT_RGB666_1X36_CPADLO 0x1020\n> #define MEDIA_BUS_FMT_RGB888_1X36_CPADLO 0x1021\n> #define MEDIA_BUS_FMT_RGB121212_1X36 0x1019\n> #define MEDIA_BUS_FMT_RGB161616_1X48 0x101a\n> -#define MEDIA_BUS_FMT_RGB202020_1X60 0x1026\n> +#define MEDIA_BUS_FMT_RGB202020_1X60 0x1029\n\nWhat happened to 0x1028 ? or is that only in v6.19 but we don't care\nabout it to add it here ?\n\nOtherwise,\n\nReviewed-by: Kieran Bingham \n\n> \n> /* YUV (including grey) - next is 0x202f */\n> #define MEDIA_BUS_FMT_Y8_1X8 0x2001\n> \n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22989BD1F1\n\tfor ;\n\tThu, 11 Dec 2025 19:33:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 723C661616;\n\tThu, 11 Dec 2025 20:33:11 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E8902609DE\n\tfor ;\n\tThu, 11 Dec 2025 20:33:09 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 77D2E1352;\n\tThu, 11 Dec 2025 20:33:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jyD5pRYU\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765481587;\n\tbh=pO2GrRP0BXZsgpsgXjIoVhoMBBtdiyCdJe7cXsivhJk=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=jyD5pRYU6yygGsg8FPAerWSHCLdWCfLRAPwGz7rwt0Onte2artAbAXCG6XLbm/q1N\n\t6L2O8eW80fYgQoHbkvtuDjj5bB6J4bHHDYVLkQP9byaEW6uakmIBTCmi13CcEWpkAp\n\t562sNi/0QNaqNdAe5plWGs2t5TtwnV1aLV5vZZPo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251211-headers-update-v6-18-v3-3-31a54230a104@ideasonboard.com>","References":"<20251211-headers-update-v6-18-v3-0-31a54230a104@ideasonboard.com>\n\t<20251211-headers-update-v6-18-v3-3-31a54230a104@ideasonboard.com>","Subject":"Re: [PATCH v3 3/6] include: linux: media-bus-format.h: Update to\n\tv6.18","From":"Kieran Bingham ","Cc":"Jacopo Mondi , =?utf-8?q?Barnab=C3=A1s_?=\n\t=?utf-8?b?UMWRY3pl?= , Laurent Pinchart\n\t","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 11 Dec 2025 19:33:06 +0000","Message-ID":"<176548158664.2563912.17968173103483386814@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37321,"web_url":"https://patchwork.libcamera.org/comment/37321/","msgid":"","date":"2025-12-12T08:39:16","subject":"Re: [PATCH v3 3/6] include: linux: media-bus-format.h: Update to\n\tv6.18","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Thu, Dec 11, 2025 at 07:33:06PM +0000, Kieran Bingham wrote:\n> Quoting Jacopo Mondi (2025-12-11 09:07:26)\n> > Update media-bus-format.h to Linux kernel version v6.18.\n> >\n> > Mainline has introduced two new media bus codes whose definition\n> > conflicts with the downstream definition of\n> > MEDIA_BUS_FMT_RGB202020_1X60.\n> >\n> > Update the definition of MEDIA_BUS_FMT_RGB202020_1X60 not to conflict\n> > with the newly added symbol.\n> >\n> > MEDIA_BUS_FMT_RGB202020_1X60, which is used by the Mali C55 ISP,\n> > will land in v6.19 with value 0x1029, so this change actually\n> > aligns the downstream definition with the forthcoming upstream\n> > support for Mali C55.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > Acked-by: Barnabás Pőcze \n> > Reviewed-by: Laurent Pinchart \n> > ---\n> > include/linux/media-bus-format.h | 6 ++++--\n> > 1 file changed, 4 insertions(+), 2 deletions(-)\n> >\n> > diff --git a/include/linux/media-bus-format.h b/include/linux/media-bus-format.h\n> > index bf467168d4651fc93459a943605865d6acf8091d..6903d9bb298b969a9c99199e4541c82ea11bbe5c 100644\n> > --- a/include/linux/media-bus-format.h\n> > +++ b/include/linux/media-bus-format.h\n> > @@ -34,7 +34,7 @@\n> >\n> > #define MEDIA_BUS_FMT_FIXED 0x0001\n> >\n> > -/* RGB - next is 0x1027 */\n> > +/* RGB - next is 0x1029 */\n> > #define MEDIA_BUS_FMT_RGB444_1X12 0x1016\n> > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001\n> > #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002\n> > @@ -68,11 +68,13 @@\n> > #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d\n> > #define MEDIA_BUS_FMT_RGB888_1X32_PADHI 0x100f\n> > #define MEDIA_BUS_FMT_RGB101010_1X30 0x1018\n> > +#define MEDIA_BUS_FMT_RGB101010_1X7X5_SPWG 0x1026\n> > +#define MEDIA_BUS_FMT_RGB101010_1X7X5_JEIDA 0x1027\n> > #define MEDIA_BUS_FMT_RGB666_1X36_CPADLO 0x1020\n> > #define MEDIA_BUS_FMT_RGB888_1X36_CPADLO 0x1021\n> > #define MEDIA_BUS_FMT_RGB121212_1X36 0x1019\n> > #define MEDIA_BUS_FMT_RGB161616_1X48 0x101a\n> > -#define MEDIA_BUS_FMT_RGB202020_1X60 0x1026\n> > +#define MEDIA_BUS_FMT_RGB202020_1X60 0x1029\n>\n> What happened to 0x1028 ? or is that only in v6.19 but we don't care\n> about it to add it here ?\n\nGood catch.\n\nI don't know where I got confused, probably by\n\n/* RGB - next is 0x1029 */\n\nand I mixed 0x1029 with 0x1028 ?\n\nI should have used 0x1028, as that's what will be used in v6.19 as\nwell, sorry about that.\n\nFortunately we have quite careful reviewers, otherwise this could have\nlead to subtle bugs hard to diagnose. Thank you!\n\n>\n> Otherwise,\n>\n> Reviewed-by: Kieran Bingham \n>\n> >\n> > /* YUV (including grey) - next is 0x202f */\n> > #define MEDIA_BUS_FMT_Y8_1X8 0x2001\n> >\n> > --\n> > 2.52.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A230FC3257\n\tfor ;\n\tFri, 12 Dec 2025 08:39:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9DB1861645;\n\tFri, 12 Dec 2025 09:39:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 83C946069A\n\tfor ;\n\tFri, 12 Dec 2025 09:39:23 +0100 (CET)","from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD3B356D;\n\tFri, 12 Dec 2025 09:39:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Hu5Usgq/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765528759;\n\tbh=pk5hDD3THTgwio2vTWU/XIlxEChi1aA+sJPgG4/W5mc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Hu5Usgq/nxavCLWWau4L1nvTXXQ1DlvVVslW/+hUJDe3BzIt4IudP71yYDRUvuXB0\n\tlgUhB/tTC6QCatrN6OVwKSLJLgnkCiFvsthXkbd4+OHCUmPd9K7OMy4lG+tguMULFS\n\tmNJToDGAqOUswct/nT21gItIHI6uDSdz502xkuBE=","Date":"Fri, 12 Dec 2025 09:39:16 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"Jacopo Mondi , \n\tlibcamera-devel@lists.libcamera.org, =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= , Laurent Pinchart\n\t","Subject":"Re: [PATCH v3 3/6] include: linux: media-bus-format.h: Update to\n\tv6.18","Message-ID":"","References":"<20251211-headers-update-v6-18-v3-0-31a54230a104@ideasonboard.com>\n\t<20251211-headers-update-v6-18-v3-3-31a54230a104@ideasonboard.com>\n\t<176548158664.2563912.17968173103483386814@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<176548158664.2563912.17968173103483386814@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]