[{"id":37433,"web_url":"https://patchwork.libcamera.org/comment/37433/","msgid":"<992200ad-8070-443d-9c2d-38cba19d5019@ideasonboard.com>","date":"2025-12-18T12:13:45","subject":"Re: [PATCH v2 6/7] libcamera: mali-c55: Fix sensor size computation","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"Hi\n\n2025. 12. 10. 15:39 keltezéssel, Jacopo Mondi írta:\n> The sensor size computation routine doesn't work well. Even if a\n> more appriate size for a sensor is available, the largest one is\n> always selected.\n> \n> Fix the size computation procedure which has an inverted assignment.\n> \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Daniel Scally \n> Tested-by: Daniel Scally \n> ---\n\nPlease see my comments on the previous version: https://patchwork.libcamera.org/patch/25376/\n\n\nRegards,\nBarnabás Pőcze\n\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 83cb10af5d3c0588b25e4a3190f561f09627d239..24369a341db567bc431a4bd2aecfd6865c676347 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -749,7 +749,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n> \t\t\t\tstd::abs(static_cast(minSensorSize.height) -\n> \t\t\t\t\t static_cast(size.height));\n> \t\tif (dist < distance) {\n> -\t\t\tdist = distance;\n> +\t\t\tdistance = dist;\n> \t\t\tbestSize = size;\n> \t\t}\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E36EC326C\n\tfor ;\n\tThu, 18 Dec 2025 12:13:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F1BE161AC4;\n\tThu, 18 Dec 2025 13:13:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6041B61603\n\tfor ;\n\tThu, 18 Dec 2025 13:13:46 +0100 (CET)","from [192.168.33.31] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E4752122A;\n\tThu, 18 Dec 2025 13:13:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kKDUp6l9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1766060019;\n\tbh=larEMsD8RqUWD/5fS9ApzsREf38FCydhX8Uv2dTMDOM=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=kKDUp6l9mmSRb/DOtkLbpead3I/oQ+NkkMMzDj05BsGhXMFB+ZHqSVdyYOcki//vJ\n\thB7t25wFH2UsAPhUrlFTyyZpdX+0sn8Cb/0+ZVb2OkFegE9cH2Yz9xT3DpQuBZ/6Ri\n\tVYDtlB2hCWp7OH8h3glxpgnj1CBK20AxM7Qnr4L8=","Message-ID":"<992200ad-8070-443d-9c2d-38cba19d5019@ideasonboard.com>","Date":"Thu, 18 Dec 2025 13:13:45 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 6/7] libcamera: mali-c55: Fix sensor size computation","To":"Jacopo Mondi ,\n\tDaniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251210-mali-cru-v2-0-e26421de202b@ideasonboard.com>\n\t<20251210-mali-cru-v2-6-e26421de202b@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251210-mali-cru-v2-6-e26421de202b@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]