[{"id":37335,"web_url":"https://patchwork.libcamera.org/comment/37335/","msgid":"","date":"2025-12-12T14:39:24","subject":"Re: [PATCH v2 4/7] libcamera: mali-c55: Configure camera in\n\tmemory-to-memory","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Jacopo\n\nOn 10/12/2025 14:39, Jacopo Mondi wrote:\n> Add support for memory-to-memory Camera to the\n> PipelineHandlerMaliC55::configure() function.\n> \n> Start by enabling the IVC links, then configure the CRU and\n> propagate the format to the IVC.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n\nLooks good too:\n\n\nReviewed-by: Daniel Scally \n\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 27 +++++++++++++++++++++++++--\n> 1 file changed, 25 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index c0c14338ddb3f1d0075df3b3d3d154bc1b5d678a..8dcc51e27020c754004cd98cbdf73e771275b059 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -1104,9 +1104,12 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n> \t\tret = csi2Entity->getPadByIndex(1)->links()[0]->setEnabled(true);\n> \t\tbreak;\n> \t}\n> -\tcase MaliC55CameraData::Memory:\n> +\tcase MaliC55CameraData::Memory: {\n> +\t\tconst MediaEntity *ivcEntity = ivc_->entity();\n> +\t\tret = ivcEntity->getPadByIndex(1)->links()[0]->setEnabled(true);\n> \t\tbreak;\n> \t}\n> +\t}\n> \tif (ret)\n> \t\treturn ret;\n> \n> @@ -1133,7 +1136,27 @@ int PipelineHandlerMaliC55::configure(Camera *camera,\n> \t\tret = data->csi2()->getFormat(1, &subdevFormat);\n> \n> \t\tbreak;\n> -\tcase MaliC55CameraData::Memory:\n> +\t}\n> +\tcase MaliC55CameraData::Memory: {\n> +\t\tV4L2DeviceFormat inputFormat;\n> +\n> +\t\tret = data->cru()->configure(&subdevFormat, &inputFormat);\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\n> +\t\t/* Propagate the CRU format to the IVC input. */\n> +\t\tret = ivc_->setFormat(0, &subdevFormat);\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\n> +\t\tret = ivc_->getFormat(1, &subdevFormat);\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\n> +\t\tret = input_->setFormat(&inputFormat);\n> +\t\tif (ret)\n> +\t\t\treturn ret;\n> +\n> \t\tbreak;\n> \t}\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CD49AC3257\n\tfor ;\n\tFri, 12 Dec 2025 14:39:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0B7716142F;\n\tFri, 12 Dec 2025 15:39:30 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D218D6142F\n\tfor ;\n\tFri, 12 Dec 2025 15:39:27 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FB13520;\n\tFri, 12 Dec 2025 15:39:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LkYxMJe4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765550364;\n\tbh=x3eJnkLn69tUGYGMvYInm8wlBBIHOj/WciIu2Qh1zEg=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=LkYxMJe4/4d58flAsY55Xa5SZEOb3Bn7PcQRGUP12AU/i/vgLBr9TRu41oF8fEF77\n\tHkF1XAT4d7HOOXi3RE5t5U3tZNfMsjAVhjPrxwChGcnBz8xTz1WTuEo/OsptRhNQDP\n\thcqXgRNumG470+RPsrBNdfx1DH1TF6mbPs6dhOcw=","Message-ID":"","Date":"Fri, 12 Dec 2025 14:39:24 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 4/7] libcamera: mali-c55: Configure camera in\n\tmemory-to-memory","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251210-mali-cru-v2-0-e26421de202b@ideasonboard.com>\n\t<20251210-mali-cru-v2-4-e26421de202b@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","In-Reply-To":"<20251210-mali-cru-v2-4-e26421de202b@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]