[{"id":3417,"web_url":"https://patchwork.libcamera.org/comment/3417/","msgid":"<20200111020857.GT4859@pendragon.ideasonboard.com>","date":"2020-01-11T02:08:57","subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Madhavan,\n\nThank you for the patch.\n\nOn Fri, Jan 10, 2020 at 01:41:43PM +0100, madhavan.krishnan@linaro.org wrote:\n> From: Madhavan Krishnan \n> \n> importing python module can provide the exact path\n> which can be used in desktop build as well as from\n> any build system\n> ---\n> include/libcamera/meson.build | 4 +++-\n> src/libcamera/meson.build | 4 +++-\n> 2 files changed, 6 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index 99abf06..83525e2 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -21,13 +21,15 @@ include_dir = join_paths(libcamera_include_dir, 'libcamera')\n> install_headers(libcamera_api,\n> subdir : include_dir)\n> \n> +python_mod = import('python3').find_python()\n> +\n\nStrictly speaking, the return value of find_python() isn't a module but\nan external_program object. I would thus rename python_mod to python.\n\nFurthermore, as python is used in multiple directories, I think we\nshould get the python installation in the top-level meson.build file\ninstead of duplicating here and in src/libcamera/meson.build. You can do\nso right after the add_project_link_arguments() call there.\n\nFinally, the python3 module is deprecated and replaced with the python\nmodule in meson 0.46. We're currently based on meson 0.41, so we should\nkeep using the python3 module, but we will soon bump the minimum\nrequired version to 0.47. I will then update this to use the new python\nmodule. Not change is required now.\n\nThe rest of the patch looks good to me. Could you submit a v2 with the\nabove modifications ?\n\n> gen_controls = files('../../src/libcamera/gen-controls.py')\n> \n> control_ids_h = custom_target('control_ids_h',\n> input : files('../../src/libcamera/control_ids.yaml', 'control_ids.h.in'),\n> output : 'control_ids.h',\n> depend_files : gen_controls,\n> - command : [gen_controls, '-o', '@OUTPUT@', '@INPUT@'],\n> + command : [python_mod, gen_controls, '-o', '@OUTPUT@', '@INPUT@'],\n> install : true,\n> install_dir : join_paths('include', include_dir))\n> \n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index c4f965b..243935b 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -65,13 +65,15 @@ if libudev.found()\n> ])\n> endif\n> \n> +python_mod = import('python3').find_python()\n> +\n> gen_controls = files('gen-controls.py')\n> \n> control_ids_cpp = custom_target('control_ids_cpp',\n> input : files('control_ids.yaml', 'control_ids.cpp.in'),\n> output : 'control_ids.cpp',\n> depend_files : gen_controls,\n> - command : [gen_controls, '-o', '@OUTPUT@', '@INPUT@'])\n> + command : [python_mod, gen_controls, '-o', '@OUTPUT@', '@INPUT@'])\n> \n> libcamera_sources += control_ids_cpp\n> libcamera_sources += control_ids_h","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AA559606AC\n\tfor ;\n\tSat, 11 Jan 2020 03:09:12 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B69BE9B1;\n\tSat, 11 Jan 2020 03:09:11 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578708552;\n\tbh=+mmLee/OgShozSNfRo2W7XmehhpMf1yOaN5ZHb1fqsA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=gioOfHUpis85rpe1GGJpMNpKkC33aYxNhGCGDa+mEsqCa7fSZojewMW1K56s/fXbF\n\tTY3Xqs2XaqBZnTaDTyYz+JjcBLoPUH5uZZiQ6y70jBmaxKURHALCmJkGDQhqWhnAbw\n\tFLe/sI00vLw5sFECa6Aojve2hM+1RzMTchF0eT3Y=","Date":"Sat, 11 Jan 2020 04:08:57 +0200","From":"Laurent Pinchart ","To":"madhavan.krishnan@linaro.org","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200111020857.GT4859@pendragon.ideasonboard.com>","References":"\n\t<1578660103-29974-1-git-send-email-madhavan.krishnan@linaro.org>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<1578660103-29974-1-git-send-email-madhavan.krishnan@linaro.org>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 Jan 2020 02:09:13 -0000"}},{"id":3420,"web_url":"https://patchwork.libcamera.org/comment/3420/","msgid":"","date":"2020-01-11T13:44:17","subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le ven. 10 janv. 2020 08 h 05, a écrit :\n\n> From: Madhavan Krishnan \n>\n> importing python module can provide the exact path\n> which can be used in desktop build as well as from\n> any build system\n>\n\nAre you certain this is the right solution ? There is absolutely no other\nmeson project using this hack to call python script. I notice the shebang\nisn't pythonic (not using env), could be that. I just don't believe such\nhack is required. It's definately not in meson style.\n\n---\n> include/libcamera/meson.build | 4 +++-\n> src/libcamera/meson.build | 4 +++-\n> 2 files changed, 6 insertions(+), 2 deletions(-)\n>\n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index 99abf06..83525e2 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -21,13 +21,15 @@ include_dir = join_paths(libcamera_include_dir,\n> 'libcamera')\n> install_headers(libcamera_api,\n> subdir : include_dir)\n>\n> +python_mod = import('python3').find_python()\n> +\n> gen_controls = files('../../src/libcamera/gen-controls.py')\n>\n> control_ids_h = custom_target('control_ids_h',\n> input :\n> files('../../src/libcamera/control_ids.yaml', 'control_ids.h.in'),\n> output : 'control_ids.h',\n> depend_files : gen_controls,\n> - command : [gen_controls, '-o', '@OUTPUT@',\n> '@INPUT@'],\n> + command : [python_mod, gen_controls, '-o',\n> '@OUTPUT@', '@INPUT@'],\n> install : true,\n> install_dir : join_paths('include',\n> include_dir))\n>\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index c4f965b..243935b 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -65,13 +65,15 @@ if libudev.found()\n> ])\n> endif\n>\n> +python_mod = import('python3').find_python()\n> +\n> gen_controls = files('gen-controls.py')\n>\n> control_ids_cpp = custom_target('control_ids_cpp',\n> input : files('control_ids.yaml', '\n> control_ids.cpp.in'),\n> output : 'control_ids.cpp',\n> depend_files : gen_controls,\n> - command : [gen_controls, '-o', '@OUTPUT@',\n> '@INPUT@'])\n> + command : [python_mod, gen_controls,\n> '-o', '@OUTPUT@', '@INPUT@'])\n>\n> libcamera_sources += control_ids_cpp\n> libcamera_sources += control_ids_h\n> --\n> 2.7.4\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","Received":["from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com\n\t[IPv6:2607:f8b0:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C25506045B\n\tfor ;\n\tSat, 11 Jan 2020 14:44:30 +0100 (CET)","by mail-pf1-x42b.google.com with SMTP id x185so2565537pfc.5\n\tfor ;\n\tSat, 11 Jan 2020 05:44:30 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=b+76Sa/EflzEGEEJnV8ta/uBvAPDcfOOOyxNPylDkWs=;\n\tb=pgcRHqtlAhmrxhz0hYvgzwLtZbNfrdBsNV8i5nVBzFGEsW+YiKi+0CpSMhSA4gYH68\n\t3B3z/GwGg5Q6rl9xl8WsgN7WQrGiOj4iWQXmYGUMoZdPVFByaoNXUK7xV6Y++qTUcHue\n\t30lixh72msOnmqBny70Jw7SEulxq4YJQSDdzLiB6YL0X/RVDTFfCmvPCAXpje8rufzQw\n\tkT9JQzaVpHmh4Y4VjJVDcWnwcyXMzuGfsXNRbS3XmV2IaeeJRg1Adneb0T8ycPYk3xuI\n\tV6xpcYBmRq07cSMmDJgWMhZpO6oaymSGICEdoEKgHVBSaItvnDvmUXmBdL8kr4g5dZPE\n\t3TGQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=b+76Sa/EflzEGEEJnV8ta/uBvAPDcfOOOyxNPylDkWs=;\n\tb=tPtW4Ov49mqsvafIPvQIwTPcJfWTv0gfQzGQX2MBcET7v/RBE1TbIg73c9413frL36\n\tqPuROAqlZcMLcvE64bG6tKz2p0NkwNK0MKFQ4b/idG5hJF01n93u6RE6SOf/fZlrXaeP\n\tuMdXQ0Fle2BVQ3ELBiWNAF4Ks3JmBxIv3URyDg9KaZT2BWZsfJPPj/h2IIYxdALs7iBG\n\tF0zq/Y4DW3fTgzjqNXRwl8ked4a3IeCygW5TK5kxNYwqiuI3kcrMPr+O/FD/cwvxufzK\n\tf7Wxu3MfmWUOhzx0Lqk25xBWbQ8cWa2LMG0VhrpZvjQpNKIiQsWFY7fqer7wpCElTDT0\n\tw1Jw==","X-Gm-Message-State":"APjAAAXby+or14WreJkcjX9ajlf9ZeDTgM2pdMeNM/zz/HIBKkRNHWD4\n\tVfnFPezSwUSB14PwJ0hAR1U5fcKwGP2NuOK4kllgLg==","X-Google-Smtp-Source":"APXvYqza+mqw2JUwdPsaWjitC+bX9UEOQTfzYVAhMotwbP/UwVNRA4E+nfVMMCAorECX+pkVktyabaH2cn9dzgxLvdQ=","X-Received":"by 2002:a63:6b07:: with SMTP id\n\tg7mr10837059pgc.243.1578750268481; \n\tSat, 11 Jan 2020 05:44:28 -0800 (PST)","MIME-Version":"1.0","References":"<1578660103-29974-1-git-send-email-madhavan.krishnan@linaro.org>","In-Reply-To":"<1578660103-29974-1-git-send-email-madhavan.krishnan@linaro.org>","From":"Nicolas Dufresne ","Date":"Sat, 11 Jan 2020 08:44:17 -0500","Message-ID":"","To":"madhavan.krishnan@linaro.org","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000f134b6059bdd704f\"","Subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 Jan 2020 13:44:30 -0000"}},{"id":3421,"web_url":"https://patchwork.libcamera.org/comment/3421/","msgid":"<20200111200650.GA2960@pendragon.ideasonboard.com>","date":"2020-01-11T20:06:50","subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Nicolas,\n\nOn Sat, Jan 11, 2020 at 08:44:17AM -0500, Nicolas Dufresne wrote:\n> Le ven. 10 janv. 2020 08 h 05, a écrit :\n> > From: Madhavan Krishnan \n> > \n> > importing python module can provide the exact path\n> > which can be used in desktop build as well as from\n> > any build system\n>\n> Are you certain this is the right solution ? There is absolutely no other meson\n> project using this hack to call python script. I notice the shebang isn't\n> pythonic (not using env), could be that. I just don't believe such hack is\n> required. It's definately not in meson style.\n\nThat's a good point. Madhavan, would the following patch fix your\nproblem ? Nicolas, any objection against the Suggested-by line below ?\n\ncommit 169165b9b00849d30774f2f1cffbdf49b934a717\nAuthor: Laurent Pinchart \nDate: Sat Jan 11 22:01:41 2020 +0200\n\n libcamera: gen-controls.py: Don't hardcode path to python interpreter\n\n The gen-controls.py script hardcodes the path to the python interpreter\n to /usr/bin/python3 in the first line of the script. This hardcodes\n usage of the host python3, even when building in cross-compilation\n environments that may ship their own version of python. Fix it by\n setting the interpreter to '/usr/bin/env python3'.\n\n Reported-by: Madhavan Krishnan \n Suggested-by: Nicolas Dufresne \n Signed-off-by: Laurent Pinchart \n\ndiff --git a/src/libcamera/gen-controls.py b/src/libcamera/gen-controls.py\nindex 940386cc68c8..2e5ac5c81cca 100755\n--- a/src/libcamera/gen-controls.py\n+++ b/src/libcamera/gen-controls.py\n@@ -1,4 +1,4 @@\n-#!/usr/bin/python3\n+#!/usr/bin/env python3\n # SPDX-License-Identifier: GPL-2.0-or-later\n # Copyright (C) 2019, Google Inc.\n #\n\n> > ---\n> >  include/libcamera/meson.build | 4 +++-\n> >  src/libcamera/meson.build     | 4 +++-\n> >  2 files changed, 6 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> > index 99abf06..83525e2 100644\n> > --- a/include/libcamera/meson.build\n> > +++ b/include/libcamera/meson.build\n> > @@ -21,13 +21,15 @@ include_dir = join_paths(libcamera_include_dir,\n> > 'libcamera')\n> >  install_headers(libcamera_api,\n> >                  subdir : include_dir)\n> > \n> > +python_mod = import('python3').find_python()\n> > +\n> >  gen_controls = files('../../src/libcamera/gen-controls.py')\n> > \n> >  control_ids_h = custom_target('control_ids_h',\n> >                                input : files('../../src/libcamera/\n> > control_ids.yaml', 'control_ids.h.in'),\n> >                                output : 'control_ids.h',\n> >                                depend_files : gen_controls,\n> > -                              command : [gen_controls, '-o', '@OUTPUT@',\n> > '@INPUT@'],\n> > +                              command : [python_mod, gen_controls, '-o',\n> > '@OUTPUT@', '@INPUT@'],\n> >                                install : true,\n> >                                install_dir : join_paths('include',\n> > include_dir))\n> > \n> > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > index c4f965b..243935b 100644\n> > --- a/src/libcamera/meson.build\n> > +++ b/src/libcamera/meson.build\n> > @@ -65,13 +65,15 @@ if libudev.found()\n> >      ])\n> >  endif\n> > \n> > +python_mod = import('python3').find_python()\n> > +\n> >  gen_controls = files('gen-controls.py')\n> > \n> >  control_ids_cpp = custom_target('control_ids_cpp',\n> >                                  input : files('control_ids.yaml', '\n> > control_ids.cpp.in'),\n> >                                  output : 'control_ids.cpp',\n> >                                  depend_files : gen_controls,\n> > -                                command : [gen_controls, '-o', '@OUTPUT@',\n> > '@INPUT@'])\n> > +                                command : [python_mod, gen_controls, '-o',\n> > '@OUTPUT@', '@INPUT@'])\n> > \n> >  libcamera_sources += control_ids_cpp\n> >  libcamera_sources += control_ids_h","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E90406045B\n\tfor ;\n\tSat, 11 Jan 2020 21:07:05 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2E53530F;\n\tSat, 11 Jan 2020 21:07:03 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578773224;\n\tbh=jRv6+sqTx+hNlvyGitShv+RLBNVrbNnMCqIly4futOo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ixc71giBRE1t5ixe/U6s0aFC7ZutDAZHCyphissuZUVgIchI4PPeqh5/tJVFjTsiB\n\tJ0PdtS26LDvDVOkXy/0oH476o68S47IoIkojkF+LW9nvb1W2BiOM4nJmXRLFz9IrKq\n\tFKGcgxJwqCJ5Ls4UFzsANpCIg6gm3J/j07xvaa0Q=","Date":"Sat, 11 Jan 2020 22:06:50 +0200","From":"Laurent Pinchart ","To":"Nicolas Dufresne ","Cc":"madhavan.krishnan@linaro.org, libcamera-devel@lists.libcamera.org","Message-ID":"<20200111200650.GA2960@pendragon.ideasonboard.com>","References":"<1578660103-29974-1-git-send-email-madhavan.krishnan@linaro.org>\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Sat, 11 Jan 2020 20:07:06 -0000"}},{"id":3442,"web_url":"https://patchwork.libcamera.org/comment/3442/","msgid":"","date":"2020-01-14T10:30:36","subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","submitter":{"id":29,"url":"https://patchwork.libcamera.org/api/people/29/","name":"Madhavan Krishnan","email":"madhavan.krishnan@linaro.org"},"content":"Hi Laurent,\n\nThe issue I was facing get fixed with the following changes mentioned by\nyou.\n\n-#!/usr/bin/python3\n+#!/usr/bin/env python3\n\nThanks, for the update and immediate response. And we will be using this\npatch for our build system.\n\nBest Regards\nMadhavan K\n\n\n---------- Forwarded message ---------\n> From: Laurent Pinchart \n> Date: Sun, 12 Jan 2020 at 01:37\n> Subject: Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n> from sysroot\n> To: Nicolas Dufresne \n> Cc: , \n>\n>\n> Hi Nicolas,\n>\n> On Sat, Jan 11, 2020 at 08:44:17AM -0500, Nicolas Dufresne wrote:\n> > Le ven. 10 janv. 2020 08 h 05, a écrit :\n> > > From: Madhavan Krishnan \n> > >\n> > > importing python module can provide the exact path\n> > > which can be used in desktop build as well as from\n> > > any build system\n> >\n> > Are you certain this is the right solution ? There is absolutely no\n> other meson\n> > project using this hack to call python script. I notice the shebang isn't\n> > pythonic (not using env), could be that. I just don't believe such hack\n> is\n> > required. It's definately not in meson style.\n>\n> That's a good point. Madhavan, would the following patch fix your\n> problem ? Nicolas, any objection against the Suggested-by line below ?\n>\n> commit 169165b9b00849d30774f2f1cffbdf49b934a717\n> Author: Laurent Pinchart \n> Date: Sat Jan 11 22:01:41 2020 +0200\n>\n> libcamera: gen-controls.py: Don't hardcode path to python interpreter\n>\n> The gen-controls.py script hardcodes the path to the python interpreter\n> to /usr/bin/python3 in the first line of the script. This hardcodes\n> usage of the host python3, even when building in cross-compilation\n> environments that may ship their own version of python. Fix it by\n> setting the interpreter to '/usr/bin/env python3'.\n>\n> Reported-by: Madhavan Krishnan \n> Suggested-by: Nicolas Dufresne \n> Signed-off-by: Laurent Pinchart \n>\n> diff --git a/src/libcamera/gen-controls.py b/src/libcamera/gen-controls.py\n> index 940386cc68c8..2e5ac5c81cca 100755\n> --- a/src/libcamera/gen-controls.py\n> +++ b/src/libcamera/gen-controls.py\n> @@ -1,4 +1,4 @@\n> -#!/usr/bin/python3\n> +#!/usr/bin/env python3\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> # Copyright (C) 2019, Google Inc.\n> #\n>\n> > > ---\n> > > include/libcamera/meson.build | 4 +++-\n> > > src/libcamera/meson.build | 4 +++-\n> > > 2 files changed, 6 insertions(+), 2 deletions(-)\n> > >\n> > > diff --git a/include/libcamera/meson.build\n> b/include/libcamera/meson.build\n> > > index 99abf06..83525e2 100644\n> > > --- a/include/libcamera/meson.build\n> > > +++ b/include/libcamera/meson.build\n> > > @@ -21,13 +21,15 @@ include_dir = join_paths(libcamera_include_dir,\n> > > 'libcamera')\n> > > install_headers(libcamera_api,\n> > > subdir : include_dir)\n> > >\n> > > +python_mod = import('python3').find_python()\n> > > +\n> > > gen_controls = files('../../src/libcamera/gen-controls.py')\n> > >\n> > > control_ids_h = custom_target('control_ids_h',\n> > > input : files('../../src/libcamera/\n> > > control_ids.yaml', 'control_ids.h.in'),\n> > > output : 'control_ids.h',\n> > > depend_files : gen_controls,\n> > > - command : [gen_controls, '-o', '@OUTPUT@\n> ',\n> > > '@INPUT@'],\n> > > + command : [python_mod, gen_controls,\n> '-o',\n> > > '@OUTPUT@', '@INPUT@'],\n> > > install : true,\n> > > install_dir : join_paths('include',\n> > > include_dir))\n> > >\n> > > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > > index c4f965b..243935b 100644\n> > > --- a/src/libcamera/meson.build\n> > > +++ b/src/libcamera/meson.build\n> > > @@ -65,13 +65,15 @@ if libudev.found()\n> > > ])\n> > > endif\n> > >\n> > > +python_mod = import('python3').find_python()\n> > > +\n> > > gen_controls = files('gen-controls.py')\n> > >\n> > > control_ids_cpp = custom_target('control_ids_cpp',\n> > > input : files('control_ids.yaml', '\n> > > control_ids.cpp.in'),\n> > > output : 'control_ids.cpp',\n> > > depend_files : gen_controls,\n> > > - command : [gen_controls, '-o',\n> '@OUTPUT@',\n> > > '@INPUT@'])\n> > > + command : [python_mod, gen_controls,\n> '-o',\n> > > '@OUTPUT@', '@INPUT@'])\n> > >\n> > > libcamera_sources += control_ids_cpp\n> > > libcamera_sources += control_ids_h\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","Received":["from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB13360747\n\tfor ;\n\tTue, 14 Jan 2020 11:30:47 +0100 (CET)","by mail-wm1-x330.google.com with SMTP id m24so13097957wmc.3\n\tfor ;\n\tTue, 14 Jan 2020 02:30:47 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=NxYcX3Sbq6r1pkC3FFMQoSlwqJsLs/daCqGYrHTLsTQ=;\n\tb=wiqmKZN1kmAoRpozC6lsbehflHxJoj2M72N3hHo8gkH7Zci3beZvMqvm/rKLDs5F2e\n\tmO36pQSL1uFKqR9oip6ZCqdCAESlXJ7JB4YdUZGAwYU8ybiUgeWSaJmFmy52pkfao0Vy\n\tRoh/zWdeX1WP3aND89ViNr7GDlxTmU5Zur3Wsco3ezcex1Rk86M+P/37iYrXUnkfRIhQ\n\tXKYpMos9PpjCtjWLoHhTzEzMgmuBf0x89j3/f61BPnKRnV1SmyllDKqxIZ0ZED/ykf8t\n\tkhdOhHjUqUw3XpWtsRT4xXTTh1DEs6SvtO3Ldl4BmClPirYFeSaD3/3wcfAl8irnmemS\n\tpJxA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=NxYcX3Sbq6r1pkC3FFMQoSlwqJsLs/daCqGYrHTLsTQ=;\n\tb=WxypVCjOi4eHrHLjN3qRyVtWtQIKH+Kwq+5KeDft6UguFEP7z+LH0R1Vdytrx3J5AY\n\tNPPEyDS3lztg6q3hu8+V00w+BvzbZpV0iGDFB/5GnN3OBDtgeHyKk4Rka2v7gInh8xTD\n\t4IK6HsEOuMaqJDyAA/pY+anC1irA3/eZ0XF5mIkCQfLZw0XwH3kR7m0a6piIDQcHmc22\n\tT4eddHGm0SdW1qaF90bi70uUSDkzIRhudy4u/iamUEwG8UfeK4c93rs5Pgm/z4/I6/EU\n\tB36OujIdcbmu49774wRWrC03r9m6llsxuqa09oDx9K64M98GvSGQHj1xYuihc+aBdzcE\n\t9Dqg==","X-Gm-Message-State":"APjAAAXFlej/1v/R+Lb+pIqKl8i9QeNpQ9Qbb4kiqQh8Ohf26j6Zwc3N\n\tSnBI34g8bMZYixzDkHxQNjXNA9m08MmyI8o0v1Rzsg==","X-Google-Smtp-Source":"APXvYqyV+13kr5AYEN6LJ2HmF+fv00pWOkAnJ3RilJoS6IG7rhYCNMRROwHj/zHONDOS4dKORM3a+0Dj+jRLzy33Txo=","X-Received":"by 2002:a05:600c:10cd:: with SMTP id\n\tl13mr27172746wmd.102.1578997847452; \n\tTue, 14 Jan 2020 02:30:47 -0800 (PST)","MIME-Version":"1.0","References":"<1578660103-29974-1-git-send-email-madhavan.krishnan@linaro.org>\n\t\n\t<20200111200650.GA2960@pendragon.ideasonboard.com>\n\t","In-Reply-To":"","From":"Madhavan Krishnan ","Date":"Tue, 14 Jan 2020 16:00:36 +0530","Message-ID":"","To":"Nicolas Dufresne ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000cc83c9059c17153c\"","X-Mailman-Approved-At":"Tue, 14 Jan 2020 12:40:41 +0100","Subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 14 Jan 2020 10:30:48 -0000"}},{"id":3443,"web_url":"https://patchwork.libcamera.org/comment/3443/","msgid":"<20200114114302.GA4730@pendragon.ideasonboard.com>","date":"2020-01-14T11:43:02","subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Madhavan,\n\nOn Tue, Jan 14, 2020 at 04:00:36PM +0530, Madhavan Krishnan wrote:\n> Hi Laurent,\n> \n> The issue I was facing get fixed with the following changes mentioned by you.\n> \n> -#!/usr/bin/python3\n> +#!/usr/bin/env python3\n> \n> Thanks, for the update and immediate response. And we will be using this patch\n> for our build system.\n\nYou're welcome.\n\nCan I add your Tested-by: line to the patch ?","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3BF9860747\n\tfor ;\n\tTue, 14 Jan 2020 12:43:16 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc108967-cmbg20-2-0-cust420.5-4.cable.virginm.net [81.101.7.165])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 38F962F9;\n\tTue, 14 Jan 2020 12:43:15 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1579002195;\n\tbh=UMQkb/IJbNozkJHYZst7ksIb6OEYLj1Y7C5ktbqii9g=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=vldGpcZwGY/v9GhkVSyvhM34jyU/xsos0evZO3qc7asFuhtfTA2M/KMOUFWIAAXDv\n\tI8f55RreRTRa0BiwF7GSzlj5ErMZMMcyKaBubvub1obFjqlKbEUUKgi7jsOH0BscBC\n\tx0HiqpIuXVmCbym5bJQMFjm5oWNNlIMGoJCuBKxg=","Date":"Tue, 14 Jan 2020 13:43:02 +0200","From":"Laurent Pinchart ","To":"Madhavan Krishnan ","Cc":"Nicolas Dufresne ,\n\tlibcamera-devel@lists.libcamera.org","Message-ID":"<20200114114302.GA4730@pendragon.ideasonboard.com>","References":"<1578660103-29974-1-git-send-email-madhavan.krishnan@linaro.org>\n\t\n\t<20200111200650.GA2960@pendragon.ideasonboard.com>\n\t\n\t","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 14 Jan 2020 11:43:16 -0000"}},{"id":3445,"web_url":"https://patchwork.libcamera.org/comment/3445/","msgid":"","date":"2020-01-14T14:09:29","subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","submitter":{"id":30,"url":"https://patchwork.libcamera.org/api/people/30/","name":"Nicolas Dufresne","email":"nicolas@ndufresne.ca"},"content":"Le sam. 11 janv. 2020 15 h 07, Laurent Pinchart <\nlaurent.pinchart@ideasonboard.com> a écrit :\n\n> Hi Nicolas,\n>\n> On Sat, Jan 11, 2020 at 08:44:17AM -0500, Nicolas Dufresne wrote:\n> > Le ven. 10 janv. 2020 08 h 05, a écrit :\n> > > From: Madhavan Krishnan \n> > >\n> > > importing python module can provide the exact path\n> > > which can be used in desktop build as well as from\n> > > any build system\n> >\n> > Are you certain this is the right solution ? There is absolutely no\n> other meson\n> > project using this hack to call python script. I notice the shebang isn't\n> > pythonic (not using env), could be that. I just don't believe such hack\n> is\n> > required. It's definately not in meson style.\n>\n> That's a good point. Madhavan, would the following patch fix your\n> problem ? Nicolas, any objection against the Suggested-by line below ?\n>\n\nGood with me. Glad I could help.\n\n\n> commit 169165b9b00849d30774f2f1cffbdf49b934a717\n> Author: Laurent Pinchart \n> Date: Sat Jan 11 22:01:41 2020 +0200\n>\n> libcamera: gen-controls.py: Don't hardcode path to python interpreter\n>\n> The gen-controls.py script hardcodes the path to the python interpreter\n> to /usr/bin/python3 in the first line of the script. This hardcodes\n> usage of the host python3, even when building in cross-compilation\n> environments that may ship their own version of python. Fix it by\n> setting the interpreter to '/usr/bin/env python3'.\n>\n> Reported-by: Madhavan Krishnan \n> Suggested-by: Nicolas Dufresne \n> Signed-off-by: Laurent Pinchart \n>\n> diff --git a/src/libcamera/gen-controls.py b/src/libcamera/gen-controls.py\n> index 940386cc68c8..2e5ac5c81cca 100755\n> --- a/src/libcamera/gen-controls.py\n> +++ b/src/libcamera/gen-controls.py\n> @@ -1,4 +1,4 @@\n> -#!/usr/bin/python3\n> +#!/usr/bin/env python3\n> # SPDX-License-Identifier: GPL-2.0-or-later\n> # Copyright (C) 2019, Google Inc.\n> #\n>\n> > > ---\n> > > include/libcamera/meson.build | 4 +++-\n> > > src/libcamera/meson.build | 4 +++-\n> > > 2 files changed, 6 insertions(+), 2 deletions(-)\n> > >\n> > > diff --git a/include/libcamera/meson.build\n> b/include/libcamera/meson.build\n> > > index 99abf06..83525e2 100644\n> > > --- a/include/libcamera/meson.build\n> > > +++ b/include/libcamera/meson.build\n> > > @@ -21,13 +21,15 @@ include_dir = join_paths(libcamera_include_dir,\n> > > 'libcamera')\n> > > install_headers(libcamera_api,\n> > > subdir : include_dir)\n> > >\n> > > +python_mod = import('python3').find_python()\n> > > +\n> > > gen_controls = files('../../src/libcamera/gen-controls.py')\n> > >\n> > > control_ids_h = custom_target('control_ids_h',\n> > > input : files('../../src/libcamera/\n> > > control_ids.yaml', 'control_ids.h.in'),\n> > > output : 'control_ids.h',\n> > > depend_files : gen_controls,\n> > > - command : [gen_controls, '-o', '@OUTPUT@\n> ',\n> > > '@INPUT@'],\n> > > + command : [python_mod, gen_controls,\n> '-o',\n> > > '@OUTPUT@', '@INPUT@'],\n> > > install : true,\n> > > install_dir : join_paths('include',\n> > > include_dir))\n> > >\n> > > diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> > > index c4f965b..243935b 100644\n> > > --- a/src/libcamera/meson.build\n> > > +++ b/src/libcamera/meson.build\n> > > @@ -65,13 +65,15 @@ if libudev.found()\n> > > ])\n> > > endif\n> > >\n> > > +python_mod = import('python3').find_python()\n> > > +\n> > > gen_controls = files('gen-controls.py')\n> > >\n> > > control_ids_cpp = custom_target('control_ids_cpp',\n> > > input : files('control_ids.yaml', '\n> > > control_ids.cpp.in'),\n> > > output : 'control_ids.cpp',\n> > > depend_files : gen_controls,\n> > > - command : [gen_controls, '-o',\n> '@OUTPUT@',\n> > > '@INPUT@'])\n> > > + command : [python_mod, gen_controls,\n> '-o',\n> > > '@OUTPUT@', '@INPUT@'])\n> > >\n> > > libcamera_sources += control_ids_cpp\n> > > libcamera_sources += control_ids_h\n>\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","Received":["from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com\n\t[IPv6:2607:f8b0:4864:20::1035])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 043706017C\n\tfor ;\n\tTue, 14 Jan 2020 15:09:42 +0100 (CET)","by mail-pj1-x1035.google.com with SMTP id bg7so5916279pjb.5\n\tfor ;\n\tTue, 14 Jan 2020 06:09:42 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ndufresne-ca.20150623.gappssmtp.com; s=20150623;\n\th=mime-version:references:in-reply-to:from:date:message-id:subject:to\n\t:cc; bh=Qsrb2ck10a2QFVU2PM9PfFFoo3Mw/lkHYzHozAtwP2g=;\n\tb=vqcrGsBF0GTROLu/Xy8AVnsn0GoM+SyIwIanvjXp7G6FbxfF+0wDJU2+BYTiJa2EhM\n\tR+H347B1V9CujaXgjSPQQcf+XVvg+RlnD/QGrv+rMA3cwwwcEsSoO5xi6qkacprnHAlh\n\tF6mnYT1NMVLd+gmK6ulDrC/sVQIhl9cgg7M2Kup20Q4LbmawwfhZMYtk61DBgev6wthV\n\tq9GHM6g3ufykk7KqXmBE6xT1d/tS4rAWrU7s7wyRjlxkUiviLbzBBp2xFbm4xndjsa6u\n\tpjOylw3qCWHg3YsSnLcQNr+L808RxWelq1vd1fRiJhHhxLSPlhcT97ap8GWBlyu3zwRD\n\tqRtg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=Qsrb2ck10a2QFVU2PM9PfFFoo3Mw/lkHYzHozAtwP2g=;\n\tb=brx4+vMyXGkeMAAERilnmtsXARzon2+Ly8Z6PjbyeIyspbFAvgSFO+1cMy45hmFK2V\n\tb/i0IGEX6IHC765JsEoFeUyZF6lfx0vcp9wzWsasSxQhozakLJ3A+s+q6gkjiIP8LhP0\n\tGU/sKWf3n/TMVSp/woP1RbLAGMeDP81vqIc3EJAVXFidcP5JdOervbFpJqZ34QvgXYqf\n\t//uT4gKTvLXvJNw+mIL0AsdTjFylzlBSuIgLyTSe25m5EOz0e5aHJXDfmDdYQyKkaBSl\n\tMSaFH5PILKTesR1gufO8gcpVAygZprfv0yUpim6ext0sPuoK/ewS84256EaezCcgOe8Y\n\t9dKg==","X-Gm-Message-State":"APjAAAX5cfH+b3CWKZ746vRuCp6SZ75dOI2rQ7oEpiy4kzeHcX8pagm8\n\tOEnH4XW1kIT/gvw/zik+uP9H7YcHEmJ1u1DGvII7Ug==","X-Google-Smtp-Source":"APXvYqy0b8vgOVQIQXmLy7YAvxaSF5L77Seu6Sgxv9wXIhhidlNu8S8lcFmeBiL3K3ww8xgdHyRJJ4P6MLydGNl9tVA=","X-Received":"by 2002:a17:902:b10d:: with SMTP id\n\tq13mr27039262plr.14.1579010981161; \n\tTue, 14 Jan 2020 06:09:41 -0800 (PST)","MIME-Version":"1.0","References":"<1578660103-29974-1-git-send-email-madhavan.krishnan@linaro.org>\n\t\n\t<20200111200650.GA2960@pendragon.ideasonboard.com>","In-Reply-To":"<20200111200650.GA2960@pendragon.ideasonboard.com>","From":"Nicolas Dufresne ","Date":"Tue, 14 Jan 2020 09:09:29 -0500","Message-ID":"","To":"Laurent Pinchart ","Cc":"madhavan.krishnan@linaro.org, libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000a0ff03059c1a2462\"","Subject":"Re: [libcamera-devel] [PATCH] meson: import python3 to use also\n\tfrom sysroot","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 14 Jan 2020 14:09:43 -0000"}}]