[{"id":37271,"web_url":"https://patchwork.libcamera.org/comment/37271/","msgid":"<85h5ty2rms.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-10T17:06:35","subject":"Re: [PATCH v7 26/26] libcamera: software_isp: Add a gpuisp todo list","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> List the series of things to do in GPU ISP in perceived order of\n> difficulty.\n>\n> Acked-by: Kieran Bingham \n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/libcamera/software_isp/gpuisp-todo.txt | 40 ++++++++++++++++++++++\n> 1 file changed, 40 insertions(+)\n> create mode 100644 src/libcamera/software_isp/gpuisp-todo.txt\n>\n> diff --git a/src/libcamera/software_isp/gpuisp-todo.txt b/src/libcamera/software_isp/gpuisp-todo.txt\n> new file mode 100644\n> index 000000000..b9910d17d\n> --- /dev/null\n> +++ b/src/libcamera/software_isp/gpuisp-todo.txt\n> @@ -0,0 +1,40 @@\n> +List the TODOs in perceived order of ease.\n> +\n> +\n> +Denoising:\n> +\t- WIP\n> +\n> +Dead pixel correction:\n> +\t- WIP\n> +\n> +Lense shading correction:\n> +\t- WIP\n> +\n> +Use dma-buf handle to generate upload texture:\n> +\t- eglCreateImageKHR can be used to generate the upload texture i.e.\n> +\t to feed the bayer data into the GPU.\n> +\n> +processFrame() to run in its own thread:\n> +\t- processFrame() runs in the context of the Debayer::process()\n> +\t thread. Robert Mader suggested and it seems like a good\n> +\t suggestion too to run processFrame() in its own thread.\n> +\n> +Multi-pass shaders:\n> +\t- This needs some rewriging the idea is to have a list\n\nrewriting?\n\n> +\t of algorithms as is done in cpuisp iterating through the\n> +\t list in a for() loop.\n> +\t- The logic manging the loop has an initial input buffer\n\nmanaging?\n\n> +\t and the final output buffer.\n> +\t- The higher level logic must then inform each of the\n> +\t algorithms either to generate an internal working buffer\n> +\t or pass the final output buffer to the last shader\n> +\t in the list\n> +\t- This will allow for multi-pass shaders with the final\n> +\t algorithm presenting data not to its internal buffer\n> +\t but to the final output buffer\n\nAnother question is how to initialise shader variables, which are\ndifferent for each of the shaders. I think a two-pass solution would be\neasier and able to handle almost everything (pre-debayer stuff +\ndebayering in the first pass, post-debayer stuff in the second pass).\nWell, possibly with some exceptions like this one:\n\n> +24 bit output support:\n> +\t- Need to implment compute shader to do this.\n\nimplement\n\n> +\n> +Lense flare correction:\n> +\t- Not WIP still TBD","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D642CC3257\n\tfor ;\n\tWed, 10 Dec 2025 17:06:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 12F20614B1;\n\tWed, 10 Dec 2025 18:06:43 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74AA161499\n\tfor ;\n\tWed, 10 Dec 2025 18:06:41 +0100 (CET)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-180-7wu6RQ9yPm6gRjGJ5Jba-Q-1; Wed, 10 Dec 2025 12:06:38 -0500","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-42b2fb13b79so3564050f8f.3\n\tfor ;\n\tWed, 10 Dec 2025 09:06:38 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb ([213.175.37.14])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42fa8b85fcesm40761f8f.25.2025.12.10.09.06.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Dec 2025 09:06:36 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"LANLGM+G\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1765386400;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=67cYEGcHEApm/UYjrq01oA6dgsyM1AqnrcEw9GnJWrc=;\n\tb=LANLGM+GaQWKi0S/e0ma9WjDQIWzLOdgnTwT6bClEXiQf2ggJnbDgeSTIuYre9PGia0BY5\n\tziJDDeqplX1t0iMehu1hkFAGzFUTMlSDbdqMC1+ZwA2wYlBtokts971S+H9YygsIUzDE4A\n\taaml3GGYwfWWbL4BEYNCBOmzPvj4Kx4=","X-MC-Unique":"7wu6RQ9yPm6gRjGJ5Jba-Q-1","X-Mimecast-MFC-AGG-ID":"7wu6RQ9yPm6gRjGJ5Jba-Q_1765386397","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765386397; x=1765991197;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=67cYEGcHEApm/UYjrq01oA6dgsyM1AqnrcEw9GnJWrc=;\n\tb=ruTLmzQ5K2msb0mOUl1NbKJXa2MTVK5382u7Xfk1ru2p9dXOseGOMohmOuwzm2/ePN\n\th4Ona1ZOvTaewjzwc/0m8avoK4+nZmB7I49IHdXWg8BEskF5YEmSRdcJv1dcyeFhBfc6\n\tVnPPULK9zHkMkeJ1fnT4cNo2DDJJUJkhNE2qhE0zzht6ZMnjlzJ/9X2xFa5a++SDtJBL\n\t93LdwsZQeM+VMkQdf1LqnVu9LsXeuI+RmCuWs5zvU42QOfzMN/hkcm3L+XqgYIxLE6ex\n\tdJ2oPC6jRCKgbeqYzWWwqgZaPgSXUF1Q+mV5hrzlYE1INFMOQMnTS20kgtox2BbEg0U5\n\tFhHg==","X-Gm-Message-State":"AOJu0YzpjNRoTD/HQMsx4Gf5jxYXcsRBDovmMfyLH6t54guH4xl4tsWD\n\tLZS+IMadtMu56kV2XJ40xUR8otWM2upULTBTBLWAyUCV+vufjppjAsb0jnLik62VX4vT5PQlR8O\n\tEuUCQi0NRoSsOZQhXn7dB+oT8xUlZU3yZHfHZSdQMz+a6Fid0+mxMKmM5mKYHGfZ+CChOUNOfiC\n\tusB8G7wwU=","X-Gm-Gg":"AY/fxX6Hq3o1LtMg9rfoV0Gzo9xe1IRupvmHzSZBEorHTmkhxl9kos0vE7U3G8oNhVQ\n\tx/iz1Fi1XnA/sKMZCutvfld6GnqKDa7dJaBp//7fSbqfrSHoEfXptbJiHp0Fng5WgLr9DAAVp2L\n\tvXXC0cxhU5+QhhTzQWqug3BJl1l4bg/O/omk46Xn60aNY6jMwLwo7AG3j6xySXLxBJmYGOpE1CP\n\tyyAOPGIz5jLsoIE8ZkUa7UG9urFmcTx++IuCSPZarwArA5aqdS9wvyRi3jD3NmcpYfLf6aza6pk\n\tCCmeresGSwtjMlEKO+PgtYB5AdXydBA/BB+un8TTTMokTpRIYGLxQlOFi3z2jcCQQWAyi1FgoaR\n\tijM9hWJ/OZy4CGjArAjpFlw7hAQ==","X-Received":["by 2002:a05:6000:2409:b0:42b:2fc8:170 with SMTP id\n\tffacd0b85a97d-42fa39d8879mr3856171f8f.12.1765386397094; \n\tWed, 10 Dec 2025 09:06:37 -0800 (PST)","by 2002:a05:6000:2409:b0:42b:2fc8:170 with SMTP id\n\tffacd0b85a97d-42fa39d8879mr3856135f8f.12.1765386396609; \n\tWed, 10 Dec 2025 09:06:36 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IGZUVyDTYXr/ovoIBHpqdcNtx7ug5VQSmn5tPrYMBy09utNRygy/pO5AYGocAKebbTQnnLzlg==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz, Kieran Bingham\n\t","Subject":"Re: [PATCH v7 26/26] libcamera: software_isp: Add a gpuisp todo list","In-Reply-To":"<20251210005354.44726-27-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 10 Dec 2025 00:53:54 +0000\")","References":"<20251210005354.44726-1-bryan.odonoghue@linaro.org>\n\t<20251210005354.44726-27-bryan.odonoghue@linaro.org>","Date":"Wed, 10 Dec 2025 18:06:35 +0100","Message-ID":"<85h5ty2rms.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"poRaFQW4bSspPfXshe3F-I6Ega48_ZwQPinpKboQStc_1765386397","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]