{"id":25439,"url":"https://patchwork.libcamera.org/api/patches/25439/?format=json","web_url":"https://patchwork.libcamera.org/patch/25439/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251210005354.44726-23-bryan.odonoghue@linaro.org>","date":"2025-12-10T00:53:50","name":"[v7,22/26] ipa: simple: Add a flag to indicate gpuIspEnabled","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0c1bc586255c058c177ce219a907c9dbc875d561","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25439/mbox/","series":[{"id":5645,"url":"https://patchwork.libcamera.org/api/series/5645/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5645","date":"2025-12-10T00:53:28","name":"Add GLES 2.0 GPUISP to libcamera","version":7,"mbox":"https://patchwork.libcamera.org/series/5645/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25439/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25439/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E8000C3257\n\tfor ;\n\tWed, 10 Dec 2025 00:55:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A8DCC61487;\n\tWed, 10 Dec 2025 01:55:12 +0100 (CET)","from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com\n\t[IPv6:2607:f8b0:4864:20::1029])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0BC8C61487\n\tfor ;\n\tWed, 10 Dec 2025 01:55:11 +0100 (CET)","by mail-pj1-x1029.google.com with SMTP id\n\t98e67ed59e1d1-3436d6ca17bso6273638a91.3\n\tfor ;\n\tTue, 09 Dec 2025 16:55:10 -0800 (PST)","from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.55.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:55:09 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"RcFqvvSp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765328109; x=1765932909;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=RpmNx23wwhxFY8b9M7YdWQZvEEvZGAvLIcRd8AlfRWg=;\n\tb=RcFqvvSphUuLI+9nj3PNidWT8QUS1Ks0f6NonLexZ6OfcxyvIOW+rJbmjwm66RdteE\n\t4Wvd/OkntGxmp/+cGw7LbzF7L36E92PY9ptvf41O+mju3zyIlQsGVgaM+qJODL3++Ijc\n\tibbr4sr4exMXGeZNzcdyAFaE1EUhjskofkSp+Sdj2+cAF1N1/h/lcGeEYN4lTRaQCM3o\n\t+FKH2E++crrILqnhBAsFc8HPlhLseuI3ZwdmHddI1up1BbO8bV41z/Av8B/VBzi62ZYr\n\tzNcKgGSqp4JtqkjxvC4mTJ4wNzvYXIS/4flqlKQmqmseZ2zjw10uZLlD3Qi7WjUY6zmF\n\tZsVA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765328109; x=1765932909;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=RpmNx23wwhxFY8b9M7YdWQZvEEvZGAvLIcRd8AlfRWg=;\n\tb=FM858SsaR+DqhRjqIDMbQLGepQdS/qipidV/dBA8p0eI0XShD9p9djCc5saf0mD99o\n\t07zWudMUXlQ1H1aJ107ru5I+MByfPLyJol46ebt/C3wU3gUHBoj3Tp84XW8k0qSsot5S\n\tCdMDJM35x12FutZRIosWq2BQPbGcJBbSH+PUfzhzEe/sm5dlGVHMzaX0K9jYT22TMaPT\n\tNgYKUW8+B11XviFW4RGPzsHpjD5xQ6jp48s9eprJAnJ2FwxgDHc8/s6g08CnllXuldL/\n\tEkly2abJf8vYljIgN4dG0VDKdLl/VSjB488RpF3HR9OB8vsQ4qsbhSwnV3ghi+6mr/bB\n\t5C9Q==","X-Gm-Message-State":"AOJu0Yyxkx/hVM03MPV/2WfSf/2ORasKmHzW0WGX3ZzTvz+KP134gpiN\n\tBS9YsoXH2+2Xp7Vhif8YhZ04haJJ3gRuJXexG6VMU1quEPEZUtv6+JZTjB33HQ5WkeaMZApkEZx\n\tSDgCN","X-Gm-Gg":"ASbGncsnyl6wVDPA2zpKJElp3osetQ5b0jjeRUpEWRelms0OOpFuFXnZBzU6MKa4zLy\n\td6oVQI1ZTlt+AkKtFyxyDde3bzVHSJm21J8L8n9cIH2FfstC6AV8vPm1yrxtAUoUjldKEj8RwL8\n\trMJsqRpBdyBAC9QBogCt9Til8W42D1di/2gROQNu+zUYEsEotxMnIcmVdVV8w/jvA0ipl0UPkmf\n\t/I5e051Nw7/iMbuiyA9oehICxJyffAMQRu3cAX8LiBDj48pRleogjRHvn22rN9V9NCLG2bfwVKw\n\thFZHXaN4q+Qvm85dGLNyT0UZa5Eg7g0gJVlI5ZPyL7Xn6LW77r4mFElTB+WPWjnOlnGVXhKZrcf\n\tJ5JGv1KWtIjrNBn57Awyorvy0RjOu67R65F/4ml2qnxnu853VTIvv1Qn8ZKcKmTLwfQjUuckXFS\n\tkO9QP+k8Fb8akXBSa9iWJK3iy2rCc2DDuLaIB0eNNlMeooH7PC3paI7SMnppTCnN16","X-Google-Smtp-Source":"AGHT+IHPhPo4ZaImxeWHezBdiLWw0Kg5zYqNxd7ZHFHXKZ0GQdkHTZ0XdZ1PRkD6scz28JTnAtxJ+g==","X-Received":"by 2002:a05:6a20:918c:b0:366:14ac:e1fa with SMTP id\n\tadf61e73a8af0-366e31b9cefmr595130637.76.1765328109363; \n\tTue, 09 Dec 2025 16:55:09 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tMilan Zamazal ","Subject":"[PATCH v7 22/26] ipa: simple: Add a flag to indicate gpuIspEnabled","Date":"Wed, 10 Dec 2025 00:53:50 +0000","Message-ID":"<20251210005354.44726-23-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251210005354.44726-1-bryan.odonoghue@linaro.org>","References":"<20251210005354.44726-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Flag gpuIspEnabled in the simple IPA context. This flag will allow to\nselectively avoid some calculations or to generate a default CCM.\n\nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n include/libcamera/ipa/soft.mojom | 3 ++-\n src/ipa/simple/ipa_context.h | 1 +\n src/ipa/simple/soft_simple.cpp | 3 +++\n src/libcamera/software_isp/software_isp.cpp | 8 +++++++-\n 4 files changed, 13 insertions(+), 2 deletions(-)","diff":"diff --git a/include/libcamera/ipa/soft.mojom b/include/libcamera/ipa/soft.mojom\nindex 77328c5fd..aff8fcbd3 100644\n--- a/include/libcamera/ipa/soft.mojom\n+++ b/include/libcamera/ipa/soft.mojom\n@@ -17,7 +17,8 @@ interface IPASoftInterface {\n \t libcamera.SharedFD fdStats,\n \t libcamera.SharedFD fdParams,\n \t libcamera.IPACameraSensorInfo sensorInfo,\n-\t libcamera.ControlInfoMap sensorControls)\n+\t libcamera.ControlInfoMap sensorControls,\n+\t bool gpuIspEnabled)\n \t\t=> (int32 ret, libcamera.ControlInfoMap ipaControls, bool ccmEnabled);\n \tstart() => (int32 ret);\n \tstop();\ndiff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\nindex 03d8007ea..20c75de4e 100644\n--- a/src/ipa/simple/ipa_context.h\n+++ b/src/ipa/simple/ipa_context.h\n@@ -104,6 +104,7 @@ struct IPAContext {\n \tControlInfoMap::Map ctrlMap;\n \tbool ccmEnabled = false;\n \tbool selfInitialising = false;\n+\tbool gpuIspEnabled = false;\n };\n \n } /* namespace ipa::soft */\ndiff --git a/src/ipa/simple/soft_simple.cpp b/src/ipa/simple/soft_simple.cpp\nindex b147aca2e..2bbe271d9 100644\n--- a/src/ipa/simple/soft_simple.cpp\n+++ b/src/ipa/simple/soft_simple.cpp\n@@ -55,6 +55,7 @@ public:\n \t\t const SharedFD &fdParams,\n \t\t const IPACameraSensorInfo &sensorInfo,\n \t\t const ControlInfoMap &sensorControls,\n+\t\t bool gpuIspEnabled,\n \t\t ControlInfoMap *ipaControls,\n \t\t bool *ccmEnabled) override;\n \tint configure(const IPAConfigInfo &configInfo) override;\n@@ -95,6 +96,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t\t\tconst SharedFD &fdParams,\n \t\t\tconst IPACameraSensorInfo &sensorInfo,\n \t\t\tconst ControlInfoMap &sensorControls,\n+\t\t\tbool gpuIspEnabled,\n \t\t\tControlInfoMap *ipaControls,\n \t\t\tbool *ccmEnabled)\n {\n@@ -106,6 +108,7 @@ int IPASoftSimple::init(const IPASettings &settings,\n \t}\n \n \tcontext_.sensorInfo = sensorInfo;\n+\tcontext_.gpuIspEnabled = gpuIspEnabled;\n \n \t/* Load the tuning data file */\n \tFile file(settings.configurationFile);\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 06f93ee0f..1aa4357ad 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -121,6 +121,8 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t}\n \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n \n+\tbool gpuIspEnabled;\n+\n #if HAVE_DEBAYER_EGL\n \tstd::optional softISPMode = configuration.envOption(\"LIBCAMERA_SOFTISP_MODE\", { \"software_isp\", \"mode\" });\n \tif (softISPMode) {\n@@ -137,10 +139,13 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\tLOG(SoftwareIsp, Error) << \"Failed to instantiate GPUISP\";\n \t\t\treturn;\n \t\t}\n+\t\tgpuIspEnabled = true;\n \t}\n #endif\n-\tif (!debayer_)\n+\tif (!debayer_) {\n \t\tdebayer_ = std::make_unique(std::move(stats), configuration);\n+\t\tgpuIspEnabled = false;\n+\t}\n \n \tif (!debayer_) {\n \t\tLOG(SoftwareIsp, Error) << \"Failed to create Debayer object\";\n@@ -177,6 +182,7 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\t sharedParams_.fd(),\n \t\t\t sensorInfo,\n \t\t\t sensor->controls(),\n+\t\t\t gpuIspEnabled,\n \t\t\t ipaControls,\n \t\t\t &ccmEnabled_);\n \tif (ret) {\n","prefixes":["v7","22/26"]}