[{"id":37263,"web_url":"https://patchwork.libcamera.org/comment/37263/","msgid":"<85345i47zw.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-10T16:27:47","subject":"Re: [PATCH v7 19/26] ipa: software_isp: Add a selfInitialising flag\n\tto IPAContext","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> This flag when true indicates that an algorithm should self-initialse\n> instead of consuming YAML data.\n>\n> Signed-off-by: Bryan O'Donoghue \n\nAgain, this patch granularity is too much for my taste, but OK.\n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/ipa/simple/ipa_context.h | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/simple/ipa_context.h b/src/ipa/simple/ipa_context.h\n> index c3081e306..03d8007ea 100644\n> --- a/src/ipa/simple/ipa_context.h\n> +++ b/src/ipa/simple/ipa_context.h\n> @@ -103,6 +103,7 @@ struct IPAContext {\n> \tFCQueue frameContexts;\n> \tControlInfoMap::Map ctrlMap;\n> \tbool ccmEnabled = false;\n> +\tbool selfInitialising = false;\n> };\n> \n> } /* namespace ipa::soft */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5BBA8C3257\n\tfor ;\n\tWed, 10 Dec 2025 16:27:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A1C106149B;\n\tWed, 10 Dec 2025 17:27:54 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5671561480\n\tfor ;\n\tWed, 10 Dec 2025 17:27:53 +0100 (CET)","from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n\t[209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-649-2ZytvIIvNgqG_GkBJC3gXQ-1; Wed, 10 Dec 2025 11:27:51 -0500","by mail-wr1-f70.google.com with SMTP id\n\tffacd0b85a97d-42b3c965ce5so5762464f8f.2\n\tfor ;\n\tWed, 10 Dec 2025 08:27:50 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb ([213.175.37.14])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42f7cbfee71sm38795431f8f.15.2025.12.10.08.27.48\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Dec 2025 08:27:48 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"XHvvilvO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1765384072;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=PG8PSxLPv6VqPiyAYutw6cQ6xBH5JQHcLnKWMtqpYO4=;\n\tb=XHvvilvOkARYrKmPXjm9oT1gauH0Qe9aK/S+d9XQDISGmrZTt5n3xJGALcQ79WTKT7aG62\n\tbrbrZ/m/f4Jtm49a2VuWnTmkemn8i4HOPuFwVvwrM45T+i67ChuGxIQ25vjmKDWrLHliSV\n\tYPSRE73VwtjU5wIJ2+8c1SCCJEiJ9dM=","X-MC-Unique":"2ZytvIIvNgqG_GkBJC3gXQ-1","X-Mimecast-MFC-AGG-ID":"2ZytvIIvNgqG_GkBJC3gXQ_1765384070","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765384070; x=1765988870;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=PG8PSxLPv6VqPiyAYutw6cQ6xBH5JQHcLnKWMtqpYO4=;\n\tb=NxbFXfXFqbpY6KmQlXZw4Y93o51nA/hiAEWQVnEq8pxc4ECqOv6/MEu4/wWQs7rw1S\n\t954yHpxYBnKfFn6F08HTK++dHAylJiD8z1MAnmFwOx1L7DJ8cro//UJRdFCiJi4kEnt8\n\txIgkl19Q/U5mV0rHB3OFmKhDrYII8uihfdV0Ud3ujnJX9z2RwlmTI5UHpZRZwapCFpdN\n\t2HiShqcFpKJ3MmxG4HJjjnWh93XAJF9f9q/x7cEJXB4LRcHCyVJpq21Ph3+tNAV9MEMa\n\tqlDA8NTU9kO7QsFlCuVKZX986mngdSHQwyuA9nFoIZSpdmMD2RR8yRCs5cjV9FHniE8w\n\tnCpA==","X-Gm-Message-State":"AOJu0YzZVWcZCCxgkv66KaPCzsUCZJDAyGN53CZ+9J3wFsZz1Shx/SZ5\n\tmOagpA7uZiDOr6rEOosCGPK4D0a7CwQjJi2JYFXjxW861PUGMVf/CPgHCzeOeSgsB7JrP8RzWQN\n\tuFZFFG9Mx3d3P94SOCgt7TiMqJ4C+LhzIb53nv2B99QK6ZY7rGD5GZgkkxjfB+2db1HwWsrPxF8\n\tY=","X-Gm-Gg":"AY/fxX7Tsrlnwcg+an4Lucwa2sfOexSTGVZdIfUrBwIa6EgU3Tm/M/Cqhri+T16Szra\n\ttFcw/TJs5ykrRL3MJPi3Exn1mK305jtMOz/Ea2BUSPfmcX0nZNClzvW2MKbUtPCUSnivyzzMWKv\n\tWc4yb/adnhRDQmzg2kovMn7JVfhftCGDF03g//VJ86EDgymHt8zOq3E11gEJB5mkJiKd6Fr1g6y\n\tO0mqAlyCDO7Tyd7Vf+KxLm2kE/YHUNSBKpyFkbezJyJMUf9c3iWSv4oAv9qihxwU6s5vXJJ9tkK\n\t/DeRWnCdOyZKytFaOsOMZKHaxdMfW4h96RGbRfjbXuQOywrd7+d77+nDLeuBWMwiyv8V7+lG7Cy\n\tof8wUBaKWnO7YxuSuj/n3F4eSHg==","X-Received":["by 2002:a05:6000:200e:b0:42b:3ace:63c6 with SMTP id\n\tffacd0b85a97d-42fa39d41d0mr3268389f8f.16.1765384069800; \n\tWed, 10 Dec 2025 08:27:49 -0800 (PST)","by 2002:a05:6000:200e:b0:42b:3ace:63c6 with SMTP id\n\tffacd0b85a97d-42fa39d41d0mr3268374f8f.16.1765384069371; \n\tWed, 10 Dec 2025 08:27:49 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IGVVpKDuxhQXsPg5oBeFUp+IUxEvqwYWAhyerT9FBjDhMlmXCnjcqt41NeEp4BuKlDA4tbwVg==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz","Subject":"Re: [PATCH v7 19/26] ipa: software_isp: Add a selfInitialising flag\n\tto IPAContext","In-Reply-To":"<20251210005354.44726-20-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 10 Dec 2025 00:53:47 +0000\")","References":"<20251210005354.44726-1-bryan.odonoghue@linaro.org>\n\t<20251210005354.44726-20-bryan.odonoghue@linaro.org>","Date":"Wed, 10 Dec 2025 17:27:47 +0100","Message-ID":"<85345i47zw.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"WAY1zP9D9egBtFs2GkG5k_rlcHcgJRShNvrmow9KUrY_1765384070","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]