[{"id":37257,"web_url":"https://patchwork.libcamera.org/comment/37257/","msgid":"<85tsxy4b2n.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-10T15:21:20","subject":"Re: [PATCH v7 13/26] libcamera: software_isp: Add a Size_ member\n\tvariable to pass to eGL later","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> We will be initialising eGL from Debayer::start(). We need a copy of the\n> size data passed in configure() to tell the fragment shaders the right\n> output size.\n>\n> Signed-off-by: Bryan O'Donoghue \n\nI'm not sure these patches are worth to be standalone instead of\nsquashed to the places where the variables are used but anyway:\n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/software_isp/debayer.cpp | 5 +++++\n> src/libcamera/software_isp/debayer.h | 1 +\n> 2 files changed, 6 insertions(+)\n>\n> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\n> index ebd3e3a8b..4e7b61d6b 100644\n> --- a/src/libcamera/software_isp/debayer.cpp\n> +++ b/src/libcamera/software_isp/debayer.cpp\n> @@ -300,6 +300,11 @@ Debayer::~Debayer()\n> * \\brief The output pixel format.\n> */\n> \n> +/**\n> + * \\var Debayer::outputSize_\n> + * \\brief Output size object\n> + */\n> +\n> /**\n> * \\var Debayer::red_\n> * \\brief Lookup table for red channel gain and correction values.\n> diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\n> index 4a2ec3e53..189b32930 100644\n> --- a/src/libcamera/software_isp/debayer.h\n> +++ b/src/libcamera/software_isp/debayer.h\n> @@ -75,6 +75,7 @@ public:\n> \n> \tDebayerInputConfig inputConfig_;\n> \tDebayerOutputConfig outputConfig_;\n> +\tSize outputSize_;\n> \tPixelFormat inputPixelFormat_;\n> \tPixelFormat outputPixelFormat_;\n> \tDebayerParams::LookupTable red_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 05A4EBD1F1\n\tfor ;\n\tWed, 10 Dec 2025 15:21:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1D0E661491;\n\tWed, 10 Dec 2025 16:21:27 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E654D61480\n\tfor ;\n\tWed, 10 Dec 2025 16:21:25 +0100 (CET)","from mail-wr1-f71.google.com (mail-wr1-f71.google.com\n\t[209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-549-TARAamMkPK6VVildOUJyRg-1; Wed, 10 Dec 2025 10:21:23 -0500","by mail-wr1-f71.google.com with SMTP id\n\tffacd0b85a97d-42b478551a6so3853999f8f.1\n\tfor ;\n\tWed, 10 Dec 2025 07:21:23 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb ([213.175.37.14])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42f7d222478sm37833621f8f.20.2025.12.10.07.21.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Dec 2025 07:21:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"H2x8wl3h\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1765380084;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=OmfWxMGwCLhAONdPBzWEDvv4x/5bWr1nYmmm1SAM6XI=;\n\tb=H2x8wl3hDZwLBbnREmIaGdlEegCeNjUzlP9rBciW7eUgDjMcX87SzNG6RIY5qnUMruPci/\n\tkEnjeu/7nb34NRO0OehKRXLRAYLYT2JUdeo+L0CgH7ePYhjG3VE7bKQ+FPD5k2stg6CfWK\n\txhPPp3iJIBS6ae2r2hwWy3h3ofN3o4U=","X-MC-Unique":"TARAamMkPK6VVildOUJyRg-1","X-Mimecast-MFC-AGG-ID":"TARAamMkPK6VVildOUJyRg_1765380082","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765380082; x=1765984882;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=OmfWxMGwCLhAONdPBzWEDvv4x/5bWr1nYmmm1SAM6XI=;\n\tb=W15ZnnfZI2U8LACvkPabvI8uH1arMmPNeAQS/35CUl7NViaGed8g/hhHwOv/3mQSsg\n\t1vuVHNd6Q4QkTFtI1QLc3hvBK3e+ZGbb7DFGJ/Mw3h7zx+WZezSUWHZmFvzY6Aoil5qh\n\tBBu5bzHyzENyRhtBRt6GkXAbpKiICTXZuGeXu0ArgJ6tdpAOZblOakyHu9BK5ai7Yaf5\n\tMlBm7q8MqFtVTp+R4hS+aJEi8L0DP1ULmjIDe9L616Bgf/bGMHnTCfJV4liFCpXhqJs5\n\tO2MoL+SfXqAQkfiDuwxS8YIpkmDi+aBeZ+dPNJqva08hpWEpXkDeLAClJICAuaCPKmsK\n\tuywQ==","X-Gm-Message-State":"AOJu0YxmrdyWoX6PT1UZhEqV6VwqxQXjkiq2Mr6UQtPrkqK9uhfdWGbZ\n\tTy6rzhMoRFlYDEP1F3THMWabLaLO3bbAqbODpU5fQVlNFk7d8MyeF672Lv3uVs74Wln1WK63vx/\n\toGwNrl6dMu3gHKgLJPDBNQqqWQyerpvl9JPoc+6kfE7S9XI2PCSC5/xQRGwlFP476EnI150FRyI\n\t5o2OnsFmM=","X-Gm-Gg":"AY/fxX4z+d/ksnSb72n+FeRVjmtmkJVPAT1KF1JA4wd2l7U6agprr32XVgQLabQv6PI\n\tDttWyFEYTXh3kuFM4FpSgOR2MACDOo2Ve8/ESBH4TiIdAcjcKL0YiKyz/+jF7qlW0H+J+TIzKRK\n\t8+PRr+/1XNZgO7aN9yryvfqt7jUAWRYdZzJE8swunC27hxI3WQogL89cLQazLNJM8Dku5KZV14f\n\tnnt3Xd6orPDLxSrFw2kLfSQQNbKIJPx4PyPJwzpwN0gq4+ZV+1SuGNZcq74W2V/lK2Xqlcjrtt1\n\t+HznWdNM10+Q1ICuTFVbyWwjeLYqtx8J12Pmd4WL3H4CVwouw2rdI9b7D4L6+4WnOAR+WoLzJhv\n\tpwYP4MnS7SL7Bozo2kp1HE+dMJg==","X-Received":["by 2002:a5d:64c9:0:b0:42f:9f9e:d1d0 with SMTP id\n\tffacd0b85a97d-42fa39caa3dmr3110558f8f.3.1765380081822; \n\tWed, 10 Dec 2025 07:21:21 -0800 (PST)","by 2002:a5d:64c9:0:b0:42f:9f9e:d1d0 with SMTP id\n\tffacd0b85a97d-42fa39caa3dmr3110529f8f.3.1765380081418; \n\tWed, 10 Dec 2025 07:21:21 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IH+fH5qFwXQzxjWwWNgL/cWuN+G8on0bitkanzkEDCNYlphuVlA/e4CoFv4tuW0EKBbU8D4cw==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz","Subject":"Re: [PATCH v7 13/26] libcamera: software_isp: Add a Size_ member\n\tvariable to pass to eGL later","In-Reply-To":"<20251210005354.44726-14-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 10 Dec 2025 00:53:41 +0000\")","References":"<20251210005354.44726-1-bryan.odonoghue@linaro.org>\n\t<20251210005354.44726-14-bryan.odonoghue@linaro.org>","Date":"Wed, 10 Dec 2025 16:21:20 +0100","Message-ID":"<85tsxy4b2n.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"jwXf_0uDObBz5cF6UpxG3OyO_8lHaRsP0nAF25Sihfw_1765380082","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]