[{"id":3392,"web_url":"https://patchwork.libcamera.org/comment/3392/","msgid":"<20200108232340.fphhg6coghtrrftb@uno.localdomain>","date":"2020-01-08T23:23:40","subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Fix compilation\n\terror use of undeclared identifier 'ret'","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"uuuups\n\nOn Thu, Jan 09, 2020 at 12:15:18AM +0100, Niklas Söderlund wrote:\n> Refactoring of the camera_proxy have left the 'ret' variable undeclared,\n> declare it.\n>\n> ../../src/v4l2/v4l2_camera_proxy.cpp:273:2: error: use of undeclared identifier 'ret'\n> ret = vcam_->invokeMethod(&V4L2Camera::configure,\n> ^\n> ../../src/v4l2/v4l2_camera_proxy.cpp:278:6: error: use of undeclared identifier 'ret'\n> if (ret < 0)\n>\n> Fixes: fce110c6d961c3bb (\"v4l2: camera_proxy: Break out try_fmt\")\n> Signed-off-by: Niklas Söderlund \n\nAcked-by: Jacopo Mondi \n\nembarrassing indeed!\n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n>\n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 89dd7166ca527bad..00d0d57172022138 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -270,11 +270,11 @@ int V4L2CameraProxy::vidioc_s_fmt(struct v4l2_format *arg)\n> \ttryFormat(arg);\n>\n> \tSize size(arg->fmt.pix.width, arg->fmt.pix.height);\n> -\tret = vcam_->invokeMethod(&V4L2Camera::configure,\n> -\t\t\t\t ConnectionTypeBlocking,\n> -\t\t\t\t &streamConfig_, size,\n> -\t\t\t\t v4l2ToDrm(arg->fmt.pix.pixelformat),\n> -\t\t\t\t bufferCount_);\n> +\tint ret = vcam_->invokeMethod(&V4L2Camera::configure,\n> +\t\t\t\t ConnectionTypeBlocking,\n> +\t\t\t\t &streamConfig_, size,\n> +\t\t\t\t v4l2ToDrm(arg->fmt.pix.pixelformat),\n> +\t\t\t\t bufferCount_);\n> \tif (ret < 0)\n> \t\treturn -EINVAL;\n>\n> --\n> 2.24.1\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A65D36045D\n\tfor ;\n\tThu, 9 Jan 2020 00:21:14 +0100 (CET)","from uno.localdomain (2-224-242-101.ip172.fastwebnet.it\n\t[2.224.242.101]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 108CB100002;\n\tWed, 8 Jan 2020 23:21:13 +0000 (UTC)"],"Date":"Thu, 9 Jan 2020 00:23:40 +0100","From":"Jacopo Mondi ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200108232340.fphhg6coghtrrftb@uno.localdomain>","References":"<20200108231518.1852151-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"tjumqw2bv5ylhxa6\"","Content-Disposition":"inline","In-Reply-To":"<20200108231518.1852151-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Fix compilation\n\terror use of undeclared identifier 'ret'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 08 Jan 2020 23:21:14 -0000"}},{"id":3393,"web_url":"https://patchwork.libcamera.org/comment/3393/","msgid":"<20200108232415.GA9237@pendragon.ideasonboard.com>","date":"2020-01-08T23:24:15","subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Fix compilation\n\terror use of undeclared identifier 'ret'","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Niklas,\n\nThank you for the patch.\n\nOn Thu, Jan 09, 2020 at 12:15:18AM +0100, Niklas Söderlund wrote:\n> Refactoring of the camera_proxy have left the 'ret' variable undeclared,\n> declare it.\n> \n> ../../src/v4l2/v4l2_camera_proxy.cpp:273:2: error: use of undeclared identifier 'ret'\n> ret = vcam_->invokeMethod(&V4L2Camera::configure,\n> ^\n> ../../src/v4l2/v4l2_camera_proxy.cpp:278:6: error: use of undeclared identifier 'ret'\n> if (ret < 0)\n> \n> Fixes: fce110c6d961c3bb (\"v4l2: camera_proxy: Break out try_fmt\")\n> Signed-off-by: Niklas Söderlund \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 89dd7166ca527bad..00d0d57172022138 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -270,11 +270,11 @@ int V4L2CameraProxy::vidioc_s_fmt(struct v4l2_format *arg)\n> \ttryFormat(arg);\n> \n> \tSize size(arg->fmt.pix.width, arg->fmt.pix.height);\n> -\tret = vcam_->invokeMethod(&V4L2Camera::configure,\n> -\t\t\t\t ConnectionTypeBlocking,\n> -\t\t\t\t &streamConfig_, size,\n> -\t\t\t\t v4l2ToDrm(arg->fmt.pix.pixelformat),\n> -\t\t\t\t bufferCount_);\n> +\tint ret = vcam_->invokeMethod(&V4L2Camera::configure,\n> +\t\t\t\t ConnectionTypeBlocking,\n> +\t\t\t\t &streamConfig_, size,\n> +\t\t\t\t v4l2ToDrm(arg->fmt.pix.pixelformat),\n> +\t\t\t\t bufferCount_);\n> \tif (ret < 0)\n> \t\treturn -EINVAL;\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 619516045D\n\tfor ;\n\tThu, 9 Jan 2020 00:24:27 +0100 (CET)","from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi\n\t[81.175.216.236])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E2CC29F4;\n\tThu, 9 Jan 2020 00:24:26 +0100 (CET)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1578525867;\n\tbh=7zhAYhxueFSOG4+FUf/XWlXUrmWju8+qbFvfqVgEW/A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Fytlh1UianwOLKUJcxfpszfUkb2wmln26WvNUMxLu69UnxkuiHYI4s96Qh0/CxoMJ\n\tiIYWVJPJu6dbjkZSSwIqDGxPx3ySkPXw23dE9rTfHRAwd9tbsHdj63UTdguEo305Fi\n\t2r2cRVOJLQKUN3+83ux9rDZYX1qeHCsSbpXitVL8=","Date":"Thu, 9 Jan 2020 01:24:15 +0200","From":"Laurent Pinchart ","To":"Niklas =?utf-8?q?S=C3=B6derlund?= ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200108232415.GA9237@pendragon.ideasonboard.com>","References":"<20200108231518.1852151-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200108231518.1852151-1-niklas.soderlund@ragnatech.se>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Fix compilation\n\terror use of undeclared identifier 'ret'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 08 Jan 2020 23:24:27 -0000"}},{"id":3394,"web_url":"https://patchwork.libcamera.org/comment/3394/","msgid":"<20200108234458.GA605001@oden.dyn.berto.se>","date":"2020-01-08T23:44:58","subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Fix compilation\n\terror use of undeclared identifier 'ret'","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi,\n\nPushed to master.\n\nOn 2020-01-09 00:15:18 +0100, Niklas Söderlund wrote:\n> Refactoring of the camera_proxy have left the 'ret' variable undeclared,\n> declare it.\n> \n> ../../src/v4l2/v4l2_camera_proxy.cpp:273:2: error: use of undeclared identifier 'ret'\n> ret = vcam_->invokeMethod(&V4L2Camera::configure,\n> ^\n> ../../src/v4l2/v4l2_camera_proxy.cpp:278:6: error: use of undeclared identifier 'ret'\n> if (ret < 0)\n> \n> Fixes: fce110c6d961c3bb (\"v4l2: camera_proxy: Break out try_fmt\")\n> Signed-off-by: Niklas Söderlund \n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index 89dd7166ca527bad..00d0d57172022138 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -270,11 +270,11 @@ int V4L2CameraProxy::vidioc_s_fmt(struct v4l2_format *arg)\n> \ttryFormat(arg);\n> \n> \tSize size(arg->fmt.pix.width, arg->fmt.pix.height);\n> -\tret = vcam_->invokeMethod(&V4L2Camera::configure,\n> -\t\t\t\t ConnectionTypeBlocking,\n> -\t\t\t\t &streamConfig_, size,\n> -\t\t\t\t v4l2ToDrm(arg->fmt.pix.pixelformat),\n> -\t\t\t\t bufferCount_);\n> +\tint ret = vcam_->invokeMethod(&V4L2Camera::configure,\n> +\t\t\t\t ConnectionTypeBlocking,\n> +\t\t\t\t &streamConfig_, size,\n> +\t\t\t\t v4l2ToDrm(arg->fmt.pix.pixelformat),\n> +\t\t\t\t bufferCount_);\n> \tif (ret < 0)\n> \t\treturn -EINVAL;\n> \n> -- \n> 2.24.1\n>","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CCDF160670\n\tfor ;\n\tThu, 9 Jan 2020 00:45:00 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id n12so3798959lfe.3\n\tfor ;\n\tWed, 08 Jan 2020 15:45:00 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tr20sm2082314lfi.91.2020.01.08.15.44.58\n\tfor \n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 Jan 2020 15:44:59 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=1rrmUE5aAX0dsNXFDh5sJs9fTDyK+byKMiZKw0CkRkk=;\n\tb=e/aLYyhyUzamswcqTkPhPXu3SNyMWVR+da+2syXuslu4qO9cSUhnYDAtJgiPeuNPKO\n\t7trAyV4XDI9kAMuiFfAF5HAyCOP0vvpEKAhYB+XPZ9OO9y2G5DjNxE8zyyqERG/trtV6\n\tHi2hrkDHqfXfZmu2GVmditramwHt7m88Z8eIC1CO37pbLTPQPdAIjTMGi7hrHCxy0I+K\n\tdTpk3ZU5xDK0NcyA7AK7Zd4u/mcwLA5cvvmWFKDEnm4f91j9SWuPjb35wtSzX5TNXc8Z\n\te6BPyD2OkBiR+vLaryyI02TxppIyA2m6NtaPfKNVuAUDqgUdeWQIZGILeEIAED6Tnqzl\n\taROg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=1rrmUE5aAX0dsNXFDh5sJs9fTDyK+byKMiZKw0CkRkk=;\n\tb=aGd5JBaOyIN/5BmMUWo5JY1DlqfUkyzao7rVB6eD+HV1qk48zfeg1W7or9bj/L/ska\n\tgb9bvoLkN78JjiUQfocoSnXusvKakefCxYYRYqoVIBvm3nHryLgnXrRpolWDZo8/MFPv\n\tdHRN2Yx8DYoOdFMrXlFDUXLjSMyzGC0NFbg8tju1JSrKYEyynWTz1TRmLjvefV9fLjLL\n\topp8t2Xd9UZ2D2YR7N20IYntE5SZfc9yrxakQUK2cs5rrsL1eSjQ+8ouX5VPnt/cYOXF\n\tyBdBgRR3nI1MfKv25mbI0CvXyWQR5oaU+4IsSRAreRpZMYs2WOPcXyqJ7EbHKxavlaMK\n\tjZcQ==","X-Gm-Message-State":"APjAAAXmxIGu5FYPq/zY1JeiKLjoLssGoU5Pix4nHy5pAs8MGMSKWg/s\n\tpdHr3vbB+yL1rnZ/tUpynIcmmlLvFGyKZA==","X-Google-Smtp-Source":"APXvYqzpOb8dr4enF99PKklUN0OxKWOPqI8uDH4vJ6FPGUcN+31TaaD/s+dqiSTciRmsTHVVAcJ1Jw==","X-Received":"by 2002:a19:84d:: with SMTP id 74mr4239574lfi.122.1578527099874; \n\tWed, 08 Jan 2020 15:44:59 -0800 (PST)","Date":"Thu, 9 Jan 2020 00:44:58 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200108234458.GA605001@oden.dyn.berto.se>","References":"<20200108231518.1852151-1-niklas.soderlund@ragnatech.se>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200108231518.1852151-1-niklas.soderlund@ragnatech.se>","Subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Fix compilation\n\terror use of undeclared identifier 'ret'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 08 Jan 2020 23:45:01 -0000"}}]