[{"id":37254,"web_url":"https://patchwork.libcamera.org/comment/37254/","msgid":"<85y0na4dj1.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-10T14:28:18","subject":"Re: [PATCH v7 12/26] libcamera: software_isp: Add member variables\n\tto track selected input/output pixelFormat","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> In order to have Debayer::start() tell the eGL shader compilation routine what\n> the input and output pixel format is, we need to have a copy of the\n> selected format available. Add variables to the inputConfig and\n> outputConfig structures to allow tracking of this data for later use.\n>\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> src/libcamera/software_isp/debayer.cpp | 10 ++++++++++\n> src/libcamera/software_isp/debayer.h | 2 ++\n> 2 files changed, 12 insertions(+)\n>\n> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\n> index 63a61daf9..ebd3e3a8b 100644\n> --- a/src/libcamera/software_isp/debayer.cpp\n> +++ b/src/libcamera/software_isp/debayer.cpp\n> @@ -290,6 +290,16 @@ Debayer::~Debayer()\n> * output image buffer. Set during stream configuration.\n> */\n> \n> +/**\n> + * \\var Debayer::inputPixelFormat_\n> + * \\brief The incoming pixel format.\n\nNo end of line dot in \\brief. The same below.\n\nReviewed-by: Milan Zamazal \n\n> + */\n> +\n> +/**\n> + * \\var Debayer::outputPixelFormat_\n> + * \\brief The output pixel format.\n> + */\n> +\n> /**\n> * \\var Debayer::red_\n> * \\brief Lookup table for red channel gain and correction values.\n> diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\n> index 5c0cb3914..4a2ec3e53 100644\n> --- a/src/libcamera/software_isp/debayer.h\n> +++ b/src/libcamera/software_isp/debayer.h\n> @@ -75,6 +75,8 @@ public:\n> \n> \tDebayerInputConfig inputConfig_;\n> \tDebayerOutputConfig outputConfig_;\n> +\tPixelFormat inputPixelFormat_;\n> +\tPixelFormat outputPixelFormat_;\n> \tDebayerParams::LookupTable red_;\n> \tDebayerParams::LookupTable green_;\n> \tDebayerParams::LookupTable blue_;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B33A5BD1F1\n\tfor ;\n\tWed, 10 Dec 2025 14:28:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 09C616148A;\n\tWed, 10 Dec 2025 15:28:25 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DC24613CB\n\tfor ;\n\tWed, 10 Dec 2025 15:28:23 +0100 (CET)","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n\t[209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-345--NiE6TvVOtGx7Ul_HXTbYw-1; Wed, 10 Dec 2025 09:28:21 -0500","by mail-wm1-f70.google.com with SMTP id\n\t5b1f17b1804b1-4775d110fabso61376215e9.1\n\tfor ;\n\tWed, 10 Dec 2025 06:28:21 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb ([213.175.46.86])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-47a82d4a995sm48251505e9.13.2025.12.10.06.28.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 10 Dec 2025 06:28:19 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"YcO8BhdW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1765376902;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=A6TwDKRPmRUTP4RhZtz0E70U3y3o98MY1jvJ0Du9cB0=;\n\tb=YcO8BhdW4JIsYWfBpe7LBFMQ5h3TjnUvU+a9YKUWZHV3sxscgI4b+FMp2Y9Zxg7GtZtpK5\n\tLcy8PJsWirazSOxLmalc73QtIMb26jPQln8v/SwGbbVUhUiIm6XW/bVx0/YxCggWjT08vc\n\trRw0L7CLkF/mBk2A9nTFrDgnbAxxG3A=","X-MC-Unique":"-NiE6TvVOtGx7Ul_HXTbYw-1","X-Mimecast-MFC-AGG-ID":"-NiE6TvVOtGx7Ul_HXTbYw_1765376900","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765376900; x=1765981700;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=A6TwDKRPmRUTP4RhZtz0E70U3y3o98MY1jvJ0Du9cB0=;\n\tb=JCCb4x/f3zF7QlrN1f4HXPdpvwNijPH/AcdaJrsUjlmcmKL4PIlwp7i17Q1/UMlGIo\n\ti7A2qK1cc+FdnpJnW9D9q+eR0xvSx+Ln4nWDV9gdhgVQpvcrzluJ+/WQWisqgqbJPvxn\n\tq2fUhfaEHI3qTM5iI0srYqAhmTaEEpytZ+erzygma3fmiXyayBtYlZpcn/r+jbINM7L7\n\t6wu9GugmaxbNAkcDXFEylhhVxdVTihrARY0pWZ9G/5CywxTHJ8TQDskh4qK3B6A73XFZ\n\tBjZHxNJYdweLQxwE0QfqqqhRA2iEnxvpxHbOkNFlLMAbWzXbCrFT337QfO5e02Et2Jy5\n\tBDpg==","X-Gm-Message-State":"AOJu0YzcIvQUSnprNoyyDejeK6IHwNvCT3krbBHyCsJ2OsSXNoyNROjO\n\t5NABPQowmIE0mZgZAy1z+6138PyPUkRxG9pHicc8CYwQJGcYi7G98W7gcX5RBcGpmTEH++kLo1S\n\trtPUNZTYZNW9huq1MbooEaEK4RSyr4Jj/0KfWId3CupC758/uR4ZiVSaOzrQpRUqJEMsX1UCiCA\n\tyUKO1qlWc=","X-Gm-Gg":"ASbGncvmzl8tdopNXCg40RQOijiaBuSB40aVKyVH6LH2qk7PyQ7bjJUmQlHPoD05Lf9\n\tGzTPprAVTNnvTUscUn64gGZaXaHXaFQ/xXZpKRbLFkOuWyrpj6IQxp2/YfcjFDm5UMeyp8k88lb\n\tE6TcOatmiQ9KCdpmNMa4UIJKaerKrvB2Fp1xh67zSLyPfZ7U9MSZ6FYqmL/lR0MNy7hHxTKkuiI\n\tn9j8RidT1OPxs+1IrfiyywII6Q/uiDE5uKR1TlYNBckbqATwXaQxg4EFktDnxn2ROwndGb9M+nU\n\tyTUQhJdNm6Rjq6zfloj9LzI36KqlCW7Km7aqV2X4cIgHU2P3++nnxToAd69/nLp24KHazPaUCH4\n\tmlRNQ0wTC7aU2D72Dud7QrIA5lg==","X-Received":["by 2002:a05:600c:3b92:b0:471:13dd:bae7 with SMTP id\n\t5b1f17b1804b1-47a8384ddc1mr30886275e9.30.1765376900168; \n\tWed, 10 Dec 2025 06:28:20 -0800 (PST)","by 2002:a05:600c:3b92:b0:471:13dd:bae7 with SMTP id\n\t5b1f17b1804b1-47a8384ddc1mr30885835e9.30.1765376899704; \n\tWed, 10 Dec 2025 06:28:19 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IHKr10+GltGuD9WpwoADbIJd1KR0oCkkzSbH7qioXxiwPAwiEH3xjKZ8U0scUo7B6FVHDrfSg==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz","Subject":"Re: [PATCH v7 12/26] libcamera: software_isp: Add member variables\n\tto track selected input/output pixelFormat","In-Reply-To":"<20251210005354.44726-13-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Wed, 10 Dec 2025 00:53:40 +0000\")","References":"<20251210005354.44726-1-bryan.odonoghue@linaro.org>\n\t<20251210005354.44726-13-bryan.odonoghue@linaro.org>","Date":"Wed, 10 Dec 2025 15:28:18 +0100","Message-ID":"<85y0na4dj1.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"qZZIi-iJIBAhlHiLjhQS4M2_WU_b_N7viqBAvz4Jb2o_1765376900","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]