{"id":25425,"url":"https://patchwork.libcamera.org/api/patches/25425/?format=json","web_url":"https://patchwork.libcamera.org/patch/25425/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251210005354.44726-9-bryan.odonoghue@linaro.org>","date":"2025-12-10T00:53:36","name":"[v7,08/26] libcamera: shaders: Add support for black level compensation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1e4d840dcfd8f9799dd645f70a5f669ba26f823b","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25425/mbox/","series":[{"id":5645,"url":"https://patchwork.libcamera.org/api/series/5645/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5645","date":"2025-12-10T00:53:28","name":"Add GLES 2.0 GPUISP to libcamera","version":7,"mbox":"https://patchwork.libcamera.org/series/5645/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25425/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25425/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB43FC3257\n\tfor ;\n\tWed, 10 Dec 2025 00:54:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A67361455;\n\tWed, 10 Dec 2025 01:54:41 +0100 (CET)","from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com\n\t[IPv6:2607:f8b0:4864:20::42d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5059D61453\n\tfor ;\n\tWed, 10 Dec 2025 01:54:39 +0100 (CET)","by mail-pf1-x42d.google.com with SMTP id\n\td2e1a72fcca58-7acd9a03ba9so6766826b3a.1\n\tfor ;\n\tTue, 09 Dec 2025 16:54:39 -0800 (PST)","from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t41be03b00d2f7-bf6875cc8eesm16057762a12.16.2025.12.09.16.54.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:54:37 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ZbWK0lwk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765328078; x=1765932878;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=;\n\tb=ZbWK0lwkizK94sUUasc4goydeS7Ke1V2j/3/T6t8HjjRekND5blYkHv2CM1BMxr0uD\n\tNCmNCjzPaSEPOjimpLUPOiOgmwhlf9t5Y7BBSpuZhpvTsu1uEyZS02oogMuSalY2Vz7d\n\tCvRMHTnVWQrk0cdiHPwXTL7CiGOcs0ad3B4Saq6m/bnQGiTP3EJbHgXg9kZSH7FNN5bw\n\thxJEGE0NMseXVBxxiLzqzBhwv4CKJJqcK7PlRMKrnzlHTzIBrv1Cuj4ZnFFpStFzqZML\n\t1WZgzWqm44ZjZrBFk91JeRGeTf244AtRWi4cGc8M6NPLRli2LlGSK9ZgQ5RRv5HTNoH4\n\tQyDQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765328078; x=1765932878;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=5qjoeAop1GzrvnIG7vvLvJkbwSmYKtE+YPe2MFgINpo=;\n\tb=vB/jh4r+3GbCyS/sDXKFnWwEWKsIQu4iZeuAKgFXj+N52Wh7j4sJOIsDMOpLU3vdwt\n\t7FZ9Ru0xsI7ZHXWHy434yU28Bfc1wALqUG7gT+J7XbrFjJqmL3LgMplqXMHHYbxeVFpi\n\tS1jFKpdaUcqJfXUS3V1yBbvIPhNH+ZjVJAYH1tSZSaxVcz1khI15qDwQJ/XYcrovJPmy\n\tST3LqeXOXsD8tChAkSpPFca6fm0QQtpeYWXIRirxiKXkoXVDdqipVWJGjlaJG0fWxTwt\n\tKAMvUSqKyBHXJdUzQlqGORNvXhm5tEj/ojZU7sbMistuhKQQ/w5p3SmTQzXTBm9MSQPi\n\to5Kw==","X-Gm-Message-State":"AOJu0YwSBWf2U/4Wuypq0w+u8XW5LvyBfb3A6jV+7MAgu0lBSzDpjeHs\n\tUP00JkQgPCzsbs1x2wlu0tI3XvPV1z2m7901nyERo/klSXqJW+Oaz5tUgogHRgW3/x9eyKDuBbS\n\tD5RlA","X-Gm-Gg":"ASbGncskO9wFVvaK/X10otKg6p/NvzGQvPeQZKq7dpUxImvSmCYu6zCrrTvHjnqh0NA\n\tc9OVkk7AmcTvsUEvA6qob4SImxO90H/EEwvHh5hx1rDuYUJ2f1G1Tql1D5qnqS9b/Wj6LLndIrs\n\tePG+OGv40gVNVL1P/6oM3zuW1325hcbUOSJVqp+EVqKj9cgAe7bmDm4jLDYT5MCn6H6rZ4eq3P3\n\tp6KsxwTxKfPi1EF5z4Q9aI/jhIrnWgCAwJ7YSKhlOzXAgrOD0kf9ii5kQtbqCgN9Gvg/yG1rpIk\n\t5U4mTWXk0hf8eooqkgGciqMD69GD/sf/ebUbJPNfsfNriZZC7KlAo58jm676ecnHAnEJ7QBZjG1\n\tGMjN7813wkgYcvM5RULJFII0M1wQocIKrwWPyZPCQkaCBOr619tyOqGMj3FBEl02syXJQtuAs7O\n\tPuBTTgHFtx4xMc/+8iOgD17BOzbAl6INJy+++gjc+ETPET+I6q4TlrzWAF8yblmYxC+WZY0vCrM\n\tIs=","X-Google-Smtp-Source":"AGHT+IEFGiHk62rOdCVtTC/0xCtxKO5OXIimajmsyfRCaStOd+1pCyujilFuNl+KrJeD+jA5U2gGrg==","X-Received":"by 2002:a05:6a20:72a7:b0:366:14af:9bbb with SMTP id\n\tadf61e73a8af0-366e35c7511mr610211637.69.1765328077657; \n\tTue, 09 Dec 2025 16:54:37 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tMilan Zamazal ","Subject":"[PATCH v7 08/26] libcamera: shaders: Add support for black level\n\tcompensation","Date":"Wed, 10 Dec 2025 00:53:36 +0000","Message-ID":"<20251210005354.44726-9-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251210005354.44726-1-bryan.odonoghue@linaro.org>","References":"<20251210005354.44726-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add the ability to apply a int blacklevel gain against the demosaiced data\nprior to application of colour correction data.\n\nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/shaders/bayer_1x_packed.frag | 3 +++\n src/libcamera/shaders/bayer_unpacked.frag | 3 +++\n 2 files changed, 6 insertions(+)","diff":"diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex db8c2a0b3..7036fe278 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -66,6 +66,7 @@ uniform vec2 tex_bayer_first_red;\n \n uniform sampler2D tex_y;\n uniform mat3 ccm;\n+uniform vec3 blacklevel;\n \n void main(void)\n {\n@@ -213,6 +214,8 @@ void main(void)\n \t\t\tvec3(patterns.y, C, patterns.x) :\n \t\t\tvec3(patterns.wz, C));\n \n+\trgb = rgb - blacklevel;\n+\n \t/*\n \t * CCM is a 3x3 in the format\n \t *\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 06d80f3dd..f0d8cd1e2 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -25,6 +25,7 @@ varying vec4 center;\n varying vec4 yCoord;\n varying vec4 xCoord;\n uniform mat3 ccm;\n+uniform vec3 blacklevel;\n \n void main(void) {\n vec3 rgb;\n@@ -108,6 +109,8 @@ void main(void) {\n vec3(PATTERN.w, C, PATTERN.z) :\n vec3(PATTERN.yx, C));\n \n+ rgb = rgb - blacklevel;\n+\n /*\n * CCM is a 3x3 in the format\n *\n","prefixes":["v7","08/26"]}