{"id":25416,"url":"https://patchwork.libcamera.org/api/patches/25416/?format=json","web_url":"https://patchwork.libcamera.org/patch/25416/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251210003139.43606-21-bryan.odonoghue@linaro.org>","date":"2025-12-10T00:31:37","name":"[v4,20/20] libcamera: software_isp: lut: Make contrast available in debayer params","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"83993195e06b0449ff8570fc403c27b5cf696655","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25416/mbox/","series":[{"id":5644,"url":"https://patchwork.libcamera.org/api/series/5644/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5644","date":"2025-12-10T00:31:17","name":"GPUISP precursor series","version":4,"mbox":"https://patchwork.libcamera.org/series/5644/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25416/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25416/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E260BD1F1\n\tfor ;\n\tWed, 10 Dec 2025 00:32:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 53D6C61485;\n\tWed, 10 Dec 2025 01:32:50 +0100 (CET)","from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com\n\t[IPv6:2607:f8b0:4864:20::102d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9A57060C8A\n\tfor ;\n\tWed, 10 Dec 2025 01:32:48 +0100 (CET)","by mail-pj1-x102d.google.com with SMTP id\n\t98e67ed59e1d1-343dd5aa6e7so6873330a91.0\n\tfor ;\n\tTue, 09 Dec 2025 16:32:48 -0800 (PST)","from inspiron14p-linux (p96936b06.osaknt01.ap.so-net.ne.jp.\n\t[150.147.107.6]) by smtp.gmail.com with ESMTPSA id\n\t98e67ed59e1d1-34a70427ea6sm566580a91.3.2025.12.09.16.32.44\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 09 Dec 2025 16:32:46 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"ewZfHASo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1765326767; x=1765931567;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=M/bJYdbFWv8CRdhs1pvqnvqUFQsR3FnLTvxzEDq9+0g=;\n\tb=ewZfHASoVorfMRWVbUU2ykMhssJKaLyixGPuOtKlaBV4j23Swwy/om5dowZgNLUuMT\n\txTciU7tAm6OBStGlt0o+WLx7ZNk9WE+YMHItQPIlwN5SvK5QbdPWwcbRZ+jmqDiojxyL\n\tVTMuxnjEF9uAG5faYqehnCiX/+NGTdjMJRIzPh/WS/CQJOR8pqN80xLr4whL5KoUzDDW\n\tqIFN9MVwWeXmb8Kci7gyVX28fgcAt5mH9rQMv4XVDymuMeCN3h+dRd45OYr/xjpS69r6\n\tlII6pYxL5ODtRxFFF3I7WofQOrTgEz4KPfCmliiracCgOTxSPqPyQPw7+k5a7dXslZoT\n\tK7Nw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1765326767; x=1765931567;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=M/bJYdbFWv8CRdhs1pvqnvqUFQsR3FnLTvxzEDq9+0g=;\n\tb=QRD4BUNjQGse25tU0pI30drjv75GfY5a+rwUH5i0T8q0UCIXXlPgGzNhOiX1ZuLqji\n\tY6pyrXlMPmeQRLfQaCh00k7JXS89OfrlyQxAJ2GPX5kOxF4SW0yj6/SXrnR8NNbr61Wd\n\tHg3fh0wAEPAAg8M3XIYoipyXru/afqgxrFYtqUGsusCTa1Ofn7ITp4FY+ROtbvfuLvRX\n\tFm4YtzafSrff0UDD+B7wKw4ObCDh4EB23mknZeY4dpXTG0X4qr3Pd1vGXK5qkTeSG8Sm\n\tXsUB7D/fkfdntbNBgwnbmblblE29cBktvOd3MGGHWBUG8ieLtrQUWfCEEpyx70AjlyAe\n\tFnEQ==","X-Gm-Message-State":"AOJu0YypZshxfIfX1Cm7AmACGPEjWuckjKoM+7ywkdzNp/U8OuSXYQjH\n\t0iIc1tLKjAEQLgDMoYBZsAuzaCqgp8v7XL9JPem39CVdI56g3Vz6k7cGRrQvQoV9Hm7e4wDt5nz\n\tLLPaA","X-Gm-Gg":"AY/fxX4CZ+LttOv+rp9zqf6SwMwcTyCqalC8KEPiPrBEptf0ukIUQuaHOIAcXX7kpHu\n\tew92N8iAuZqNFh8a9kNJaHl3f9c1mk/+8BHgxLsGv7jIdiTfhab3fJKjw1jdMc90VntZi7+NrvQ\n\tIjC35lamp9Sa2zVuurvewLyrIsvOollpWNHQoYM58YRvKv2d9dAEtKiY8Qpn7iU168PTu+Fjq84\n\tL9XagQWi9hjmRtWfhTE34vy1kDDKou01ARDPOpPd0ge37Vzel6ZhDSfWDdkX+K8f6x4i/fNvp4i\n\tmjPCtQITcGx54GIU1FbePiF13a0F9WdRnGuH5IXTGQgTaTz4KiwovM0yicymjwiQ5KA0dpyI2gy\n\tFWtFqg7EjFP8gHnHJDMrG/cZj09g7sX3O4edWIlllQn2+kNy9jDy1REXS+dI228Lq0XqReT5Taf\n\t7OcUfqipJaAlBgTDLRZ3FDMafay18wy+kS2TRjPI0SZRXl7KN+GkhDK3HQ+MTrAMPEx2tghxTGG\n\tBQ=","X-Google-Smtp-Source":"AGHT+IFWsnz4N2kI1Awyitx42U2EQa70WHGGuE2zsxjB9mH/K0Y5pq6Amyn1M/4Io3aRGYsYSfHPKQ==","X-Received":"by 2002:a17:90b:3902:b0:329:ca48:7090 with SMTP id\n\t98e67ed59e1d1-34a72896510mr519811a91.37.1765326766929; \n\tTue, 09 Dec 2025 16:32:46 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tMilan Zamazal ,\n\tKieran Bingham ","Subject":"[PATCH v4 20/20] libcamera: software_isp: lut: Make contrast\n\tavailable in debayer params","Date":"Wed, 10 Dec 2025 00:31:37 +0000","Message-ID":"<20251210003139.43606-21-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251210003139.43606-1-bryan.odonoghue@linaro.org>","References":"<20251210003139.43606-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Provide the contrast used in IPA to Bayer parameters. Similar to the\ncalculated Gamma value we will pass this value into the debayer fragment\nshader for further consumption.\n\nReviewed-by: Milan Zamazal \nReviewed-by: Kieran Bingham \nSigned-off-by: Bryan O'Donoghue \n---\n include/libcamera/internal/software_isp/debayer_params.h | 1 +\n src/ipa/simple/algorithms/lut.cpp | 1 +\n src/libcamera/software_isp/debayer.cpp | 5 +++++\n 3 files changed, 7 insertions(+)","diff":"diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\nindex d5dad1a98..8033f7d5b 100644\n--- a/include/libcamera/internal/software_isp/debayer_params.h\n+++ b/include/libcamera/internal/software_isp/debayer_params.h\n@@ -59,6 +59,7 @@ struct DebayerParams {\n \tMatrix ccm;\n \tRGB blackLevel;\n \tfloat gamma;\n+\tfloat contrast;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\nindex ea5a86b20..9aaab54f1 100644\n--- a/src/ipa/simple/algorithms/lut.cpp\n+++ b/src/ipa/simple/algorithms/lut.cpp\n@@ -149,6 +149,7 @@ void Lut::prepare(IPAContext &context,\n \t}\n \n \tparams->gamma = context.configuration.gamma;\n+\tparams->contrast = context.activeState.gamma.contrast;\n }\n \n void Lut::process([[maybe_unused]] IPAContext &context,\ndiff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\nindex 8e7eac793..63a61daf9 100644\n--- a/src/libcamera/software_isp/debayer.cpp\n+++ b/src/libcamera/software_isp/debayer.cpp\n@@ -115,6 +115,11 @@ namespace libcamera {\n * \\brief Gamma value for the GPUISP\n */\n \n+/**\n+ * \\var DebayerParams::contrast\n+ * \\brief Contrast value for GPUISP\n+ */\n+\n /**\n * \\class Debayer\n * \\brief Base debayering class\n","prefixes":["v4","20/20"]}