[{"id":37303,"web_url":"https://patchwork.libcamera.org/comment/37303/","msgid":"<2awxdoksbkbnsoqhf7tljzmfoenmlztsu5i4bagsz3ovswqvib@ply3slrjgyfk>","date":"2025-12-11T12:00:35","subject":"Re: [RFC PATCH v2 2/3] libcamera: device_enumerator_udev: Disable\n\tcopy/move","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Mon, Dec 08, 2025 at 12:00:34PM +0100, Barnabás Pőcze wrote:\n> The default implementations generated by the compiler are not appropriate.\n> So disable them.\n>\n> Signed-off-by: Barnabás Pőcze \n> Reviewed-by: Kieran Bingham \n> ---\n> include/libcamera/internal/device_enumerator_udev.h | 4 ++++\n> 1 file changed, 4 insertions(+)\n>\n> diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h\n> index fb0005921a..c2f7154b6b 100644\n> --- a/include/libcamera/internal/device_enumerator_udev.h\n> +++ b/include/libcamera/internal/device_enumerator_udev.h\n\nSame comment, probably the sysfs backend needs the same.\n\nAnyway, this and the previous patch are good on their own\nReviewed-by: Jacopo Mondi \n\n> @@ -14,6 +14,8 @@\n> #include \n> #include \n>\n> +#include \n> +\n> #include \"libcamera/internal/device_enumerator.h\"\n>\n> struct udev;\n> @@ -54,6 +56,8 @@ private:\n> \t\tDependencyMap deps_;\n> \t};\n>\n> +\tLIBCAMERA_DISABLE_COPY_AND_MOVE(DeviceEnumeratorUdev)\n> +\n> \tint addUdevDevice(struct udev_device *dev);\n> \tint populateMediaDevice(MediaDevice *media, DependencyMap *deps);\n> \tstd::string lookupDeviceNode(dev_t devnum);\n> --\n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77DF8C3257\n\tfor ;\n\tThu, 11 Dec 2025 12:00:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 85A56615D5;\n\tThu, 11 Dec 2025 13:00:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 68A06609D8\n\tfor ;\n\tThu, 11 Dec 2025 13:00:38 +0100 (CET)","from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 069D0667;\n\tThu, 11 Dec 2025 13:00:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CwA66LyO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765454436;\n\tbh=8Yzs4JbPHoNEngRgdTao3llzLZq0oTgIQDYqk9A0B7I=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CwA66LyOmlU1W7z0Qi6N+AbvDOoGvRg4WeRKK9paTJejh7GdXDBvfgXcqCs+W8a57\n\tmaOm1ywUSW4uF32VcvbaRqQMFrUUj5NcyA/3q2yF0HqqwaUOJBLlAL6YVyZXu8qSr/\n\tBHNPqtJF6DsAymFgYZo2k9p+bY2+vbEUmMCRJRc8=","Date":"Thu, 11 Dec 2025 13:00:35 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org, \n\tKieran Bingham ","Subject":"Re: [RFC PATCH v2 2/3] libcamera: device_enumerator_udev: Disable\n\tcopy/move","Message-ID":"<2awxdoksbkbnsoqhf7tljzmfoenmlztsu5i4bagsz3ovswqvib@ply3slrjgyfk>","References":"<20251208110035.248881-1-barnabas.pocze@ideasonboard.com>\n\t<20251208110035.248881-2-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20251208110035.248881-2-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]