[{"id":37302,"web_url":"https://patchwork.libcamera.org/comment/37302/","msgid":"","date":"2025-12-11T11:58:44","subject":"Re: [RFC PATCH v2 1/3] libcamera: device_enumerator_udev: Add\n\t`override`","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Barnabás\n\nOn Mon, Dec 08, 2025 at 12:00:33PM +0100, Barnabás Pőcze wrote:\n> Mark the overridden virtual functions as \"override\".\n>\n> Signed-off-by: Barnabás Pőcze \n> ---\n> include/libcamera/internal/device_enumerator_udev.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h\n> index 1378c1906d..fb0005921a 100644\n> --- a/include/libcamera/internal/device_enumerator_udev.h\n> +++ b/include/libcamera/internal/device_enumerator_udev.h\n\nDoes device_enumerator_sysfs.h deserve the same ?\n\n> @@ -32,8 +32,8 @@ public:\n> \tDeviceEnumeratorUdev();\n> \t~DeviceEnumeratorUdev();\n>\n> -\tint init();\n> -\tint enumerate();\n> +\tint init() override;\n> +\tint enumerate() override;\n>\n> private:\n> \tusing DependencyMap = std::map>;\n> --\n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 88AD6BD1F1\n\tfor ;\n\tThu, 11 Dec 2025 11:58:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BFED0615D2;\n\tThu, 11 Dec 2025 12:58:48 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96A32609D8\n\tfor ;\n\tThu, 11 Dec 2025 12:58:46 +0100 (CET)","from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 74807667;\n\tThu, 11 Dec 2025 12:58:44 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BQzfLnsL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765454324;\n\tbh=F2JcSz6DKscLmIUF+tDL/TS8LFBNgNtSw/TN50Fpv48=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=BQzfLnsLWU1inVrNJFi3Y5j6x0+eAu5Wwgp4sOh76jHMIVMjeyfBERI+RrDYUWjgI\n\trtwJjbolSpEyFxzH92Me2sA3Gz5qtnB1vXnu9JLydXJtazUBEDVcpDxg9RmyZRMysM\n\thfGORbU+GBQKV9UF9HeU+WkbpHYW1CPlARQACVXc=","Date":"Thu, 11 Dec 2025 12:58:44 +0100","From":"Jacopo Mondi ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [RFC PATCH v2 1/3] libcamera: device_enumerator_udev: Add\n\t`override`","Message-ID":"","References":"<20251208110035.248881-1-barnabas.pocze@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20251208110035.248881-1-barnabas.pocze@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37305,"web_url":"https://patchwork.libcamera.org/comment/37305/","msgid":"<1ed75c6b-48e0-4448-b1d8-3c58b62b3287@ideasonboard.com>","date":"2025-12-11T12:07:25","subject":"Re: [RFC PATCH v2 1/3] libcamera: device_enumerator_udev: Add\n\t`override`","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 12. 11. 12:58 keltezéssel, Jacopo Mondi írta:\n> Hi Barnabás\n> \n> On Mon, Dec 08, 2025 at 12:00:33PM +0100, Barnabás Pőcze wrote:\n>> Mark the overridden virtual functions as \"override\".\n>>\n>> Signed-off-by: Barnabás Pőcze \n>> ---\n>> include/libcamera/internal/device_enumerator_udev.h | 4 ++--\n>> 1 file changed, 2 insertions(+), 2 deletions(-)\n>>\n>> diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h\n>> index 1378c1906d..fb0005921a 100644\n>> --- a/include/libcamera/internal/device_enumerator_udev.h\n>> +++ b/include/libcamera/internal/device_enumerator_udev.h\n> \n> Does device_enumerator_sysfs.h deserve the same ?\n\nYes But maybe I should drop this change and wait until clang-tidy is enabled\nand does the `modernize-use-override` check, which would warn about these cases.\n\n\n> \n>> @@ -32,8 +32,8 @@ public:\n>> \tDeviceEnumeratorUdev();\n>> \t~DeviceEnumeratorUdev();\n>>\n>> -\tint init();\n>> -\tint enumerate();\n>> +\tint init() override;\n>> +\tint enumerate() override;\n>>\n>> private:\n>> \tusing DependencyMap = std::map>;\n>> --\n>> 2.52.0\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 893FEBD1F1\n\tfor ;\n\tThu, 11 Dec 2025 12:07:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8105615FF;\n\tThu, 11 Dec 2025 13:07:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CAEA3615D2\n\tfor ;\n\tThu, 11 Dec 2025 13:07:28 +0100 (CET)","from [192.168.33.38] (185.221.143.114.nat.pool.zt.hu\n\t[185.221.143.114])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C13AF15D2;\n\tThu, 11 Dec 2025 13:07:26 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jgYBx7i6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765454846;\n\tbh=7JJssYDTQzzue3HC/52wpoi1oVJSAPjBTgh4/K4ela4=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=jgYBx7i6iPmTzJuuI9uTHz/Xq18Jm9O5tT5bEFYow4/npg7uXHsT7LGPXA+fUH0lT\n\tr1DMmS9pnzanPJHu+6Y3gUcByRmbwrmNoECacJRnlg2UZjl3BKwLGrRmIXFVGVdsW2\n\toyAla9/Achy6YnQzcMJ/8CjNVvLPNixUd9NbkD1A=","Message-ID":"<1ed75c6b-48e0-4448-b1d8-3c58b62b3287@ideasonboard.com>","Date":"Thu, 11 Dec 2025 13:07:25 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [RFC PATCH v2 1/3] libcamera: device_enumerator_udev: Add\n\t`override`","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20251208110035.248881-1-barnabas.pocze@ideasonboard.com>\n\t","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]