[{"id":37314,"web_url":"https://patchwork.libcamera.org/comment/37314/","msgid":"","date":"2025-12-11T15:53:47","subject":"Re: [PATCH v4 4/7] ipa: rkisp1: algorithms: dpf: Simplify YAML key\n\tnames","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Rui\n\nOn Sun, Dec 07, 2025 at 07:48:05PM -0500, Rui Wang wrote:\n> Rename DPF tuning file keys to shorter, more concise names:\n> - DomainFilter -> filter\n> - NoiseLevelFunction -> nll\n> - FilterStrength -> strength\n>\n> This improves readability and reduces verbosity in tuning files\n> while maintaining the same functionality. Error messages are\n> updated accordingly to reflect the new key names.\n>\n> Signed-off-by: Rui Wang \n\nNice\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> changelog:\n> - Move V3's Yaml rename Implementation into one sperate patch for highlight\n>\n> src/ipa/rkisp1/algorithms/dpf.cpp | 14 +++++++-------\n> 1 file changed, 7 insertions(+), 7 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/dpf.cpp b/src/ipa/rkisp1/algorithms/dpf.cpp\n> index edb4c2bf..dea04cc3 100644\n> --- a/src/ipa/rkisp1/algorithms/dpf.cpp\n> +++ b/src/ipa/rkisp1/algorithms/dpf.cpp\n> @@ -123,7 +123,7 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n> \t * The domain kernel is configured with a 9x9 kernel for the green\n> \t * pixels, and a 13x9 or 9x9 kernel for red and blue pixels.\n> \t */\n> -\tconst YamlObject &dFObject = tuningData[\"DomainFilter\"];\n> +\tconst YamlObject &dFObject = tuningData[\"filter\"];\n>\n> \t/*\n> \t * For the green component, we have the 9x9 kernel specified\n> @@ -145,7 +145,7 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n> \tvalues = dFObject[\"g\"].getList().value_or(std::vector{});\n> \tif (values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS) {\n> \t\tLOG(RkISP1Dpf, Error)\n> -\t\t\t<< \"Invalid 'DomainFilter:g': expected \"\n> +\t\t\t<< \"Invalid 'filter:g': expected \"\n> \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS\n> \t\t\t<< \" elements, got \" << values.size();\n> \t\treturn false;\n> @@ -182,7 +182,7 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n> \tif (values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS &&\n> \t values.size() != RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS - 1) {\n> \t\tLOG(RkISP1Dpf, Error)\n> -\t\t\t<< \"Invalid 'DomainFilter:rb': expected \"\n> +\t\t\t<< \"Invalid 'filter:rb': expected \"\n> \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS - 1\n> \t\t\t<< \" or \" << RKISP1_CIF_ISP_DPF_MAX_SPATIAL_COEFFS\n> \t\t\t<< \" elements, got \" << values.size();\n> @@ -204,13 +204,13 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n> \t * which stores a piecewise linear function that characterizes the\n> \t * sensor noise profile as a noise level function curve (NLF).\n> \t */\n> -\tconst YamlObject &rFObject = tuningData[\"NoiseLevelFunction\"];\n> +\tconst YamlObject &rFObject = tuningData[\"nll\"];\n>\n> \tstd::vector nllValues;\n> \tnllValues = rFObject[\"coeff\"].getList().value_or(std::vector{});\n> \tif (nllValues.size() != RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS) {\n> \t\tLOG(RkISP1Dpf, Error)\n> -\t\t\t<< \"Invalid 'RangeFilter:coeff': expected \"\n> +\t\t\t<< \"Invalid 'nll:coeff': expected \"\n> \t\t\t<< RKISP1_CIF_ISP_DPF_MAX_NLF_COEFFS\n> \t\t\t<< \" elements, got \" << nllValues.size();\n> \t\treturn false;\n> @@ -226,13 +226,13 @@ bool Dpf::parseSingleConfig(const YamlObject &tuningData,\n> \t\tconfig.nll.scale_mode = RKISP1_CIF_ISP_NLL_SCALE_LOGARITHMIC;\n> \t} else {\n> \t\tLOG(RkISP1Dpf, Error)\n> -\t\t\t<< \"Invalid 'RangeFilter:scale-mode': expected \"\n> +\t\t\t<< \"Invalid 'nll:scale-mode': expected \"\n> \t\t\t<< \"'linear' or 'logarithmic' value, got \"\n> \t\t\t<< scaleMode;\n> \t\treturn false;\n> \t}\n>\n> -\tconst YamlObject &fSObject = tuningData[\"FilterStrength\"];\n> +\tconst YamlObject &fSObject = tuningData[\"strength\"];\n>\n> \tstrengthConfig.r = fSObject[\"r\"].get().value_or(64);\n> \tstrengthConfig.g = fSObject[\"g\"].get().value_or(64);\n> --\n> 2.43.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C6B5BD1F1\n\tfor ;\n\tThu, 11 Dec 2025 15:53:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D0ADD61612;\n\tThu, 11 Dec 2025 16:53:51 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 33FA161603\n\tfor ;\n\tThu, 11 Dec 2025 16:53:50 +0100 (CET)","from ideasonboard.com (93-46-82-201.ip106.fastwebnet.it\n\t[93.46.82.201])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 0E3E9667;\n\tThu, 11 Dec 2025 16:53:48 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H7NfvIB8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765468428;\n\tbh=f1csI4B7aQVNjYQ9Cah36F02GNqWmn2NR/aVrwKmq+Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=H7NfvIB8AArBizmlinlKqfZQke0/Ixkqvh+nE9yxiUzOvtA/jKwxW0Q12HAENU260\n\tXD/rosm6PRKDke7SVB7DPGw/mJlqA/qzNEVUb5AP9U3WIeAySQ6nGoJhiQB9ns6bFA\n\t798HljB2S+n0gdEXPsVYpF2p/RufbiRXhHNys8JE=","Date":"Thu, 11 Dec 2025 16:53:47 +0100","From":"Jacopo Mondi ","To":"Rui Wang ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v4 4/7] ipa: rkisp1: algorithms: dpf: Simplify YAML key\n\tnames","Message-ID":"","References":"<20251208004808.1274417-1-rui.wang@ideasonboard.com>\n\t<20251208004808.1274417-5-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20251208004808.1274417-5-rui.wang@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]