[{"id":37222,"web_url":"https://patchwork.libcamera.org/comment/37222/","msgid":"","date":"2025-12-08T09:36:38","subject":"Re: [PATCH 6/7] libcamera: mali-c55: Fix sensor size computation","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 12. 05. 15:52 keltezéssel, Jacopo Mondi írta:\n> The sensor size computation routine doesn't work well. Even if a\n> more appriate size for a sensor is available, the largest one is\n \nappropriate\n\n\n> always selected.\n\n\"The last size in the list is always selected unconditionally because\nthe current best distance is not updated properly during the search.\"\n\nSomething like the above would be a bit clearer to me.\n\n\n> \n> Fix the size computation procedure which has an inverted assignment.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 46ef5e7735a30a0d4ae9bb6f8d671bbd2dff3f51..a0a880f26281e5cd9ec176153970a2dd1d230496 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -666,7 +666,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n> \t\t\t\tstd::abs(static_cast(minSensorSize.height) -\n> \t\t\t\t\t static_cast(size.height));\n> \t\tif (dist < distance) {\n> -\t\t\tdist = distance;\n> +\t\t\tdistance = dist;\n> \t\t\tbestSize = size;\n> \t\t}\n> \t}\n> \n> --\n> 2.51.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5354BDDFC\n\tfor ;\n\tMon, 8 Dec 2025 09:36:45 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94DEB613F8;\n\tMon, 8 Dec 2025 10:36:44 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 56F8760C8A\n\tfor ;\n\tMon, 8 Dec 2025 10:36:42 +0100 (CET)","from [192.168.33.35] (185.221.142.68.nat.pool.zt.hu\n\t[185.221.142.68])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF0F1316;\n\tMon, 8 Dec 2025 10:34:23 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BVZU5rqe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765186464;\n\tbh=wACP3PKHSWJUkN2TkG3fw0YpjNNyZm/44VOQTynGH2M=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=BVZU5rqe3L7cRQdCcgbkuVCafUhq6sebjFetcJZUkLiEVo4C/3zLfUjNb9weCfSIN\n\t3NyFaMBd4eHdR0pDqjhfjp1mkhuY+0Q2ttSZHyaJZW/zJlQjPNIs14uMZB/vMGoQgB\n\toL7Fff7vBHIGKrM0Zj5KAlBx5vNLpKGg3pdoL9VE=","Message-ID":"","Date":"Mon, 8 Dec 2025 10:36:38 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 6/7] libcamera: mali-c55: Fix sensor size computation","To":"Jacopo Mondi ,\n\tDaniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251205-mali-cru-v1-0-d81bb5ffe73a@ideasonboard.com>\n\t\n\t<20251205-mali-cru-v1-6-d81bb5ffe73a@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251205-mali-cru-v1-6-d81bb5ffe73a@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37228,"web_url":"https://patchwork.libcamera.org/comment/37228/","msgid":"","date":"2025-12-09T11:44:04","subject":"Re: [PATCH 6/7] libcamera: mali-c55: Fix sensor size computation","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Jacopo\n\nOn 05/12/2025 14:52, Jacopo Mondi wrote:\n> The sensor size computation routine doesn't work well. Even if a\n> more appriate size for a sensor is available, the largest one is\n> always selected.\n> \n> Fix the size computation procedure which has an inverted assignment.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n\nReviewed-and-Tested-by: Daniel Scally \n\n> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> index 46ef5e7735a30a0d4ae9bb6f8d671bbd2dff3f51..a0a880f26281e5cd9ec176153970a2dd1d230496 100644\n> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n> @@ -666,7 +666,7 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()\n> \t\t\t\tstd::abs(static_cast(minSensorSize.height) -\n> \t\t\t\t\t static_cast(size.height));\n> \t\tif (dist < distance) {\n> -\t\t\tdist = distance;\n> +\t\t\tdistance = dist;\n> \t\t\tbestSize = size;\n> \t\t}\n> \t}\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E1465C3257\n\tfor ;\n\tTue, 9 Dec 2025 11:44:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 033ED613FC;\n\tTue, 9 Dec 2025 12:44:10 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 96028606D5\n\tfor ;\n\tTue, 9 Dec 2025 12:44:08 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7368C63D;\n\tTue, 9 Dec 2025 12:44:07 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oIKTJxW/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765280647;\n\tbh=n6JAyCKrjjxL3n7jzq0yCadMrgkau9h6DWfqz2+ZtOk=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=oIKTJxW/hkCOAezn+oRdVwx13TfVPsdBLiP9CC2jXbjd/+u5klHUjijsTAjwAkZrA\n\tZ/CUHJb1AspDBhJyg81LqDbJkVUzSotiTHNjJ9gma4GW6FzGPNFVV558X8HUDWDDzt\n\tWQZPVucl5V9IwNEQK2LOH8BuyquhrI/X7VA9FQEc=","Message-ID":"","Date":"Tue, 9 Dec 2025 11:44:04 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 6/7] libcamera: mali-c55: Fix sensor size computation","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251205-mali-cru-v1-0-d81bb5ffe73a@ideasonboard.com>\n\t<20251205-mali-cru-v1-6-d81bb5ffe73a@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","In-Reply-To":"<20251205-mali-cru-v1-6-d81bb5ffe73a@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]