{"id":25355,"url":"https://patchwork.libcamera.org/api/patches/25355/?format=json","web_url":"https://patchwork.libcamera.org/patch/25355/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251204164634.82839-1-mzamazal@redhat.com>","date":"2025-12-04T16:46:34","name":"libcamera: simple: Move colour space logging after adjustment","commit_ref":"0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d","pull_url":null,"state":"accepted","archived":false,"hash":"70d2c65eeabf15a0978320845f8803d5dcaaf847","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25355/mbox/","series":[{"id":5636,"url":"https://patchwork.libcamera.org/api/series/5636/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5636","date":"2025-12-04T16:46:34","name":"libcamera: simple: Move colour space logging after adjustment","version":1,"mbox":"https://patchwork.libcamera.org/series/5636/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25355/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25355/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A317DBD80A\n\tfor ;\n\tThu, 4 Dec 2025 16:46:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CEF4B61105;\n\tThu, 4 Dec 2025 17:46:55 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9BD62609E0\n\tfor ;\n\tThu, 4 Dec 2025 17:46:53 +0100 (CET)","from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-595-Re2zo2iuNzG7AvEe8YqZNw-1;\n\tThu, 04 Dec 2025 11:46:49 -0500","from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id AC1851956054; Thu, 4 Dec 2025 16:46:47 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.44.32.71])\n\tby mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id C84C13011A3E; Thu, 4 Dec 2025 16:46:44 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Iu6P6KuK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1764866812;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=zRNPIyymKLSiBsS1o+Iu/SWU0ZSio6QanuZ3gIh97v8=;\n\tb=Iu6P6KuKTwY4y9JqxDMQ26R1I4ZqxEWGknjVskTFPN+3DCoEgnX3XX6PDOXjfauGAlgKoK\n\t6sUic9KCCpqQnoII0Kw0b4lm2lVfvODxsKR/3hdm8CZsKIDrel3lOu/Xu7EZ/RocSZHm0K\n\tHQeJgaIzIj68LDouC4kDx5d/Feltwzo=","X-MC-Unique":"Re2zo2iuNzG7AvEe8YqZNw-1","X-Mimecast-MFC-AGG-ID":"Re2zo2iuNzG7AvEe8YqZNw_1764866808","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , =?utf-8?b?QmFybmFiw6FzIFDFkWN6?=\n\t=?utf-8?q?e?= , Kieran Bingham\n\t, Umang Jain ","Subject":"[PATCH] libcamera: simple: Move colour space logging after\n\tadjustment","Date":"Thu, 4 Dec 2025 17:46:34 +0100","Message-ID":"<20251204164634.82839-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.30.177.4","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"7mcMmhwnOBaqZj2foDBUPSU2pPIcBzXtSL64DZw6Tew_1764866808","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The log message about adjusting an unspecified colour space should log\nthe value after, not before, the adjustment.\n\nFixes: 5a33bc10e9d3bc (\"libcamera: software_isp: Assign colour spaces in configurations\")\nReviewed-by: Barnabás Pőcze \nReviewed-by: Umang Jain \nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex a06a52926..ebbb04fb2 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1249,9 +1249,6 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t\t\tdefault:\n \t\t\t\tcfg.colorSpace = ColorSpace::Raw;\n \t\t\t}\n-\t\t\tLOG(SimplePipeline, Debug)\n-\t\t\t\t<< \"Unspecified color space set to \"\n-\t\t\t\t<< cfg.colorSpace.value().toString();\n \t\t\t/*\n \t\t\t * Adjust the assigned color space to make sure everything is OK.\n \t\t\t * Since this is assigning an unspecified color space rather than\n@@ -1259,6 +1256,9 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t\t\t * to Adjusted.\n \t\t\t */\n \t\t\tcfg.colorSpace->adjust(pixelFormat);\n+\t\t\tLOG(SimplePipeline, Debug)\n+\t\t\t\t<< \"Unspecified color space set to \"\n+\t\t\t\t<< cfg.colorSpace.value().toString();\n \t\t} else {\n \t\t\tif (cfg.colorSpace->adjust(pixelFormat)) {\n \t\t\t\tLOG(SimplePipeline, Debug)\n","prefixes":[]}