{"id":25341,"url":"https://patchwork.libcamera.org/api/patches/25341/?format=json","web_url":"https://patchwork.libcamera.org/patch/25341/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251202-cam-control-override-v3-5-eacab052798d@ideasonboard.com>","date":"2025-12-02T14:49:30","name":"[v3,5/5] libcamera: camera: Ensure a request's controls are valid","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"567b2695553b9739c1b3952c31a25fe89566fda8","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25341/mbox/","series":[{"id":5633,"url":"https://patchwork.libcamera.org/api/series/5633/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5633","date":"2025-12-02T14:49:25","name":"libcamera: ipc: ControlLists without valid idmap break IPC","version":3,"mbox":"https://patchwork.libcamera.org/series/5633/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25341/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25341/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 78F3FC326B\n\tfor ;\n\tTue, 2 Dec 2025 14:49:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 096E760D1F;\n\tTue, 2 Dec 2025 15:49:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D97BE60D0E\n\tfor ;\n\tTue, 2 Dec 2025 15:49:36 +0100 (CET)","from [192.168.1.104] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E5110A06;\n\tTue, 2 Dec 2025 15:47:22 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"k6F7gx+K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764686843;\n\tbh=Fpi3rz7Vx1tuMGiAVwEVqdnb7Z/TYH8Mbn7AHFJLZLU=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=k6F7gx+KD2TACBAXTUgCyHQfEvWgOk0QTVBuuBnJVaEox8T1MRTL/Y1VHdAkrjZhw\n\tkYn6UiMRRO7fGvSw4fexGDPqECPwt00W+BYrxtZUwRVT0L4E1ZRyAXh6BDR72csb1N\n\tEJHXJDgYyjtbM49VhtkOfhIG/Vcxt3iZmqwLu6ik=","From":"Jacopo Mondi ","Date":"Tue, 02 Dec 2025 15:49:30 +0100","Subject":"[PATCH v3 5/5] libcamera: camera: Ensure a request's controls are\n\tvalid","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20251202-cam-control-override-v3-5-eacab052798d@ideasonboard.com>","References":"<20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com>","In-Reply-To":"<20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1209;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=Fpi3rz7Vx1tuMGiAVwEVqdnb7Z/TYH8Mbn7AHFJLZLU=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpLvx+BAv2sTk3WmxNGkxeqqFyAQ0R98wXaJE/y\n\tPT+jUZutUWJAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaS78fgAKCRByNAaPFqFW\n\tPDqYD/0Xi2qGNoZFwgws8zecYAOO9u+lsWC/3ajOlJ4HQNJQLrhHNcP6oIOEq7ftNLJCFPZheAv\n\tCjb2juapIKhaSSXMaMEYt82xRbAtlg78Ro5QWUwq8p0Vw6jWfrrH99Yf28IyH5bfO+kz3G5FL4x\n\tjC8VyK6kVLZBYM38UR8BFs5Iai6Df6CbuBkqw1I/uVZugtm4mzATiUCwQDljK1aoicxTWkDZiMr\n\teL3QE7S1HJgOak3qyMWrm7WTnret/TmlEUtx0YwpskO+HYyutrfoMZ//2CtuHA2KMgOiJq5iaDF\n\tcdSVKjY2YqC5Oy3xCmaxoYFQgpWejCC5rfHTnOliOEShjjb+iUIj0y91cqq/FYqXe49FwbS337/\n\t4qY4SGzPGLMBXX5o1c3yvt6CXDJI9yQ95cIFcRPrX9Jl8dj8E8V0hC7IQlHPL+UZRihVpH8i1un\n\tuOOR+Ehws5PMO1eE5yumjUBK/W3C5I5ha/aZJhi7uIdeMOyT6o35HZxWrtGDi8A7IaeOjQj3arE\n\tooq0sjjl9hkySCHP/MqigZSQeVDz0N35Mco0B4R+HjFm4eXLfvBo7DOimJzb6ARJUQ1lcIggUyt\n\tjB8ei/B7/Y0alk5kAVKLamd1nvj9SR+dz3ewvU6lsrGmnRp84pB4JOkQt0M6Eap/p+Lj4C48asu\n\t11JZyWXXpguZXxQ==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The list of controls part of a Request is initialized with the\nControlInfoMap of the Camera the Request is created from.\n\nApplications can re-assign the controls list in a Request\nwhich could cause issues during serialization.\n\nValidate that the ControlList in a Request is valid when\nthe Request is queued to the Camera by inspecting the\nControlInfoMap pointer.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/camera.cpp | 6 ++++++\n 1 file changed, 6 insertions(+)","diff":"diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex 2e1e146a25b13b94f3a0df5935c0861f78c949ed..93cd4d5f334f982133a12cbc4caec5cdf7bb52c6 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -1345,6 +1345,12 @@ int Camera::queueRequest(Request *request)\n \t\treturn -EINVAL;\n \t}\n \n+\t/* Make sure the Request has a valid control list. */\n+\tif (request->controls().infoMap() != &controls()) {\n+\t\tLOG(Camera, Error) << \"Invalid control list in the Request\";\n+\t\treturn -EINVAL;\n+\t}\n+\n \t/*\n \t * The camera state may change until the end of the function. No locking\n \t * is however needed as PipelineHandler::queueRequest() will handle\n","prefixes":["v3","5/5"]}