[{"id":37374,"web_url":"https://patchwork.libcamera.org/comment/37374/","msgid":"<8e7a6af4-6f7f-4b2a-9715-3b75b2eca76c@ideasonboard.com>","date":"2025-12-15T11:31:33","subject":"Re: [PATCH v3 1/5] libcamera: request: Create control list with\n\tCamera info map","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Morning Jacopo\n\nOn 02/12/2025 14:49, Jacopo Mondi wrote:\n> The control lists associated with a Request is created with the global\n> libcamera::controls::controls id map.\n> \n> This is fine as the idmap/info map used to contruct a ControlList are not\n> used for any control validation purposes by the libcamera code.\n> \n> However creating a ControlList with the camera ControlInfoMap has two\n> advantages:\n> \n> 1) The idmap can be extracted from the info map, but not the other way\n> around\n> 2) The control list is constructed with a valid map of info to the\n> controls it can actually supports, instead of the global map of\n> libcamera controls\n> \n> Initialize the ControlList part of a Request with the Camera control\n> info map, as the association between a Request and a Camera is permanent\n> and valid for the whole lifetime of a Request.\n> \n> Signed-off-by: Jacopo Mondi \n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Paul Elder \n> ---\n\nTurns out I had no idea how ControlLists work, but having finally settled that in my mind I think \nthat this seems like a good idea:\n\nReviewed-by: Daniel Scally \n\n> src/libcamera/request.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\n> index 60565f5984971c7ab34e119a15b8141799f71071..2544a059f6984d930ec909c74e0b621c9fe82726 100644\n> --- a/src/libcamera/request.cpp\n> +++ b/src/libcamera/request.cpp\n> @@ -356,7 +356,7 @@ Request::Request(Camera *camera, uint64_t cookie)\n> \t: Extensible(std::make_unique(camera)),\n> \t cookie_(cookie), status_(RequestPending)\n> {\n> -\tcontrols_ = new ControlList(controls::controls,\n> +\tcontrols_ = new ControlList(camera->controls(),\n> \t\t\t\t camera->_d()->validator());\n> \n> \t/**\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1B5B2C3257\n\tfor ;\n\tMon, 15 Dec 2025 11:31:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65B5B61958;\n\tMon, 15 Dec 2025 12:31:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C83BE615B2\n\tfor ;\n\tMon, 15 Dec 2025 12:31:37 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 48A3AEB4\n\tfor ;\n\tMon, 15 Dec 2025 12:31:32 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jA6AIjwg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1765798292;\n\tbh=ArxV38p4Y+cg93SvxqcPgqgoTMkZNh/2Gd+NAU65eZc=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=jA6AIjwgleWxo6oALPnbXGW5Jm0x+nRXUtBwx3/K5a4Ru73XrpVLE+q3YzKUzn7+X\n\tt+NVkSU5GPtTAoUfAWOevfi/t6DWI+BrA+Kz9h73/UhOPhaDJT9fmSj8xxiEIHVPtb\n\t28cezPjKBE5bzyQ22h0ecTESYd2yWQZCagY6s6zw=","Message-ID":"<8e7a6af4-6f7f-4b2a-9715-3b75b2eca76c@ideasonboard.com>","Date":"Mon, 15 Dec 2025 11:31:33 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 1/5] libcamera: request: Create control list with\n\tCamera info map","To":"libcamera-devel@lists.libcamera.org","References":"<20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com>\n\t<20251202-cam-control-override-v3-1-eacab052798d@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","In-Reply-To":"<20251202-cam-control-override-v3-1-eacab052798d@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]