{"id":25338,"url":"https://patchwork.libcamera.org/api/patches/25338/?format=json","web_url":"https://patchwork.libcamera.org/patch/25338/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251202-cam-control-override-v3-1-eacab052798d@ideasonboard.com>","date":"2025-12-02T14:49:26","name":"[v3,1/5] libcamera: request: Create control list with Camera info map","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"d6d39f0e7bb835bae629d927330237fc4c03b146","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25338/mbox/","series":[{"id":5633,"url":"https://patchwork.libcamera.org/api/series/5633/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5633","date":"2025-12-02T14:49:25","name":"libcamera: ipc: ControlLists without valid idmap break IPC","version":3,"mbox":"https://patchwork.libcamera.org/series/5633/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25338/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25338/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD3C1BD80A\n\tfor ;\n\tTue, 2 Dec 2025 14:49:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D992060D24;\n\tTue, 2 Dec 2025 15:49:38 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66FE960C8A\n\tfor ;\n\tTue, 2 Dec 2025 15:49:36 +0100 (CET)","from [192.168.1.104] (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C97E7110;\n\tTue, 2 Dec 2025 15:47:21 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"H4Yyw5d2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764686842;\n\tbh=IwWrCI6ckKMAC8VXcFGr+hdS1KUDbLOTw8EpSuR3A6I=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=H4Yyw5d2sko12ukc7CXMuXXRuQHQfjL5JHg9h8pcxO9cJ7nLNNKch2wfhAioslFW8\n\tIuxirroQCoLLWWQT67RbE71Iom5gNHyZnlN+ldNK560o0fOeuzx97OU1YIfqcGyzHU\n\tCqJ0/92ddnejEvypeWOAIeR5BUTW+RjPkZ3eL9Cs=","From":"Jacopo Mondi ","Date":"Tue, 02 Dec 2025 15:49:26 +0100","Subject":"[PATCH v3 1/5] libcamera: request: Create control list with Camera\n\tinfo map","MIME-Version":"1.0","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"7bit","Message-Id":"<20251202-cam-control-override-v3-1-eacab052798d@ideasonboard.com>","References":"<20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com>","In-Reply-To":"<20251202-cam-control-override-v3-0-eacab052798d@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi , \n\tKieran Bingham , \n\tPaul Elder ","X-Mailer":"b4 0.14.2","X-Developer-Signature":"v=1; a=openpgp-sha256; l=1617;\n\ti=jacopo.mondi@ideasonboard.com; h=from:subject:message-id;\n\tbh=IwWrCI6ckKMAC8VXcFGr+hdS1KUDbLOTw8EpSuR3A6I=;\n\tb=owEBbQKS/ZANAwAKAXI0Bo8WoVY8AcsmYgBpLvx+WpWPoeeDqm/lEIAWoiN/XTOEdfEK5uCyC\n\tXTrbEbMBe6JAjMEAAEKAB0WIQS1xD1IgJogio9YOMByNAaPFqFWPAUCaS78fgAKCRByNAaPFqFW\n\tPOklD/wOUDCRCzyRxuG2lUyVBfH1wtJdtOr47kgN2t5A+mL8tZi/v+BnOHpVgA8xS3I8lC/srP6\n\tJqIAEQV+GRALnV1Pm6i5EHvaJP3BfJbbTVPtv0H+NXGQ4ZsLBE2MZa2j9z+LDXrTA3kELu8z0ZY\n\teGj3cnuBt3mvXW2TuWh23ocZNsPxjzSO19ofg73wAhHh1G79yMzAMCvsRfDCpsoC0nEuiigyMXI\n\tajbxCbPHgy17fBPf0VCcRq17CelR2tjLVd2IL0yWIO5lXRN8XkpJNm/6lkHpROq+0U0UcXeThXR\n\tb+rqMbII8GYCY8LkgfOlQwvxhFhaOX5943Y+jxyhXppNrdE6niKq6iAvm+yrNI2WKgKSmS7/5A+\n\thhkKtaQuTOujBvcEGQEbuZWIZHQ5uNl71OD+7IuVQmd2UJuSPcypt/301YhtwthA2IVG+se2Sne\n\t70k/Pyvx0Nwyo7m0QzdVXsKa23seZ9yq3+X4KaMB4ZMVOhBEJzwy5UoABQGEJgmeUkc6T5xuT04\n\t/RGiGD/7zEJx4MCRMu7rLebLsr/6EfcYuuzzzSM6YvFDGMmle1m674y8xIwyYeAO+nwW2rHAfxL\n\tD0U9N8MNWOJ82cBgLZm+NGNqKS8D3Bi/Sp9mseJLpnZWZeiySA/CVs9k6cv+COISyHylnaZUpQi\n\th3z2MhishnumtYA==","X-Developer-Key":"i=jacopo.mondi@ideasonboard.com; a=openpgp;\n\tfpr=72392EDC88144A65C701EA9BA5826A2587AD026B","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The control lists associated with a Request is created with the global\nlibcamera::controls::controls id map.\n\nThis is fine as the idmap/info map used to contruct a ControlList are not\nused for any control validation purposes by the libcamera code.\n\nHowever creating a ControlList with the camera ControlInfoMap has two\nadvantages:\n\n1) The idmap can be extracted from the info map, but not the other way\n around\n2) The control list is constructed with a valid map of info to the\n controls it can actually supports, instead of the global map of\n libcamera controls\n\nInitialize the ControlList part of a Request with the Camera control\ninfo map, as the association between a Request and a Camera is permanent\nand valid for the whole lifetime of a Request.\n\nSigned-off-by: Jacopo Mondi \nReviewed-by: Kieran Bingham \nReviewed-by: Paul Elder \n---\n src/libcamera/request.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/request.cpp b/src/libcamera/request.cpp\nindex 60565f5984971c7ab34e119a15b8141799f71071..2544a059f6984d930ec909c74e0b621c9fe82726 100644\n--- a/src/libcamera/request.cpp\n+++ b/src/libcamera/request.cpp\n@@ -356,7 +356,7 @@ Request::Request(Camera *camera, uint64_t cookie)\n \t: Extensible(std::make_unique(camera)),\n \t cookie_(cookie), status_(RequestPending)\n {\n-\tcontrols_ = new ControlList(controls::controls,\n+\tcontrols_ = new ControlList(camera->controls(),\n \t\t\t\t camera->_d()->validator());\n \n \t/**\n","prefixes":["v3","1/5"]}