[{"id":37161,"web_url":"https://patchwork.libcamera.org/comment/37161/","msgid":"<176468423644.2003224.3307138679809834127@ping.linuxembedded.co.uk>","date":"2025-12-02T14:03:56","subject":"Re: [RFC PATCH v1 2/3] libcamera: device_enumerator_udev: Disable\n\tcopy/move","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2025-12-02 13:58:16)\n> The the default implementations generated by the compiler are not appropriate.\n\n/The the/The/\n\n\nReviewed-by: Kieran Bingham \n\n> So disable them.\n> \n> Signed-off-by: Barnabás Pőcze \n> ---\n> include/libcamera/internal/device_enumerator_udev.h | 4 ++++\n> 1 file changed, 4 insertions(+)\n> \n> diff --git a/include/libcamera/internal/device_enumerator_udev.h b/include/libcamera/internal/device_enumerator_udev.h\n> index fb0005921a..c2f7154b6b 100644\n> --- a/include/libcamera/internal/device_enumerator_udev.h\n> +++ b/include/libcamera/internal/device_enumerator_udev.h\n> @@ -14,6 +14,8 @@\n> #include \n> #include \n> \n> +#include \n> +\n> #include \"libcamera/internal/device_enumerator.h\"\n> \n> struct udev;\n> @@ -54,6 +56,8 @@ private:\n> DependencyMap deps_;\n> };\n> \n> + LIBCAMERA_DISABLE_COPY_AND_MOVE(DeviceEnumeratorUdev)\n> +\n> int addUdevDevice(struct udev_device *dev);\n> int populateMediaDevice(MediaDevice *media, DependencyMap *deps);\n> std::string lookupDeviceNode(dev_t devnum);\n> -- \n> 2.52.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D28B2BD80A\n\tfor ;\n\tTue, 2 Dec 2025 14:04:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4ED760C8C;\n\tTue, 2 Dec 2025 15:04:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 865B16096B\n\tfor ;\n\tTue, 2 Dec 2025 15:03:59 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A43116A;\n\tTue, 2 Dec 2025 15:01:45 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"oAWBzDRh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764684105;\n\tbh=cLrxqxPb275UxbvVQ97n817AAzzOFmAentc58j/euOo=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=oAWBzDRh5W4gtzJoxdlS3XK5DVwaHdciz3714ewkATq1Wj0rK2lxep6eG4deJUvKe\n\tzF6y8HvzMQN65rTJzq3v96elWINuODhml8z8pk4D1KiKE/lRTAfLGKK+jj8HMcyFSw\n\tX1Eaa4ENMunziOWNSRqoKzsSI/AurCBKJCdVbrK0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251202135817.1607250-2-barnabas.pocze@ideasonboard.com>","References":"<20251202135817.1607250-1-barnabas.pocze@ideasonboard.com>\n\t<20251202135817.1607250-2-barnabas.pocze@ideasonboard.com>","Subject":"Re: [RFC PATCH v1 2/3] libcamera: device_enumerator_udev: Disable\n\tcopy/move","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 02 Dec 2025 14:03:56 +0000","Message-ID":"<176468423644.2003224.3307138679809834127@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]