[{"id":37202,"web_url":"https://patchwork.libcamera.org/comment/37202/","msgid":"<85a4zz1id3.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-03T19:21:44","subject":"Re: [PATCH v6 13/24] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> Make getInputConfig and getOutputConfig static so as to allow for\n> interrogation of the supported pixel formats prior to object instantiation.\n> Do this so as to allow the higher level logic make an informed choice\n> between CPU and GPU ISP based on which pixel formats are supported.\n>\n> Currently CPU ISP supports more diverse input and output schemes.\n>\n> Acked-by: Kieran Bingham \n> Signed-off-by: Bryan O'Donoghue \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/software_isp/debayer_cpu.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n>\n> diff --git a/src/libcamera/software_isp/debayer_cpu.h b/src/libcamera/software_isp/debayer_cpu.h\n> index ecc4f9dd0..67df2b93a 100644\n> --- a/src/libcamera/software_isp/debayer_cpu.h\n> +++ b/src/libcamera/software_isp/debayer_cpu.h\n> @@ -97,8 +97,8 @@ private:\n> \ttemplate\n> \tvoid debayer10P_RGRG_BGR888(uint8_t *dst, const uint8_t *src[]);\n> \n> -\tint getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n> -\tint getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n> +\tstatic int getInputConfig(PixelFormat inputFormat, DebayerInputConfig &config);\n> +\tstatic int getOutputConfig(PixelFormat outputFormat, DebayerOutputConfig &config);\n> \tint setupStandardBayerOrder(BayerFormat::Order order);\n> \tint setDebayerFunctions(PixelFormat inputFormat,\n> \t\t\t\tPixelFormat outputFormat,","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0123BBD80A\n\tfor ;\n\tWed, 3 Dec 2025 19:21:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3F72F6101E;\n\tWed, 3 Dec 2025 20:21:52 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B89E1609D8\n\tfor ;\n\tWed, 3 Dec 2025 20:21:50 +0100 (CET)","from mail-wm1-f70.google.com (mail-wm1-f70.google.com\n\t[209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-138-0kMH27nUMmmXQVH59Np-Sw-1; Wed, 03 Dec 2025 14:21:47 -0500","by mail-wm1-f70.google.com with SMTP id\n\t5b1f17b1804b1-4779b3749a8so730175e9.1\n\tfor ;\n\tWed, 03 Dec 2025 11:21:47 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4792a7b0726sm64806985e9.15.2025.12.03.11.21.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 03 Dec 2025 11:21:45 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"IO5h+NFy\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1764789709;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=LQsrXbtIifc4uk1upmtI80GqgqnBwjI1i87bY+rTmHc=;\n\tb=IO5h+NFy4gaH7fl7zmwp87vqzl9hDEe2xeLdrD2uKh0sopVzOPm92nWj+wSQ+7uMoRJxnT\n\t+wm3cEFIAqhjzUH1t6uVLEzKxcS0yHkz+MT5ldKYC+FpzVTfGYpPc5gkWwf9pf7HyFu9tD\n\teITFzLCFnZVn/iULFRBcsqUN5fZIRwc=","X-MC-Unique":"0kMH27nUMmmXQVH59Np-Sw-1","X-Mimecast-MFC-AGG-ID":"0kMH27nUMmmXQVH59Np-Sw_1764789707","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764789706; x=1765394506;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=LQsrXbtIifc4uk1upmtI80GqgqnBwjI1i87bY+rTmHc=;\n\tb=K+IGhwScWaCz4wS2/PKzap1mdD3H/npt7K+xbSvM8wrcjFUdBdfIMZILNZ7EjsvDIc\n\tBEkglSkgTzuLHIGuRk96SeEL7N2xe0qEPrJBAItmZ4F7MhTzy9ZG66J5L5MPD80dGmKN\n\taiGDjp9ZffOJ/V9OLwM8ipE5Tu7Nqzgdo1ydb8Asr7iCcLqy71asV3ovg/Bh7hg2AQOZ\n\tAoehvN67kuW50gT54UUhhfYWyG+I7UGQDIUkgMAne7vfRHitHwpx5tQ799AcqK/2faZG\n\tf2wkgjltvnmsu76oFQVXfewI8fmzZt1mcLSU2n7DScWN1o4dzXRk2LBUNeoKBm3bV2dW\n\tGtiQ==","X-Gm-Message-State":"AOJu0YyiS9p8UlX90VTSuxx5ZLQwdO2igIE1RCVadoJXoRMocbCYGr7G\n\tydTXQor62xQJ1u4TpdzzPTb0W4sbyZroy/Duci3zQeRqyOSewbNfQVCBbWJH7mJghNFteCQaKgP\n\t4+xFRfGEba8oh7HAd7A7eDuvcyFqVQZjyNoEf5ere1Waa+n3LOOtqL/u4MzUC/ikNwGdS1gIVw3\n\t4=","X-Gm-Gg":"ASbGncskispjz8BEGyiVGUgM+d2wy7ju3UjIXlFJm24GpUQGd/UCeGS98WT+W4u3MoW\n\tlXtfIc68WMRTEJbKhzyQOWoIzvhvssNhKyWpRQzsw32tKbFpv04nNS9goOOCFzrrSL3rq5p947W\n\t9h5rL19ZTYXSvLwONglVPxuWI4wo+nmQeBTcz9icp+QrzEahnavlKEHPlrPBmGxRBHF0yBVdz/D\n\t7ih5pa+6VfP/U3cObwlUM93PPnj2xgS2kHh4SWzYqVs0Pg2WOobERrYwuygEPJPf2FFSdRiBcPA\n\tepFXBA6M/CwctMLrNKBUcNgb+MVj9yk8i4hh8cCvC8Od4lvKy3I4OVsQ5R0QrQo8C9tCWZag6ER\n\tr34NPt6dwbQFH646/xj3MIXIedudpsIqciKjJkk4NhR06kUOYugRUi43xYa+mhYg=","X-Received":["by 2002:a05:600c:5250:b0:46e:32dd:1b1a with SMTP id\n\t5b1f17b1804b1-4792aee38fdmr34528635e9.7.1764789706537; \n\tWed, 03 Dec 2025 11:21:46 -0800 (PST)","by 2002:a05:600c:5250:b0:46e:32dd:1b1a with SMTP id\n\t5b1f17b1804b1-4792aee38fdmr34528455e9.7.1764789706119; \n\tWed, 03 Dec 2025 11:21:46 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IEdVx997ncEB/V7dM8/cI2kaf5BJm9mrMXdGFiowUrzLUuvwf3YjlaPOvt4uK7NJEIem4GeFA==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz, Kieran Bingham\n\t","Subject":"Re: [PATCH v6 13/24] libcamera: software_isp: debayer_cpu: Make\n\tgetInputConfig and getOutputConfig static","In-Reply-To":"<20251202134544.662446-14-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Tue, 2 Dec 2025 13:45:33 +0000\")","References":"<20251202134544.662446-1-bryan.odonoghue@linaro.org>\n\t<20251202134544.662446-14-bryan.odonoghue@linaro.org>","Date":"Wed, 03 Dec 2025 20:21:44 +0100","Message-ID":"<85a4zz1id3.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"XJHSmJ9J5WJKEkdpvo-SmvcGLsNu2JR_MmYhR1QhVrE_1764789707","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]