[{"id":37199,"web_url":"https://patchwork.libcamera.org/comment/37199/","msgid":"<85qztb1jjy.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-03T18:56:01","subject":"Re: [PATCH v6 09/24] libcamera: shaders: Add support for Gamma","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> Add gamma compentation to the debayer shaders after colour correction is\n\ns/compentation/compensation/\n\n> applied.\n>\n> Similarly only apply the calculated Gamma curve when using the CCM as the\n> lookup tables already contain the data.\n>\n> Suggested-by: Milan Zamazal \n> Signed-off-by: Bryan O'Donoghue \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/shaders/bayer_1x_packed.frag | 4 ++++\n> src/libcamera/shaders/bayer_unpacked.frag | 4 ++++\n> 2 files changed, 8 insertions(+)\n>\n> diff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\n> index 7036fe278..77d9fbfa7 100644\n> --- a/src/libcamera/shaders/bayer_1x_packed.frag\n> +++ b/src/libcamera/shaders/bayer_1x_packed.frag\n> @@ -67,6 +67,7 @@ uniform vec2 tex_bayer_first_red;\n> uniform sampler2D tex_y;\n> uniform mat3 ccm;\n> uniform vec3 blacklevel;\n> +uniform float gamma;\n> \n> void main(void)\n> {\n> @@ -260,6 +261,9 @@ void main(void)\n> \trgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n> \trgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n> \n> +\t/* Apply gamma after colour correction */\n> +\trgb = pow(rgb, vec3(gamma));\n> +\n> #if defined (SWAP_BLUE)\n> \tgl_FragColor = vec4(rgb.bgr, 1.0);\n> #else\n> diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\n> index f0d8cd1e2..aba11a87f 100644\n> --- a/src/libcamera/shaders/bayer_unpacked.frag\n> +++ b/src/libcamera/shaders/bayer_unpacked.frag\n> @@ -26,6 +26,7 @@ varying vec4 yCoord;\n> varying vec4 xCoord;\n> uniform mat3 ccm;\n> uniform vec3 blacklevel;\n> +uniform float gamma;\n> \n> void main(void) {\n> vec3 rgb;\n> @@ -155,6 +156,9 @@ void main(void) {\n> rgb.g = (rin * ccm[1][0]) + (gin * ccm[1][1]) + (bin * ccm[1][2]);\n> rgb.b = (rin * ccm[2][0]) + (gin * ccm[2][1]) + (bin * ccm[2][2]);\n> \n> + /* Apply gamma after colour correction */\n> + rgb = pow(rgb, vec3(gamma));\n> +\n> #if defined (SWAP_BLUE)\n> gl_FragColor = vec4(rgb.bgr, 1.0);\n> #else","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5C0EBBD80A\n\tfor ;\n\tWed, 3 Dec 2025 18:56:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6A2A860F7C;\n\tWed, 3 Dec 2025 19:56:09 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CACFD609D8\n\tfor ;\n\tWed, 3 Dec 2025 19:56:07 +0100 (CET)","from mail-wm1-f69.google.com (mail-wm1-f69.google.com\n\t[209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-335-ZSl0SgV3OUe0GOPK49h1VA-1; Wed, 03 Dec 2025 13:56:04 -0500","by mail-wm1-f69.google.com with SMTP id\n\t5b1f17b1804b1-47904cdb9bbso10555045e9.1\n\tfor ;\n\tWed, 03 Dec 2025 10:56:04 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42e1c5d618csm40091980f8f.14.2025.12.03.10.56.02\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 03 Dec 2025 10:56:02 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"TwYLKuoM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1764788166;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=J1Xm92c+7TkzGW89icy0hWyerGIr06817A14AazApt8=;\n\tb=TwYLKuoMeX1DVZjT144HvaZIyP6QPZk3rsU5XagMBP9CATXgQWHSxyBcQ1dUfjqBgQEGyM\n\t9de+P1bKsy+ozf3Rq9JmifS/AeTV/Vh0YaB2xapqGMxFNa2bReYIyuM7bSUk0AknCPfQoN\n\t6UVWV8Lux7PXuHRmJanwFseTCNLjeoM=","X-MC-Unique":"ZSl0SgV3OUe0GOPK49h1VA-1","X-Mimecast-MFC-AGG-ID":"ZSl0SgV3OUe0GOPK49h1VA_1764788163","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764788163; x=1765392963;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=J1Xm92c+7TkzGW89icy0hWyerGIr06817A14AazApt8=;\n\tb=ZjK4z1M1bUM3qFK9l3av2lvPNGZlH5KKMjwQ70bksX1M65+1lqfcWZ9wh4j1mynx58\n\tEl44Gy6LKghbVIQZzZ7MaXzyI0ZH2xX6he+raML+eTD9YNL8cZ7RTxvWrpTH4NLac78v\n\tUnY4o81+29oMZZNGFsNzXI4igAX+60e6qsJ/gUWwOIxpAA+4oO1yFpb6P7Xp+mpxyE/4\n\tGRLMuktEi0IGPaZn1cbdNaK1Xw7mh4aCgKcnr1w7rCH/n1/j+at7Jt+VP8CMFvq3d0Om\n\tpvN4QYZqHTSuL4uD9bp9MX2q8tchQL72cA72fTuQ6v/X1lObzMxLBkHNxttAnKml5hoF\n\tlSrg==","X-Gm-Message-State":"AOJu0Yx/OY7CCOHn0FanJ2n1qIhNK+jW/wxsbRJ44xxUNIJYZzp8INv+\n\tgzSadHzJ47Czq/tBMlpCtUWHGXcCeg937H9LnjaZ7ZnHK+LssD1GLl2UJGwJuyOl9aKOKR/zNQA\n\t6v6+fxqm8WqH4camDzGlvAayWCjO4PQTmkTZ4SsvXKZpFAF/TAj9V6Apn2FcbNSbChSZjpj1fNl\n\tE=","X-Gm-Gg":"ASbGncsTaJ8diQUNAWKC+D1k9U9NERwD7D229vVb/bCOoVxes/CjWtFFBgSrvV9HxJG\n\tqJLdFLxZpvffEH7C/iYqcpyKJpTgu3XCkbGozxOc47oCSiu9FaC3lSJGsF/6N1gNAJE2bLjjYwa\n\tTjOTyHzdqMb1cv9bE3WI5JSXyracxh3a/gNZc04BQuZlzEG+DHEgcrG5uolwSOFfhRVzLkE2oAb\n\trzo+ngXEzs7disLHS+/g97+RFJeOLA36Aa1kNrKKkybuHNsRhP5Ih8i8+ARUQc0+TMHfy56uli/\n\tAMjuAUVK3S/1dvitCRefn4at+vQd/nCo6iF2vNh/zsGJmY6CboUyR/oG/ayw3oVrq7rTsb4K9zo\n\tm5BjNOQqPLuOxqB16gkK3ixJmE2enNQpB/38hjRfvL6mi45L/EJBSZ+IBbt7lOHc=","X-Received":["by 2002:a05:600c:1986:b0:475:d9de:952e with SMTP id\n\t5b1f17b1804b1-4792eb1238bmr5202285e9.1.1764788163507; \n\tWed, 03 Dec 2025 10:56:03 -0800 (PST)","by 2002:a05:600c:1986:b0:475:d9de:952e with SMTP id\n\t5b1f17b1804b1-4792eb1238bmr5202175e9.1.1764788163137; \n\tWed, 03 Dec 2025 10:56:03 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IEol0pjbr6gSkOD+r8rDq91wFfHgFuBitxq7lojiXSnI2rJtu81svz+SA5tOlEjI5gIUjSy4g==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz","Subject":"Re: [PATCH v6 09/24] libcamera: shaders: Add support for Gamma","In-Reply-To":"<20251202134544.662446-10-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Tue, 2 Dec 2025 13:45:29 +0000\")","References":"<20251202134544.662446-1-bryan.odonoghue@linaro.org>\n\t<20251202134544.662446-10-bryan.odonoghue@linaro.org>","Date":"Wed, 03 Dec 2025 19:56:01 +0100","Message-ID":"<85qztb1jjy.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"w7CFsKNHSp9vEHLhwjRuiIvLkmx1lj412hHMN1zOLcs_1764788163","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]