[{"id":37173,"web_url":"https://patchwork.libcamera.org/comment/37173/","msgid":"<66af9fda-16e4-4adc-88fb-392095f3dc07@linaro.org>","date":"2025-12-02T22:54:12","subject":"Re: [PATCH v6 06/24] libcamera: shaders: Extend debayer shaders to\n\tapply RGB gain values on output","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"content":"On 02/12/2025 13:45, Bryan O'Donoghue wrote:\n> Extend out the bayer fragment shaders to take 3 x 256 byte inputs as\n> textures from the CPU.\n> \n> We then use an index to the table to recover the colour-corrected values\n> provided by the SoftIPA thread.\n> \n> Reviewed-by: Milan Zamazal<mzamazal@redhat.com>\n> Signed-off-by: Bryan O'Donoghue<bryan.odonoghue@linaro.org>\n\nThis commit log needs to change.\n\nUnless there is more significant feedback on this series, perhaps \n@kieran would fix up when applying :)\n\n\"Extend bayer shaders to support application of a passed CCM.\"\n\n\n---\nbod","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6719CC3257\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue,  2 Dec 2025 22:54:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 943EF60D35;\n\tTue,  2 Dec 2025 23:54:17 +0100 (CET)","from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5D5F960C8A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue,  2 Dec 2025 23:54:16 +0100 (CET)","by mail-wm1-x32d.google.com with SMTP id\n\t5b1f17b1804b1-47755de027eso42100245e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 02 Dec 2025 14:54:16 -0800 (PST)","from [192.168.0.27] (188-141-3-146.dynamic.upc.ie. [188.141.3.146])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4792b157c3csm913665e9.6.2025.12.02.14.54.13\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tTue, 02 Dec 2025 14:54:14 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"OkWFpGqL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764716055; x=1765320855;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=rmgm9uBSnzg6Y8lCAjB/EMoBnm8ga2KkE6Y3MoGYTR0=;\n\tb=OkWFpGqL0oCnAoOOE4u+ud+ikOcrCw2T+y0BwvwB7/iOZ55MnEMEsqtWaRXjZ/ZJGF\n\tG8WXICt/2TfRkqjCkPC1mO7PiorljmyZi3jQFFHmwrS/I9OZ8qe6kgNzB34Z4utJQf8o\n\tAzYhnNeI+91GpYWmZl2gdjpejpHQCcvmmfcmk0jUWphhSdwm3MofNd64vqe5vpysPjxu\n\tNtGl8jzrMtxl7r6Ygnxao2sb2PDG2Ba33OvZtEhJCIs8nEqNNTMKoMHnWQStFV3Ar5dv\n\te4lhfhIYUmIHEX0aho5dr1vJ5pxfvqj7LUWh7zbFJN5E0SmPrtLXGZhpoYePw/ZBQSQv\n\ti8qQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764716055; x=1765320855;\n\th=content-transfer-encoding:in-reply-to:content-language:from\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=rmgm9uBSnzg6Y8lCAjB/EMoBnm8ga2KkE6Y3MoGYTR0=;\n\tb=TiQXOEUv70Y50iyD8VJsc/fLOmmE06CABrE3iLgSdfuxEP8/+iViWlD1LbhdEC0LzB\n\twSAT42sVvLU+2R1XxeKaPCbS6WfBX+hekJeum6hH4UomHBH/+yxGPMBiUymfq6j3oK99\n\tTfKWrat+2L/ulSyFasKcRVSVbAJLFAJQZeZKwG0VHA/Wn8vm7/xuu/5DpbEXUFxuVsgM\n\tkFufTP0NWoa0nwtjnQQ+oF+dNO+ZzYC6I6QhcuSJo0G/XnhxUPI/tBEqd0viruOtrC9B\n\tRWTjpbv4Lrk/gB3clfzl2TYqUOsU25x7siW0f97tobI+Pq98Qt1Sydekau7yreIIjKdK\n\taxfA==","X-Gm-Message-State":"AOJu0YzAu0aSKkocMDM+d94OqKFHHP7i8SqR61YRJ1MDAYzORXFplnmk\n\t+Lovy0DCg8vmOaJTQopuyWMOXYdRuyrJYDA6cDTA31dxAMPalw1XB1CHxnpck8DrE4x5QEE9di5\n\tAj1Yo","X-Gm-Gg":"ASbGncswCGvWYzwl2bz4649t3G5UF9XdRx2wQAXz9nhQnOp6n9CLodwFMGG7QJ+u0AR\n\tEDethnP85xLLoWQPu/KCwGk//YNkqjxTb6WmavbUoM/O4dVGpjdUT/oVNx1A6OCXDMnsmzNEgqM\n\tUrMaULf9T/K/4j1Pt3HgZdouRQMYj1Qh5utEuZ4KJP4NaCJZAvsYKnPmXMGSyx+HS0kB8R6EsP9\n\tbudEHbpYFJVwx/PLVevoAU+cqoc/JVDsmM2D7WnfkkHdrzfITrVRoKchoWfDx7t2EG22CRg+Jz1\n\tUXHxkksJBYlHTy8D8pGyhA3hI19QV/ojn1UrxxoxuEoFnXkVshhAYwxdKeghGmBA3od1XBxCJEe\n\tT6OAubr79s70h7lfl1wUAR9HRsc2BVKB9IPUG2ekwFgu8SC7d2uLkXIr9l0pcfzI+tb60jXnh4o\n\tI7Pt9a2f5+6CbrfoUo5HIOckzKYzxEODFD3cStI/YhuTKuE8LZ/yGE","X-Google-Smtp-Source":"AGHT+IHKX6u3OfeV3QYzVi9sPjuFPKlhGQtkFrH9UmNhMU/gyVSP6U5NaIstt+vjkwDMTHn/pku1vg==","X-Received":"by 2002:a05:600c:c87:b0:477:7991:5d1e with SMTP id\n\t5b1f17b1804b1-4792af3f674mr1997145e9.25.1764716055558; \n\tTue, 02 Dec 2025 14:54:15 -0800 (PST)","Message-ID":"<66af9fda-16e4-4adc-88fb-392095f3dc07@linaro.org>","Date":"Tue, 2 Dec 2025 22:54:12 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v6 06/24] libcamera: shaders: Extend debayer shaders to\n\tapply RGB gain values on output","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Milan Zamazal <mzamazal@redhat.com>","References":"<20251202134544.662446-1-bryan.odonoghue@linaro.org>\n\t<20251202134544.662446-7-bryan.odonoghue@linaro.org>","From":"Bryan O'Donoghue <bryan.odonoghue@linaro.org>","Content-Language":"en-US","In-Reply-To":"<20251202134544.662446-7-bryan.odonoghue@linaro.org>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]