{"id":25304,"url":"https://patchwork.libcamera.org/api/patches/25304/?format=json","web_url":"https://patchwork.libcamera.org/patch/25304/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251202133157.661407-19-bryan.odonoghue@linaro.org>","date":"2025-12-02T13:31:49","name":"[v3,18/22] libcamera: software_isp: debayer: Make the debayer_ object of type class Debayer not DebayerCpu","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"cf156649d506a3329d47fe84ae0b35128234309e","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25304/mbox/","series":[{"id":5630,"url":"https://patchwork.libcamera.org/api/series/5630/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5630","date":"2025-12-02T13:31:31","name":"GPUISP precursor series","version":3,"mbox":"https://patchwork.libcamera.org/series/5630/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25304/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25304/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0717C32F4\n\tfor ;\n\tTue, 2 Dec 2025 13:32:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BC7160E27;\n\tTue, 2 Dec 2025 14:32:35 +0100 (CET)","from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6FEE660D1D\n\tfor ;\n\tTue, 2 Dec 2025 14:32:22 +0100 (CET)","by mail-wm1-x32d.google.com with SMTP id\n\t5b1f17b1804b1-477563e28a3so36799615e9.1\n\tfor ;\n\tTue, 02 Dec 2025 05:32:22 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42e1c5c30c4sm33363322f8f.9.2025.12.02.05.32.20\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Dec 2025 05:32:21 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Tt4s7D+8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764682342; x=1765287142;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=XKx6dnLcAAKiMuvnL7lnAZrPjjjZBylNVwjMOuMrIMM=;\n\tb=Tt4s7D+8Qf5arUKGbRXDdFioKIn77Tv5NwP8EIdjPP17Oy3aOy7N/eNzZA5FTsCM7r\n\tKP9AKx//9zGOQr04ocVihTvG0z5UthiHdT8PC8+DUNanjmloxwCDIP3S0ky1UiBdfjh1\n\tjheOOb3oj4b7MG7UUFaZwKsuVKEN6NjW3m4FcCvluIWMdfqWBCuus17kVuuQmJp9H3Kq\n\tMb+pO6HVk0A03FVIGXBrJNVrapgi+DKlgQLPW6J3D2bzakNRG/z2tNkt3ovNWGGJ3nGK\n\t0IYeKcjGXUHUUF9hxW7PIVVd+cuSl81IdvAdwJUx6YKILQAo+DEwmHFuaYI45PBidh5d\n\tpjgw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764682342; x=1765287142;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=XKx6dnLcAAKiMuvnL7lnAZrPjjjZBylNVwjMOuMrIMM=;\n\tb=grlO43Kw94NlUoFVP4kbzi6agl6rVKfkbzksqnLA/xllN1x3NEgyl5qRnibf9Q6eip\n\tuD9ULUCMW2aPti5bEAimKqYdpKtJz02gkqqbluglDqapgohgxMKU3LDcHqHOj/0IJAEy\n\tnkBK14q3QEpYWzz6dPd2XKJ3nH1A9epS7pFwamfq9e/T1uUowLM9RdEBFRrAWuR9OoVG\n\tDml05k90+6b6gCDa6X0CJkNLmy/1Ee2NA/MmQ4UntbnoYLpWpo60jj2Bj1UQmScoXoSN\n\tvKdGupsQNuy4yx9RRe7nYmI3u/gx74nSvc01ecTgbU819pRVkET6o+2Rnnp+7FhnI8wE\n\tAlbw==","X-Gm-Message-State":"AOJu0Yw6Diro/A3xbVQsPmfpFmh6RuxSL0g0AC7zJtL/G8WfoHfpWiHg\n\tY+9NeofHkUVbBnRFyOrMCtiEiC9nMbdgXt7+/bzi3RXqJz+KwogsZRFEQAKij7/NCDQuVz7H1/x\n\tCL6kr","X-Gm-Gg":"ASbGncujlABJ2BCMLyF+MIeYnXeV8ADQfE6Tb/HuyOsBKtmRtvjoDZgmMM6pN/DrclA\n\tyShgu/UJ6ktREWx3AW/2t+oa+U2SyF25rBVlNmIJR5y5dhM+3URU9dh2D7BTMwKF9OHUQBEZpYb\n\tDrxGLgyBb1mK5GF42UkgznJ78AE62cwhLJPjyvZbi1XUPpSmBf8YqasU2hRW3BHOveDZY0DNY0W\n\tnpW90WH/xJO2O0ksdvx9Vf8KCvezQAMDifnkQXB2y9cOQYrecFVnifOyRQWckCvof3tDES8724J\n\tQFrV2U0LwJQtIruiUDFY0YWyIBINlXeekuJJNAP6D9ZW8k07EFC3IHEGf7hp3GkjbCHXP2uciig\n\tF641YrbcTlQN5FoG/nSR91PHjkcVPOMCbuxBe/0/esAyD0t/hG47BJAlj3rjRpGT8YsA8oAPpJt\n\tTGlzA2xXHE5RtiyMmbN8GU5AupfV+LDnZOKTRkdySuuTXNZkNyeu1u41KyRxU/OYo3aA8=","X-Google-Smtp-Source":"AGHT+IHD67lytfHakPZ/BKvvXyCtSJbqrYmOdB+xxY+nOlJmNtRyrWvNWY9OMFe6PcNDhFnb1xgnZg==","X-Received":"by 2002:a05:600c:314f:b0:477:a1bb:c58e with SMTP id\n\t5b1f17b1804b1-47926f93e8bmr26236355e9.7.1764682341737; \n\tTue, 02 Dec 2025 05:32:21 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ,\n\tMilan Zamazal ","Subject":"[PATCH v3 18/22] libcamera: software_isp: debayer: Make the debayer_\n\tobject of type class Debayer not DebayerCpu","Date":"Tue, 2 Dec 2025 13:31:49 +0000","Message-ID":"<20251202133157.661407-19-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.52.0","In-Reply-To":"<20251202133157.661407-1-bryan.odonoghue@linaro.org>","References":"<20251202133157.661407-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Make the type of object Debayer not DebayerCpu thus allowing us to assign\nthe object to either DebayerCpu or DebayerEGL.\n\nReviewed-by: Kieran Bingham \nReviewed-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n include/libcamera/internal/software_isp/software_isp.h | 5 ++---\n src/libcamera/software_isp/software_isp.cpp | 6 +++---\n 2 files changed, 5 insertions(+), 6 deletions(-)","diff":"diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h\nindex 786246592..ad89c9b3c 100644\n--- a/include/libcamera/internal/software_isp/software_isp.h\n+++ b/include/libcamera/internal/software_isp/software_isp.h\n@@ -37,7 +37,7 @@\n \n namespace libcamera {\n \n-class DebayerCpu;\n+class Debayer;\n class FrameBuffer;\n class PixelFormat;\n class Stream;\n@@ -94,8 +94,7 @@ private:\n \tvoid statsReady(uint32_t frame, uint32_t bufferId);\n \tvoid inputReady(FrameBuffer *input);\n \tvoid outputReady(FrameBuffer *output);\n-\n-\tstd::unique_ptr debayer_;\n+\tstd::unique_ptr debayer_;\n \tThread ispWorkerThread_;\n \tSharedMemObject sharedParams_;\n \tDebayerParams debayerParams_;\ndiff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex c0ff91cc4..638d9a6e6 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -267,7 +267,7 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \n \tispWorkerThread_.start();\n \n-\tret = debayer_->invokeMethod(&DebayerCpu::configure,\n+\tret = debayer_->invokeMethod(&Debayer::configure,\n \t\t\t\t ConnectionTypeBlocking, inputCfg,\n \t\t\t\t outputCfgs, ccmEnabled_);\n \tif (ret) {\n@@ -367,7 +367,7 @@ int SoftwareIsp::start()\n */\n void SoftwareIsp::stop()\n {\n-\tdebayer_->invokeMethod(&DebayerCpu::stop,\n+\tdebayer_->invokeMethod(&Debayer::stop,\n \t\t\t ConnectionTypeBlocking);\n \n \tispWorkerThread_.exit();\n@@ -401,7 +401,7 @@ void SoftwareIsp::stop()\n void SoftwareIsp::process(uint32_t frame, FrameBuffer *input, FrameBuffer *output)\n {\n \tipa_->computeParams(frame);\n-\tdebayer_->invokeMethod(&DebayerCpu::process,\n+\tdebayer_->invokeMethod(&Debayer::process,\n \t\t\t ConnectionTypeQueued, frame, input, output, debayerParams_);\n }\n \n","prefixes":["v3","18/22"]}