[{"id":37185,"web_url":"https://patchwork.libcamera.org/comment/37185/","msgid":"<85sedr3ap9.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","date":"2025-12-03T14:24:18","subject":"Re: [PATCH v3 16/22] libcamera: software_isp: Move configure to\n\tworker thread","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Bryan O'Donoghue writes:\n\n> EGL requires both configure() and process() to operate on the same\n> thread. As preparation for that, move current CPU configure into the\n> WorkerThread with a ConnectionTypeBlocking invocation of\n> &DebayerCpu::configure.\n>\n> Reviewed-by: Kieran Bingham \n> Signed-off-by: Bryan O'Donoghue \n\nReviewed-by: Milan Zamazal \n\n> ---\n> src/libcamera/software_isp/software_isp.cpp | 10 +++++++++-\n> 1 file changed, 9 insertions(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\n> index afa4eb7a8..4f6792122 100644\n> --- a/src/libcamera/software_isp/software_isp.cpp\n> +++ b/src/libcamera/software_isp/software_isp.cpp\n> @@ -267,7 +267,15 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n> \n> \tispWorkerThread_.start();\n> \n> -\treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n> +\tret = debayer_->invokeMethod(&DebayerCpu::configure,\n> +\t\t\t\t ConnectionTypeBlocking, inputCfg,\n> +\t\t\t\t outputCfgs, ccmEnabled_);\n> +\tif (ret) {\n> +\t\tispWorkerThread_.exit();\n> +\t\tispWorkerThread_.wait();\n> +\t}\n> +\n> +\treturn ret;\n> }\n> \n> /**","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB0EFC3257\n\tfor ;\n\tWed, 3 Dec 2025 14:24:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1A19960F37;\n\tWed, 3 Dec 2025 15:24:28 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1938D609D8\n\tfor ;\n\tWed, 3 Dec 2025 15:24:26 +0100 (CET)","from mail-wr1-f70.google.com (mail-wr1-f70.google.com\n\t[209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-192-1KC7e3zZMqiPcJwzIBe7ZA-1; Wed, 03 Dec 2025 09:24:22 -0500","by mail-wr1-f70.google.com with SMTP id\n\tffacd0b85a97d-42e2e5ef669so2630073f8f.0\n\tfor ;\n\tWed, 03 Dec 2025 06:24:22 -0800 (PST)","from mzamazal-thinkpadp1gen7.tpbc.csb\n\t(ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-42e1ca78f77sm39911826f8f.32.2025.12.03.06.24.19\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 03 Dec 2025 06:24:19 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"RHMK8Ksc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1764771865;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=C8DldO1D92UiXBZ5jNdCdwccFrVuqiwz+MyPvTOOlgY=;\n\tb=RHMK8KscWc4oo0BhUmdeCSK841s6UCK0r6GnnPablcRXoHyrisgtBVltA3WI1tmgKyRJyq\n\thfcUs841Z1qhbZ9bbNVTmXGz6oKHILKIwMPR9/ktScYNvk94Sm0JATZSmPbTFHls6SsZF3\n\tKnUk9hB8eYXcT8+u78rgXVciOW5q7Cc=","X-MC-Unique":"1KC7e3zZMqiPcJwzIBe7ZA-1","X-Mimecast-MFC-AGG-ID":"1KC7e3zZMqiPcJwzIBe7ZA_1764771860","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764771860; x=1765376660;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject\n\t:date:message-id:reply-to;\n\tbh=C8DldO1D92UiXBZ5jNdCdwccFrVuqiwz+MyPvTOOlgY=;\n\tb=KuEzI4xbJGxJEN9VNfdSBktZKEts8SRRCGl5/IW9+E7GuAOwU9o/Hp5Tl0fzKMWjb8\n\tpQM3X8ubHf80A4eAacwTqQIumF89ZjCMlARMTuyw5BbqZtK7dP7HCv+XoJMFiA1irsQ4\n\tVjK0YaL2S+4Y2BZuuP1nREQLbZGfgKRGN3ujmBjLTadijMt9+SqWP0yMBmcDfoFljeuL\n\tqqY9rBlSSrph3X/FYNL0tEQaW+Wf6n8MP0EJ0b5SOCh2ZNrcOBcPBsr5R387tajtqz+i\n\tviLWb579uj+ugQ6K2UXCBLB5CfzrvHOfC1o1pX89eIJD1bxlEJquhouR4hA2WmJeQz37\n\tDEdg==","X-Gm-Message-State":"AOJu0YzK8so73ktGZcopVwKwnE8g2QTMCz/r978R/gpOQbJczVNML5me\n\t8m5jyIE4dCuqnTqbURVzTCv2/okEKzENdm8mKt6J9OO8GIGpRBGa7tYrLXEloa/fhM8xd7qQzoY\n\tLzroFJnLq21m281UGfyd5o9iJlpzUaA3IsrmkO4q6XGtf6gOwdMto0WohD1hqrHIfRkhK6SPCsu\n\tA=","X-Gm-Gg":"ASbGncs2OzWyxpfobk8n/3rOLAKsVusCy0ARS7HqFC+PpiE0ocMPKB4N+8giJiEW6Iz\n\tdKluxCCLOCCG3TnaIRDhr/D7AW9Rh199Mi0/prSFIc2I8pGNEifSm8/Wi+wEdfTd3He+BEqjmXq\n\tX/TCEBA7QRxWplE0PHvBXxSrW7vzcH3WwRRqnThAzMRe0cULiNOUqyBUyFcYYMk+bVtH10JRf8q\n\tSkMWIWC62NUPNu+pZe0zpHwlbT+fhUSdvht87HxHzxFxQJF/dkLXwR0vZyxTMwHQwwKroSzEn8M\n\tZA6JDZ6uRNErtMm2S54gjhsyZihImJ8qj0RqC5tD2Qy8zwv3jOWjUPfA1AWaYj6UoZQRlLcVxyd\n\thWEzYA8jcgfiEmg0DbvvagW86Ij49z2OFDnKCYQAL0yUS5BfxrjF2PkaZBf89mDg=","X-Received":["by 2002:a05:6000:22c6:b0:42b:3746:3b84 with SMTP id\n\tffacd0b85a97d-42f731e9b99mr2390490f8f.55.1764771860291; \n\tWed, 03 Dec 2025 06:24:20 -0800 (PST)","by 2002:a05:6000:22c6:b0:42b:3746:3b84 with SMTP id\n\tffacd0b85a97d-42f731e9b99mr2390460f8f.55.1764771859903; \n\tWed, 03 Dec 2025 06:24:19 -0800 (PST)"],"X-Google-Smtp-Source":"AGHT+IHVE71SwUEXu40T4U+1fe386665RY9p0ZKaXlhKntv37eFUovji3PcyDueWX50hgvi8b0FB6A==","From":"Milan Zamazal ","To":"Bryan O'Donoghue ","Cc":"libcamera-devel@lists.libcamera.org, pavel@ucw.cz, Kieran Bingham\n\t","Subject":"Re: [PATCH v3 16/22] libcamera: software_isp: Move configure to\n\tworker thread","In-Reply-To":"<20251202133157.661407-17-bryan.odonoghue@linaro.org> (Bryan\n\tO'Donoghue's message of \"Tue, 2 Dec 2025 13:31:47 +0000\")","References":"<20251202133157.661407-1-bryan.odonoghue@linaro.org>\n\t<20251202133157.661407-17-bryan.odonoghue@linaro.org>","Date":"Wed, 03 Dec 2025 15:24:18 +0100","Message-ID":"<85sedr3ap9.fsf@mzamazal-thinkpadp1gen7.tpbc.csb>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"fbfKEPZj8JRz2pmpdW2TxYankHDjsVA0UOIbQfMfXMo_1764771860","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]