[{"id":37107,"web_url":"https://patchwork.libcamera.org/comment/37107/","msgid":"<176442334093.3800071.9749823728139117@ping.linuxembedded.co.uk>","date":"2025-11-29T13:35:40","subject":"Re: [PATCH] libcamera: controls: Small style fixes","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Jacopo Mondi (2025-11-28 15:48:30)\n> The Wdr controls have been added without an empty line between them and the\n> existing ones. Also, a line has a space at the end.\n> \n> Fix it.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> src/libcamera/control_ids_core.yaml | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index 3bcb475fd102..8e99bd84825f 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -677,7 +677,7 @@ controls:\n> stored in conventional reading order in an array of 9 floating point\n> values.\n> \n> - ColourCorrectionMatrix can only be applied in a Request when the AWB is\n> + ColourCorrectionMatrix can only be applied in a Request when the AWB is\n> disabled.\n\nMaybe it's just my email client but I can't see any change in the hunk\nabove.\n\nBut anyway, \n\nReviewed-by: Kieran Bingham \n\n> \n> \\sa AwbEnable\n> @@ -1283,6 +1283,7 @@ controls:\n> \\sa SensorTimestamp\n> \n> The FrameWallClock control can only be returned in metadata.\n> +\n> - WdrMode:\n> type: int32_t\n> direction: inout\n> @@ -1329,6 +1330,7 @@ controls:\n> This curve preserves most of the information of the image at the\n> expense of a very artificial look. It is therefore best suited for\n> technical analysis.\n> +\n> - WdrStrength:\n> type: float\n> direction: in\n> @@ -1338,6 +1340,7 @@ controls:\n> global tone mapping is applied. A values of 1 is the default value and\n> the correct value for most scenes. A value above 1 increases the global\n> tone mapping effect and can lead to unrealistic image effects.\n> +\n> - WdrMaxBrightPixels:\n> type: float\n> direction: in\n> --\n> 2.51.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8C135C0F2A\n\tfor ;\n\tSat, 29 Nov 2025 13:35:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 853DC60A85;\n\tSat, 29 Nov 2025 14:35:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C536C60805\n\tfor ;\n\tSat, 29 Nov 2025 14:35:43 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B0DDB3A4;\n\tSat, 29 Nov 2025 14:33:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JU8MVqgz\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764423211;\n\tbh=ELO53wyLXxCYVNlddsesedkEnAcdsVk6LcGI2/QzN0Y=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=JU8MVqgzXar0JlwiJISRKH05dBbvmxu9d25Dernea5dXqe/D6lNsEyuyBQrLOM3p7\n\t1Uy5q0UAERkFSNOh/yX/Us1KmUw76TWAB7tt/icuAkvQwDuPEpHFXjaIzDvxJqu9YI\n\t/U7lfWg9KSJYZnUG78JhBtFQXhRyPePgU4bXjWEs=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251128154832.176864-1-jacopo.mondi@ideasonboard.com>","References":"<20251128154832.176864-1-jacopo.mondi@ideasonboard.com>","Subject":"Re: [PATCH] libcamera: controls: Small style fixes","From":"Kieran Bingham ","Cc":"Jacopo Mondi ","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sat, 29 Nov 2025 13:35:40 +0000","Message-ID":"<176442334093.3800071.9749823728139117@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37114,"web_url":"https://patchwork.libcamera.org/comment/37114/","msgid":"","date":"2025-12-01T09:17:35","subject":"Re: [PATCH] libcamera: controls: Small style fixes","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Kieran\n\nOn Sat, Nov 29, 2025 at 01:35:40PM +0000, Kieran Bingham wrote:\n> Quoting Jacopo Mondi (2025-11-28 15:48:30)\n> > The Wdr controls have been added without an empty line between them and the\n> > existing ones. Also, a line has a space at the end.\n> >\n> > Fix it.\n> >\n> > Signed-off-by: Jacopo Mondi \n> > ---\n> > src/libcamera/control_ids_core.yaml | 5 ++++-\n> > 1 file changed, 4 insertions(+), 1 deletion(-)\n> >\n> > diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> > index 3bcb475fd102..8e99bd84825f 100644\n> > --- a/src/libcamera/control_ids_core.yaml\n> > +++ b/src/libcamera/control_ids_core.yaml\n> > @@ -677,7 +677,7 @@ controls:\n> > stored in conventional reading order in an array of 9 floating point\n> > values.\n> >\n> > - ColourCorrectionMatrix can only be applied in a Request when the AWB is\n> > + ColourCorrectionMatrix can only be applied in a Request when the AWB is\n> > disabled.\n>\n> Maybe it's just my email client but I can't see any change in the hunk\n> above.\n\nAs reported in the commit message \"a line has a space at the end\".\n\nMy editor removes them automatically, but they don't show up in the\nchangelog, you're right!\n\n\n>\n> But anyway,\n>\n> Reviewed-by: Kieran Bingham \n>\n> >\n> > \\sa AwbEnable\n> > @@ -1283,6 +1283,7 @@ controls:\n> > \\sa SensorTimestamp\n> >\n> > The FrameWallClock control can only be returned in metadata.\n> > +\n> > - WdrMode:\n> > type: int32_t\n> > direction: inout\n> > @@ -1329,6 +1330,7 @@ controls:\n> > This curve preserves most of the information of the image at the\n> > expense of a very artificial look. It is therefore best suited for\n> > technical analysis.\n> > +\n> > - WdrStrength:\n> > type: float\n> > direction: in\n> > @@ -1338,6 +1340,7 @@ controls:\n> > global tone mapping is applied. A values of 1 is the default value and\n> > the correct value for most scenes. A value above 1 increases the global\n> > tone mapping effect and can lead to unrealistic image effects.\n> > +\n> > - WdrMaxBrightPixels:\n> > type: float\n> > direction: in\n> > --\n> > 2.51.1\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5A611BD80A\n\tfor ;\n\tMon, 1 Dec 2025 09:17:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 78EBE60AAB;\n\tMon, 1 Dec 2025 10:17:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DE4C609D8\n\tfor ;\n\tMon, 1 Dec 2025 10:17:38 +0100 (CET)","from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9C2F6DF;\n\tMon, 1 Dec 2025 10:15:24 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NcKoJ5zk\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764580524;\n\tbh=u+qJ/LVvZSg6AEWJr4WJvO4RU1OTr52dZuIha2kiIg0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=NcKoJ5zki91PU5i81IoOesnbKnuPszTLiTA5jHI00R4d6cuD8d0d2jRBdvCETjxVC\n\t3f7s1WCxFbVFMX6fLUpfB4jHY3Ot1lw13vPs5s0o//Yj/cs9o9KOf8qDUV1iqfWyZT\n\tmHfvB5pKPVd1fOfdCG/BC8IkRkAIrIlH4Z4NKZWk=","Date":"Mon, 1 Dec 2025 10:17:35 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"Jacopo Mondi , \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: controls: Small style fixes","Message-ID":"","References":"<20251128154832.176864-1-jacopo.mondi@ideasonboard.com>\n\t<176442334093.3800071.9749823728139117@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<176442334093.3800071.9749823728139117@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37116,"web_url":"https://patchwork.libcamera.org/comment/37116/","msgid":"<9ad16def-0f58-48b3-935d-8c015c008298@ideasonboard.com>","date":"2025-12-01T09:22:48","subject":"Re: [PATCH] libcamera: controls: Small style fixes","submitter":{"id":216,"url":"https://patchwork.libcamera.org/api/people/216/","name":"Barnabás Pőcze","email":"barnabas.pocze@ideasonboard.com"},"content":"2025. 11. 28. 16:48 keltezéssel, Jacopo Mondi írta:\n> The Wdr controls have been added without an empty line between them and the\n> existing ones. Also, a line has a space at the end.\n> \n> Fix it.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n\nReviewed-by: Barnabás Pőcze \n\n\n> src/libcamera/control_ids_core.yaml | 5 ++++-\n> 1 file changed, 4 insertions(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index 3bcb475fd102..8e99bd84825f 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -677,7 +677,7 @@ controls:\n> stored in conventional reading order in an array of 9 floating point\n> values.\n> \n> - ColourCorrectionMatrix can only be applied in a Request when the AWB is\n> + ColourCorrectionMatrix can only be applied in a Request when the AWB is\n> disabled.\n> \n> \\sa AwbEnable\n> @@ -1283,6 +1283,7 @@ controls:\n> \\sa SensorTimestamp\n> \n> The FrameWallClock control can only be returned in metadata.\n> +\n> - WdrMode:\n> type: int32_t\n> direction: inout\n> @@ -1329,6 +1330,7 @@ controls:\n> This curve preserves most of the information of the image at the\n> expense of a very artificial look. It is therefore best suited for\n> technical analysis.\n> +\n> - WdrStrength:\n> type: float\n> direction: in\n> @@ -1338,6 +1340,7 @@ controls:\n> global tone mapping is applied. A values of 1 is the default value and\n> the correct value for most scenes. A value above 1 increases the global\n> tone mapping effect and can lead to unrealistic image effects.\n> +\n> - WdrMaxBrightPixels:\n> type: float\n> direction: in\n> --\n> 2.51.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 58956C0F1B\n\tfor ;\n\tMon, 1 Dec 2025 09:22:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D7DD60AAD;\n\tMon, 1 Dec 2025 10:22:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66304609D8\n\tfor ;\n\tMon, 1 Dec 2025 10:22:51 +0100 (CET)","from [192.168.33.24] (185.182.214.104.nat.pool.zt.hu\n\t[185.182.214.104])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3719C4F1;\n\tMon, 1 Dec 2025 10:20:38 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"hsi/6DLQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764580838;\n\tbh=6bUnG1lBgxLFu++HZRqhUBVrKAxGIGeaWyTdz09YZyM=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=hsi/6DLQ1kajdmjwcfSrofwQ4DFSNyJ+1y+eVLJOXxzjg50D1MZNpJYUTmiPPddv6\n\tSYPhcaZW8L26yZX6PONHla9xmdBzn8vOuQCg2WKJMgWjTsLTMRh6KwuqHKvlnUZNfo\n\tJ54YmVHeUC+1bvdhXydeVdKJmPIGV133dZFrezUo=","Message-ID":"<9ad16def-0f58-48b3-935d-8c015c008298@ideasonboard.com>","Date":"Mon, 1 Dec 2025 10:22:48 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] libcamera: controls: Small style fixes","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20251128154832.176864-1-jacopo.mondi@ideasonboard.com>","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Content-Language":"en-US, hu-HU","In-Reply-To":"<20251128154832.176864-1-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]