{"id":25275,"url":"https://patchwork.libcamera.org/api/patches/25275/?format=json","web_url":"https://patchwork.libcamera.org/patch/25275/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251128154832.176864-1-jacopo.mondi@ideasonboard.com>","date":"2025-11-28T15:48:30","name":"libcamera: controls: Small style fixes","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"287c0c9acf5ac500edd179d64b0d158778f2e6ae","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/?format=json","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25275/mbox/","series":[{"id":5620,"url":"https://patchwork.libcamera.org/api/series/5620/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5620","date":"2025-11-28T15:48:30","name":"libcamera: controls: Small style fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/5620/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25275/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25275/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6666EC0F2A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 28 Nov 2025 15:48:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8D58060A85;\n\tFri, 28 Nov 2025 16:48:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 16D856069A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 28 Nov 2025 16:48:39 +0100 (CET)","from ideasonboard.com (net-93-65-100-155.cust.vodafonedsl.it\n\t[93.65.100.155])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CCD76C67;\n\tFri, 28 Nov 2025 16:46:27 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qN/mvy9a\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764344787;\n\tbh=JTG+AvlOQqHg2QZlI/JrXsJBYHNcMsvqtDdZyEcoFic=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=qN/mvy9ao7A4nphpDWovWd7vdPdyv/LCnDbDGo6nhFmRsevv1LvxJHvQBIY3t1B9u\n\thKypgigREDL3os4qlZxFKocfNKsMV0Vo26oSxHdVXC/rnMQ7WC22kCc2igksCW6Y4F\n\tpfEBqtQTOQumoZtRujDoaDKyaUgHAKkA5guOJopc=","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Cc":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Subject":"[PATCH] libcamera: controls: Small style fixes","Date":"Fri, 28 Nov 2025 16:48:30 +0100","Message-ID":"<20251128154832.176864-1-jacopo.mondi@ideasonboard.com>","X-Mailer":"git-send-email 2.51.1","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The Wdr controls have been added without an empty line between them and the\nexisting ones. Also, a line has a space at the end.\n\nFix it.\n\nSigned-off-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\n src/libcamera/control_ids_core.yaml | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)\n\n--\n2.51.1","diff":"diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex 3bcb475fd102..8e99bd84825f 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -677,7 +677,7 @@ controls:\n         stored in conventional reading order in an array of 9 floating point\n         values.\n\n-        ColourCorrectionMatrix can only be applied in a Request when the AWB is\n+        ColourCorrectionMatrix can only be applied in a Request when the AWB is\n         disabled.\n\n         \\sa AwbEnable\n@@ -1283,6 +1283,7 @@ controls:\n         \\sa SensorTimestamp\n\n         The FrameWallClock control can only be returned in metadata.\n+\n   - WdrMode:\n       type: int32_t\n       direction: inout\n@@ -1329,6 +1330,7 @@ controls:\n             This curve preserves most of the information of the image at the\n             expense of a very artificial look. It is therefore best suited for\n             technical analysis.\n+\n   - WdrStrength:\n       type: float\n       direction: in\n@@ -1338,6 +1340,7 @@ controls:\n         global tone mapping is applied. A values of 1 is the default value and\n         the correct value for most scenes. A value above 1 increases the global\n         tone mapping effect and can lead to unrealistic image effects.\n+\n   - WdrMaxBrightPixels:\n       type: float\n       direction: in\n","prefixes":[]}