{"id":25272,"url":"https://patchwork.libcamera.org/api/patches/25272/?format=json","web_url":"https://patchwork.libcamera.org/patch/25272/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251127211932.122463-9-mzamazal@redhat.com>","date":"2025-11-27T21:19:29","name":"[v16,8/9] libcamera: simple: Move colour space logging after adjustment","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"838088491c6dec83a185e251dd7729d307b2dc61","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25272/mbox/","series":[{"id":5619,"url":"https://patchwork.libcamera.org/api/series/5619/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5619","date":"2025-11-27T21:19:21","name":"Enable raw streams with software ISP","version":16,"mbox":"https://patchwork.libcamera.org/series/5619/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25272/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25272/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9C30C3260\n\tfor ;\n\tThu, 27 Nov 2025 21:20:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FC3D60A9E;\n\tThu, 27 Nov 2025 22:20:14 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA0F3609DE\n\tfor ;\n\tThu, 27 Nov 2025 22:20:11 +0100 (CET)","from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-80-l1zWlIGcNaGbUjdHABa4-A-1;\n\tThu, 27 Nov 2025 16:20:09 -0500","from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.12])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 2C3D419560AD; Thu, 27 Nov 2025 21:20:08 +0000 (UTC)","from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.67])\n\tby mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 75A0D19560B0; Thu, 27 Nov 2025 21:20:05 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"ZZFMjDgs\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1764278410;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=tA3FvcMGKlKLFd7ZIG/lffo3qpOGGb9svNtHOKpTi4U=;\n\tb=ZZFMjDgsUbjHV6Qt38N0v3W/xKy2XCzeytf2nEo2n/fapjP9T81dTpHUD5bRmlb5p7YZz0\n\tT7K+msniNJlkkg32YdRCXUtNl8y9AOCtZe3ah1ZB9xecWuEO3ugGts/jgpLaq1kv9u4zau\n\t75LULwFP57m2agxDSkcqhmnDXQQFMKE=","X-MC-Unique":"l1zWlIGcNaGbUjdHABa4-A-1","X-Mimecast-MFC-AGG-ID":"l1zWlIGcNaGbUjdHABa4-A_1764278408","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal , Laurent Pinchart\n\t, Kieran Bingham\n\t, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t, Paul Elder\n\t, Umang Jain ","Subject":"[PATCH v16 8/9] libcamera: simple: Move colour space logging after\n\tadjustment","Date":"Thu, 27 Nov 2025 22:19:29 +0100","Message-ID":"<20251127211932.122463-9-mzamazal@redhat.com>","In-Reply-To":"<20251127211932.122463-1-mzamazal@redhat.com>","References":"<20251127211932.122463-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.0 on 10.30.177.12","X-Mimecast-Spam-Score":"0","X-Mimecast-MFC-PROC-ID":"q9BnkPKqSGtM84-RVEWKGj08infKsHzXdQwz5mQTwzk_1764278408","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","content-type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The log message about adjusting an unspecified colour space should log\nthe value after, not before, the adjustment.\n\nSigned-off-by: Milan Zamazal \n---\n src/libcamera/pipeline/simple/simple.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex cbfc06fb6..2820d1254 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1305,9 +1305,6 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t\t\tdefault:\n \t\t\t\tcfg.colorSpace = ColorSpace::Raw;\n \t\t\t}\n-\t\t\tLOG(SimplePipeline, Debug)\n-\t\t\t\t<< \"Unspecified color space set to \"\n-\t\t\t\t<< cfg.colorSpace.value().toString();\n \t\t\t/*\n \t\t\t * Adjust the assigned color space to make sure everything is OK.\n \t\t\t * Since this is assigning an unspecified color space rather than\n@@ -1315,6 +1312,9 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t\t\t * to Adjusted.\n \t\t\t */\n \t\t\tcfg.colorSpace->adjust(cfg.pixelFormat);\n+\t\t\tLOG(SimplePipeline, Debug)\n+\t\t\t\t<< \"Unspecified color space set to \"\n+\t\t\t\t<< cfg.colorSpace.value().toString();\n \t\t} else {\n \t\t\tif (cfg.colorSpace->adjust(cfg.pixelFormat)) {\n \t\t\t\tLOG(SimplePipeline, Debug)\n","prefixes":["v16","8/9"]}