{"id":25253,"url":"https://patchwork.libcamera.org/api/patches/25253/?format=json","web_url":"https://patchwork.libcamera.org/patch/25253/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251127023739.179652-17-bryan.odonoghue@linaro.org>","date":"2025-11-27T02:37:31","name":"[v5,16/24] libcamera: software_isp: GPU support for unpacked 10/12-bit formats","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"342a5d142ff84081d2ab4fdc62997e8de3158641","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25253/mbox/","series":[{"id":5617,"url":"https://patchwork.libcamera.org/api/series/5617/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5617","date":"2025-11-27T02:37:15","name":"Add GLES 2.0 GPUISP to libcamera","version":5,"mbox":"https://patchwork.libcamera.org/series/5617/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25253/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25253/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6D53BC32E0\n\tfor ;\n\tThu, 27 Nov 2025 02:38:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 94B4F60B2F;\n\tThu, 27 Nov 2025 03:38:22 +0100 (CET)","from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1C6B560A8B\n\tfor ;\n\tThu, 27 Nov 2025 03:38:19 +0100 (CET)","by mail-wm1-x331.google.com with SMTP id\n\t5b1f17b1804b1-477b198f4bcso1723635e9.3\n\tfor ;\n\tWed, 26 Nov 2025 18:38:19 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790552c3c9sm58186345e9.0.2025.11.26.18.38.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:38:16 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Kbvt6NF3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764211098; x=1764815898;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=VHmyzGkOwao2iOVfyxrEPPmvuSeYu4ezxiDGM411cRc=;\n\tb=Kbvt6NF353QnjRwae+oVWjtEfC4z6gUUdYBwmAPXNr5nQdtB3B1PYE1XtKkNQaNgIO\n\tngy4hGcC2bY0cmP2AY1E25EdmTAXcOQjVnFWRMJeTGqCJinh45270uP5Q5gbtXe580MS\n\ticCaiDOqSVwQgl0xJ5FNqLBOB+yRN2ISpNA7xa+HbtRQ2Bv2YRkC2GNSab3OOZbTBnGN\n\tws3kM3Nb7nNlCoHOLkI7MFxmjsCyOQpbkKRnQ3j6fiP+FzjK4DAlCJpUSkxS7kQh8dRU\n\tmR6ZWmZQuR9GISJRDNabKMMjkyEZiUEb01fVv7Kgpk1Q/Xmy/xKW/Pf2BAcsU9fC3BMN\n\tZ1HA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764211098; x=1764815898;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=VHmyzGkOwao2iOVfyxrEPPmvuSeYu4ezxiDGM411cRc=;\n\tb=ecYISd4G4y0XjPvQGppOjo73OsIewoWr6vMrrmLFxFkDhzznli+4+FIMt9Cez49+m9\n\t4iAcwjmU/SNz29ufiTqZMz50TgCO1A1LWga9ggiB9OdAVkWWiM6RugACeRXLVEJ2yAmy\n\tIKbc5vfc50T9q6nRMQ1gbsRfTrdrh31ZectbmgF51DcgGw6CQdyXKQIg6eCBuXxFt4tb\n\t+y2vnWLmh826N1N4cMpqPBQffCgDXkVghm3AX2YC2kdDK+weoHhtWjq2nvoj53tRvXfr\n\t6xs2N2LwCgkah6ksLwBQTcNwPrEqLL5J+IgmPL9p8zei/qUnWyBbsze0+sFdcJaZSr4q\n\tzpBQ==","X-Gm-Message-State":"AOJu0YyzRJ9mWTQ+3K+JHEzWBbuZ5t/ZwUXpxZCPNIDpxpHp1adr3HQk\n\ta/nxsON6JkvdfdncUxWdkzZLCrF79AmwDE/hkKHlarYWvjjo2oyAOze2W+zGGEL7C8Wx4fWtL3r\n\tA+5DULXc=","X-Gm-Gg":"ASbGnctv/3b7P8YLo8ku0VN5qeY+tNVMDeJte7UVEEygqU+PMPETXiP45CE8d8pMRLq\n\t63viep3cBnXiTHZ62lKtv7mg/Tt8hgIulbP4SPoL9Cey9rwJXGtI3g4qqqN9PM4vNhrO8zTSAq+\n\tDxNu55EFLufBnWutTn6YKO5bVvIP7SrsHBoM0i4y9NQnbxj0tdeKyLWAg0taqdn3lF2DuriHs7G\n\t/bGVvPfJtokMoIGxmQI3oeudwNelCPpIgxmnNXlCk6wyC/EBqzpTW5yxXqs4JQe8du4vfMIfib6\n\tGNG+xedWCKjKd2egCWOQ3Ipj37lDXv4GVM3tpFaQAwYzXkqx132xq1AqURSam93A7zTlNbODH/b\n\tRPC0fZeGg00FvoC84emnESj1dS7E/FFYeDKEMqv7XfTXwu55eO1/2lPv7jbw2gcGmDj+ZXBGIEl\n\t6I6Lp0rg2gT7XbGPzLpTQ7K3CFpmt3yWNsnuzChphZ2ehT/bQkiWapBFXHMeSeQLgmHS5938Kgm\n\tq5c4A==","X-Google-Smtp-Source":"AGHT+IEAHTrmNmaP3m3VEtqo79dhNwcGcH7eucevY9b7r/Jawtg1SaqXgXIrUAyd/jj1AKZhz7HNyw==","X-Received":"by 2002:a05:600c:3541:b0:477:9650:3184 with SMTP id\n\t5b1f17b1804b1-477c0165bc3mr213171935e9.2.1764211098387; \n\tWed, 26 Nov 2025 18:38:18 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Milan Zamazal ,\n\tBryan O'Donoghue ","Subject":"[PATCH v5 16/24] libcamera: software_isp: GPU support for unpacked\n\t10/12-bit formats","Date":"Thu, 27 Nov 2025 02:37:31 +0000","Message-ID":"<20251127023739.179652-17-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251127023739.179652-1-bryan.odonoghue@linaro.org>","References":"<20251127023739.179652-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Milan Zamazal \n\nThe GPU processing supports 8-bit sensor formats and 10/12-bit packed\nformats. Support for 10/12-bit unpacked formats is missing, let's add\nit.\n\n10/12-bit unpacked formats use two adjacent bytes to store the value.\nThis means the 8-bit shaders can be used if we can modify them for\nadditional support of 16-bit addressing. This requires the following\nmodifications:\n\n- Using GL_RG (two bytes per pixel) instead of GL_LUMINANCE (one byte\n per pixel) as the texture format for the given input formats.\n\n- Setting the texture width to the number of pixels rather than the\n number of bytes.\n\n- Making the definition of `fetch' macro variable, according to the\n pixel format.\n\n- Using only `fetch' for accessing the texture.\n\nSigned-off-by: Milan Zamazal \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/shaders/bayer_unpacked.frag | 10 +++++++++-\n 1 file changed, 9 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 43ed99e33..7f24fe954 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -47,9 +47,17 @@ float apply_contrast(float normalise, float contrast_in)\n void main(void) {\n vec3 rgb;\n \n+ #if defined(RAW10P)\n+ #define pixel(p) p.r / 4.0 + p.g * 64.0\n+ #define fetch(x, y) pixel(texture2D(tex_y, vec2(x, y)))\n+ #elif defined(RAW12P)\n+ #define pixel(p) p.r / 16.0 + p.g * 16.0\n+ #define fetch(x, y) pixel(texture2D(tex_y, vec2(x, y)))\n+ #else\n #define fetch(x, y) texture2D(tex_y, vec2(x, y)).r\n+ #endif\n \n- float C = texture2D(tex_y, center.xy).r; // ( 0, 0)\n+ float C = fetch(center.x, center.y); // ( 0, 0)\n const vec4 kC = vec4( 4.0, 6.0, 5.0, 5.0) / 8.0;\n \n // Determine which of four types of pixels we are on.\n","prefixes":["v5","16/24"]}