[{"id":3376,"web_url":"https://patchwork.libcamera.org/comment/3376/","msgid":"<20200108001605.GV533370@oden.dyn.berto.se>","date":"2020-01-08T00:16:05","subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Include ","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2020-01-08 00:30:40 +0200, Laurent Pinchart wrote:\n> Commit 29c5508075c1 (\"v4l2: camera_proxy: Create format info array\")\n> introduced usage of the std::array template class, but didn't include\n> the corresponding header. This may cause a compilation breakage in the\n> future if the indirect include of disappears due to unrelated\n> changes. Fix it.\n> \n> Fixed: 29c5508075c1 (\"v4l2: camera_proxy: Create format info array\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index bdd4a6c3475d..8d1b40da7367 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -8,6 +8,7 @@\n> #include \"v4l2_camera_proxy.h\"\n> \n> #include \n> +#include \n> #include \n> #include \n> #include \n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x143.google.com (mail-lf1-x143.google.com\n\t[IPv6:2a00:1450:4864:20::143])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CB55860612\n\tfor ;\n\tWed, 8 Jan 2020 01:16:08 +0100 (CET)","by mail-lf1-x143.google.com with SMTP id m30so1062820lfp.8\n\tfor ;\n\tTue, 07 Jan 2020 16:16:08 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\ts18sm506801ljj.36.2020.01.07.16.16.06\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Jan 2020 16:16:06 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=acjCUTCtcYr433RrYL0GZvGhahyHIIFR6gsZItLy29k=;\n\tb=ALLMLSMStKTBVgRVJ41++f6SIZIH93ud44kXFA44DtHC2k2pbc1p6JSMmDX3D0940/\n\tn0cIFS/2B9dQNyhJ1rR5eN8CxPnzA3DV4u9jVheg9uu2hOT2XcbmMmm02t88LzPcJl1t\n\tzA+FQMylHsTxeBqSXpRJuDF/YSqh33x5rZEvM0kDn6B3AYdF2Z/FstPfIaCz0f2md/aN\n\tWGQI5eyn/pV7zCSsVY9iNc3ZFffpY4T2x7yZ/0+Snzo+KeYB4K8wcq2A5CUos1dn5ny2\n\t452m6dKifaq/+CC51XsBBGA810rMCVUL/iM4tM/Kx10ij2mc1kTDpNr9qHqh4uD+pGXm\n\tSMQQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=acjCUTCtcYr433RrYL0GZvGhahyHIIFR6gsZItLy29k=;\n\tb=GCgpNjPkp+J/bEtb9LuLsy4vcsugLQUjjMC6Zxb4YdkrsgYd/9NlqHwnxvKsGHrf/u\n\tL07NrMQhbWhCQ1u/IRWW77wIs+u+DtaA6yr/B6ugNgMGRcXX5NNnk7GeTk7kpgEdKrla\n\t2Hg8t0LgSQLKSJR0qhdjUGpE+XBZ6+EryYiR2g3kpZwy3IhFiZtGzG/ShCQfqrJwrMi0\n\t9C5OFMCbRRcwiZsVuwOFZM1zUbyAmFDh6MNSCgi+8Q9uBbj0zPPU8dTnguB02I+3EC7z\n\tGnP+6VG3+n1luCG2EPlfGgyh8K9fC8XHtm9u1c/qsxcNgZbI/52ojgrHp19qZ6oejXgs\n\tFuDQ==","X-Gm-Message-State":"APjAAAW0Bsb6Qfgdt51x3GpOnMY4x4dxPcOUtt4sivM1norC+OdksFLS\n\tGMcGZ4dOZ6J0fv/TcC3v+gfPyY5PVDVE+g==","X-Google-Smtp-Source":"APXvYqyp8Vv+Qj9aMGs3ks5DAVN1tV9n9Qr3S9VgV96pzWUVUxwf4sOQZa1wbksRONw5hp0+CiZJEw==","X-Received":"by 2002:ac2:531b:: with SMTP id c27mr1140112lfh.91.1578442568048;\n\tTue, 07 Jan 2020 16:16:08 -0800 (PST)","Date":"Wed, 8 Jan 2020 01:16:05 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200108001605.GV533370@oden.dyn.berto.se>","References":"<20200107223040.12294-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200107223040.12294-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Include ","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 08 Jan 2020 00:16:09 -0000"}},{"id":3390,"web_url":"https://patchwork.libcamera.org/comment/3390/","msgid":"<20200108083342.d7s5zwcnkfza7zv4@uno.localdomain>","date":"2020-01-08T08:33:42","subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Include ","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Wed, Jan 08, 2020 at 12:30:40AM +0200, Laurent Pinchart wrote:\n> Commit 29c5508075c1 (\"v4l2: camera_proxy: Create format info array\")\n> introduced usage of the std::array template class, but didn't include\n> the corresponding header. This may cause a compilation breakage in the\n> future if the indirect include of disappears due to unrelated\n> changes. Fix it.\n>\n> Fixed: 29c5508075c1 (\"v4l2: camera_proxy: Create format info array\")\n> Signed-off-by: Laurent Pinchart \n\nSorry, missed it during review\n\nReviewed-by: Jacopo Mondi \nThanks\n j\n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index bdd4a6c3475d..8d1b40da7367 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -8,6 +8,7 @@\n> #include \"v4l2_camera_proxy.h\"\n>\n> #include \n> +#include \n> #include \n> #include \n> #include \n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 274296045F\n\tfor ;\n\tWed, 8 Jan 2020 09:31:16 +0100 (CET)","from uno.localdomain (93-34-114-233.ip49.fastwebnet.it\n\t[93.34.114.233]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id B82EE1C0008;\n\tWed, 8 Jan 2020 08:31:15 +0000 (UTC)"],"X-Originating-IP":"93.34.114.233","Date":"Wed, 8 Jan 2020 09:33:42 +0100","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200108083342.d7s5zwcnkfza7zv4@uno.localdomain>","References":"<20200107223040.12294-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"t7rehew5vmuc6knm\"","Content-Disposition":"inline","In-Reply-To":"<20200107223040.12294-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH] v4l2: camera_proxy: Include ","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Wed, 08 Jan 2020 08:31:16 -0000"}}]