{"id":25242,"url":"https://patchwork.libcamera.org/api/patches/25242/?format=json","web_url":"https://patchwork.libcamera.org/patch/25242/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251127023739.179652-6-bryan.odonoghue@linaro.org>","date":"2025-11-27T02:37:20","name":"[v5,05/24] libcamera: shaders: Use highp not mediump for float precision","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6c6d01298168b7fdda1e1bf9b659e20aec8e0b4b","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25242/mbox/","series":[{"id":5617,"url":"https://patchwork.libcamera.org/api/series/5617/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5617","date":"2025-11-27T02:37:15","name":"Add GLES 2.0 GPUISP to libcamera","version":5,"mbox":"https://patchwork.libcamera.org/series/5617/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25242/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25242/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 107D8C32DE\n\tfor ;\n\tThu, 27 Nov 2025 02:37:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A94C560AA3;\n\tThu, 27 Nov 2025 03:37:58 +0100 (CET)","from mail-wm1-x331.google.com (mail-wm1-x331.google.com\n\t[IPv6:2a00:1450:4864:20::331])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A66460AB3\n\tfor ;\n\tThu, 27 Nov 2025 03:37:57 +0100 (CET)","by mail-wm1-x331.google.com with SMTP id\n\t5b1f17b1804b1-4779adb38d3so1789925e9.2\n\tfor ;\n\tWed, 26 Nov 2025 18:37:57 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790552c3c9sm58186345e9.0.2025.11.26.18.37.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:37:56 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"B8dlZb+v\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764211076; x=1764815876;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=mt8VuycA4JtISYG1OMwP/mShybOjaHrIEZw7TC7UHZg=;\n\tb=B8dlZb+vi/Ay031On+rNdj2DvCD2bItylXo0jzsudJjv8/OOHF6bUN7Y3FCzbXpDvg\n\tViYDiwB3ZKmWUEdJYJAKxrgLtJdVbqXl2prgTuMAwgTDuWdCZl2yC0SErPw8Df3cyBCl\n\tSgGtTI+8MnWcOaF3oPCdYYDnZ6qQF1nHPETpxp02XB/uXCWqtj0/WOKRhXxVaI1qKP1h\n\t7HjSGrOQq/VnvP5MFi3AcdZrYMdKJKJZjhxPwPXbtpHwW8OoRI7WTnKE4hG9hOOmLicN\n\tPQD/2sswinHyHO4pxdIL/VHo5KaRo58y56Gc/m1Xe95OPnxBta5Emc0e0jZYyIOdJOZL\n\tmVjw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764211076; x=1764815876;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=mt8VuycA4JtISYG1OMwP/mShybOjaHrIEZw7TC7UHZg=;\n\tb=xUXtBk3pded9qS7fk0XZyAMSf4VOxkMyPHbBBTHypJmfNqnB/VMkk7HayDYbyLtplT\n\tW42uOdjZoLM7ILxke9VfBDjrEpDh5k3vp5zlXjsjeIMXYgbK7SKeEILFaww+paOBmFkC\n\txHz8Vtafuh3KsX/hziMSRAIgrVwjs4oqepqwQLL9jlzA1iA7pH/McQm/U/+ujkRE+A5y\n\t4LilcXRY1TknYBUIAnkV3Av7sCyhRJZl+M4/DiD/xYndD9yinqM4J9zbHN9jmdNNUk9U\n\tk1ab4dO5v5GQgpMK0KNydtik65YYA3gh6VJgqyphey5Z8rFCSfPepK0OgGhXD/E5nI4h\n\tkaEw==","X-Gm-Message-State":"AOJu0Ywxh9WL04QT1jR3RymkqAEFA4OyfXzWECQ3juZ/Uz2JveuQTpYJ\n\tr+PDiJJnlsFz6J2j/VOArLvKhfG/OIYz1isIQ/fR7USKEErX7B8clQ1jkkm6M+BYg5pRJZCK2Fp\n\tlfhsb8f4=","X-Gm-Gg":"ASbGncvU5bRgbE/65FZQIgTUXdMgvuOumxFKZbUr2w31jAphypEqm/BWd9cb/vs88TQ\n\tBuJR64cLL+z/BkrXUFkPD/6BI57RX3ohKEG5o2QrETtiauBKp0tnrLyPuo6mFjEwoIGqkPwHXSe\n\tUt5cNG0SsJ4Gr99qzfoYEc+TlWN2WCokLlIDeKr3X6ITDIrXUjEvxPwuPCuRhw9g6/fwoNFY1vO\n\tmpMP4klii2V8sUA4SQ11VvjaCx00C8wwZ7kLtMCf6vvJQD2xRyLvDjFbmsjoL68m7Uq6aoVMqmL\n\tOwQr9d7fV2Zo3rc+CM4SOl0+0RKQnm+8YCKzj3PO5gz6wNkSelFshzPvGAKlIFyTVUCFj6+i3Ke\n\tpwL3aW91kdYm+aYPNX7b09M3iD1VQM0e30B1Y/eGXyWYaV995pGgIzxhv54zf6KdlLUNKY6BO3G\n\tNTXrBpt6Glgy8hlXKrt/ctBIGdAS/4mTG/rTlcIx9KCHFleJVpRhxYAGojKCjlUDd6oNA=","X-Google-Smtp-Source":"AGHT+IGq2QWxaAkfBfeUaCBFNkzwKce5lSkNq+FVdton/7mygJouvmW/lA/LWh+KA6euzoZJLwsxbQ==","X-Received":"by 2002:a05:600c:1c0d:b0:477:9a28:b0a4 with SMTP id\n\t5b1f17b1804b1-47904a6867fmr102638375e9.0.1764211076603; \n\tWed, 26 Nov 2025 18:37:56 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tKieran Bingham ","Subject":"[PATCH v5 05/24] libcamera: shaders: Use highp not mediump for float\n\tprecision","Date":"Thu, 27 Nov 2025 02:37:20 +0000","Message-ID":"<20251127023739.179652-6-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251127023739.179652-1-bryan.odonoghue@linaro.org>","References":"<20251127023739.179652-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"mediump gives 10 bits of mantissa as the resolution. At higher resolutions\n10 bits of accuracy is insufficient - for example at a width of 1928 bytes\nwe need log2(1928) = ~11 bit resolution.\n\nSwitching to highp gives us 23 bits of mantissa giving a sample width\nprecision of about 2^23 ~ 8,388,608.\n\nAcked-by: Kieran Bingham \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/shaders/RGB.frag | 2 +-\n src/libcamera/shaders/YUV_2_planes.frag | 2 +-\n src/libcamera/shaders/YUV_3_planes.frag | 2 +-\n src/libcamera/shaders/YUV_packed.frag | 2 +-\n src/libcamera/shaders/bayer_1x_packed.frag | 2 +-\n src/libcamera/shaders/bayer_unpacked.frag | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/shaders/RGB.frag b/src/libcamera/shaders/RGB.frag\nindex 4c374ac98..724395894 100644\n--- a/src/libcamera/shaders/RGB.frag\n+++ b/src/libcamera/shaders/RGB.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_2_planes.frag b/src/libcamera/shaders/YUV_2_planes.frag\nindex 1d5d12062..d286f1179 100644\n--- a/src/libcamera/shaders/YUV_2_planes.frag\n+++ b/src/libcamera/shaders/YUV_2_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_3_planes.frag b/src/libcamera/shaders/YUV_3_planes.frag\nindex 8f788e90a..8e3e0b4a5 100644\n--- a/src/libcamera/shaders/YUV_3_planes.frag\n+++ b/src/libcamera/shaders/YUV_3_planes.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/YUV_packed.frag b/src/libcamera/shaders/YUV_packed.frag\nindex b9ef9d41b..3c9e3e397 100644\n--- a/src/libcamera/shaders/YUV_packed.frag\n+++ b/src/libcamera/shaders/YUV_packed.frag\n@@ -6,7 +6,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/src/libcamera/shaders/bayer_1x_packed.frag b/src/libcamera/shaders/bayer_1x_packed.frag\nindex f53f55758..19b13ad08 100644\n--- a/src/libcamera/shaders/bayer_1x_packed.frag\n+++ b/src/libcamera/shaders/bayer_1x_packed.frag\n@@ -20,7 +20,7 @@\n */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /*\ndiff --git a/src/libcamera/shaders/bayer_unpacked.frag b/src/libcamera/shaders/bayer_unpacked.frag\nindex 7e35ca88e..aa7a1b004 100644\n--- a/src/libcamera/shaders/bayer_unpacked.frag\n+++ b/src/libcamera/shaders/bayer_unpacked.frag\n@@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro\n \n //Pixel Shader\n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n","prefixes":["v5","05/24"]}