[{"id":37094,"web_url":"https://patchwork.libcamera.org/comment/37094/","msgid":"<176423739293.567526.13706897267519609886@ping.linuxembedded.co.uk>","date":"2025-11-27T09:56:32","subject":"Re: [PATCH v2 22/22] libcamera: software_isp: lut: Make contrast\n\tavailable in debayer params","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Bryan O'Donoghue (2025-11-27 02:22:54)\n> Provide the contrast used in IPA to Bayer parameters. Similar to the\n> calculated Gamma value we will pass this value into the debayer fragment\n> shader for further consumption.\n> \n> Reviewed-by: Milan Zamazal \n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Bryan O'Donoghue \n> ---\n> include/libcamera/internal/software_isp/debayer_params.h | 1 +\n> src/ipa/simple/algorithms/lut.cpp | 1 +\n> src/libcamera/software_isp/debayer.cpp | 5 +++++\n> 3 files changed, 7 insertions(+)\n> \n> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n> index d5dad1a98..8033f7d5b 100644\n> --- a/include/libcamera/internal/software_isp/debayer_params.h\n> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n> @@ -59,6 +59,7 @@ struct DebayerParams {\n> Matrix ccm;\n> RGB blackLevel;\n> float gamma;\n> + float contrast;\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\n> index ea5a86b20..9aaab54f1 100644\n> --- a/src/ipa/simple/algorithms/lut.cpp\n> +++ b/src/ipa/simple/algorithms/lut.cpp\n> @@ -149,6 +149,7 @@ void Lut::prepare(IPAContext &context,\n> }\n> \n> params->gamma = context.configuration.gamma;\n> + params->contrast = context.activeState.gamma.contrast;\n> }\n> \n> void Lut::process([[maybe_unused]] IPAContext &context,\n> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\n> index 8bcbd5dde..f0307549b 100644\n> --- a/src/libcamera/software_isp/debayer.cpp\n> +++ b/src/libcamera/software_isp/debayer.cpp\n> @@ -115,6 +115,11 @@ namespace libcamera {\n> * \\brief Gamma value for the GPUISP\n> */\n> \n> +/**\n> + * \\var DebayerParams::contrast\n> + * \\brief Contrast value for GPUISP\n> + */\n> +\n> /**\n> * \\class Debayer\n> * \\brief Base debayering class\n> -- \n> 2.51.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7A2D3C3260\n\tfor ;\n\tThu, 27 Nov 2025 09:56:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A8A060AA1;\n\tThu, 27 Nov 2025 10:56:37 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 848B7609DE\n\tfor ;\n\tThu, 27 Nov 2025 10:56:35 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 569496AC;\n\tThu, 27 Nov 2025 10:54:25 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"qGcuNnX/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764237265;\n\tbh=F8cHIHacARk0h8LOW6LlPzbBaw09/jbCUFfp1vrWdBs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=qGcuNnX/lUNPusnAik0HqIvis3R+h04B4zwXZoL/xf4kaBVWcAxW1ukpZP5LEnSn+\n\tjyg6XEg0KhDnJpfEsF/kPPsqsItsRjA25pIMP7Q2bqB92g2QgbrdBSsaSHek06/5N2\n\tHRekPMxQnXV2MDxgOmJ8uGdsHOl9JH+mYPNElwKA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251127022256.178929-23-bryan.odonoghue@linaro.org>","References":"<20251127022256.178929-1-bryan.odonoghue@linaro.org>\n\t<20251127022256.178929-23-bryan.odonoghue@linaro.org>","Subject":"Re: [PATCH v2 22/22] libcamera: software_isp: lut: Make contrast\n\tavailable in debayer params","From":"Kieran Bingham ","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tMilan Zamazal ","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 27 Nov 2025 09:56:32 +0000","Message-ID":"<176423739293.567526.13706897267519609886@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]