[{"id":37092,"web_url":"https://patchwork.libcamera.org/comment/37092/","msgid":"<176423734915.567526.7647610475006194833@ping.linuxembedded.co.uk>","date":"2025-11-27T09:55:49","subject":"Re: [PATCH v2 20/22] libcamera: software_isp: blacklevel: Make black\n\tlevel available in debayer params","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Bryan O'Donoghue (2025-11-27 02:22:52)\n> Populate black level gain in blacklevel::prepare(). A copy is made of the gain\n> value in the DebayerParams structure.\n> \n> Signed-off-by: Bryan O'Donoghue \n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/software_isp/debayer_params.h | 2 ++\n> src/ipa/simple/algorithms/blc.cpp | 9 +++++++++\n> src/ipa/simple/algorithms/blc.h | 4 ++++\n> src/libcamera/software_isp/debayer.cpp | 5 +++++\n> 4 files changed, 20 insertions(+)\n> \n> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n> index 4b203e211..5a0d9438f 100644\n> --- a/include/libcamera/internal/software_isp/debayer_params.h\n> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n> @@ -14,6 +14,7 @@\n> #include \n> \n> #include \"libcamera/internal/matrix.h\"\n> +#include \"libcamera/internal/vector.h\"\n> \n> namespace libcamera {\n> \n> @@ -56,6 +57,7 @@ struct DebayerParams {\n> * Per frame corrections as calculated by the IPA\n> */\n> Matrix ccm;\n> + RGB blackLevel;\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/ipa/simple/algorithms/blc.cpp b/src/ipa/simple/algorithms/blc.cpp\n> index 370385afc..464e43c27 100644\n> --- a/src/ipa/simple/algorithms/blc.cpp\n> +++ b/src/ipa/simple/algorithms/blc.cpp\n> @@ -47,6 +47,15 @@ int BlackLevel::configure(IPAContext &context,\n> return 0;\n> }\n> \n> +void BlackLevel::prepare(IPAContext &context,\n> + [[maybe_unused]] const uint32_t frame,\n> + [[maybe_unused]] IPAFrameContext &frameContext,\n> + DebayerParams *params)\n> +{\n> + /* Latch the blacklevel gain so GPUISP can apply. */\n> + params->blackLevel = RGB(context.activeState.blc.level / 255.0f);\n> +}\n> +\n> void BlackLevel::process(IPAContext &context,\n> [[maybe_unused]] const uint32_t frame,\n> IPAFrameContext &frameContext,\n> diff --git a/src/ipa/simple/algorithms/blc.h b/src/ipa/simple/algorithms/blc.h\n> index db9e6d639..a5592d087 100644\n> --- a/src/ipa/simple/algorithms/blc.h\n> +++ b/src/ipa/simple/algorithms/blc.h\n> @@ -24,6 +24,10 @@ public:\n> \n> int init(IPAContext &context, const YamlObject &tuningData) override;\n> int configure(IPAContext &context, const IPAConfigInfo &configInfo) override;\n> + void prepare(IPAContext &context,\n> + const uint32_t frame,\n> + IPAFrameContext &frameContext,\n> + DebayerParams *params) override;\n> void process(IPAContext &context, const uint32_t frame,\n> IPAFrameContext &frameContext,\n> const SwIspStats *stats,\n> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\n> index 4ec76dce6..1034912e7 100644\n> --- a/src/libcamera/software_isp/debayer.cpp\n> +++ b/src/libcamera/software_isp/debayer.cpp\n> @@ -105,6 +105,11 @@ namespace libcamera {\n> * \\brief Per frame colour correction matrix for GPUISP\n> */\n> \n> +/**\n> + * \\var DebayerParams::blackLevel\n> + * \\brief Blacklevel gains for the GPUISP\n> + */\n> +\n> /**\n> * \\class Debayer\n> * \\brief Base debayering class\n> -- \n> 2.51.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A607C3260\n\tfor ;\n\tThu, 27 Nov 2025 09:55:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA9B060A86;\n\tThu, 27 Nov 2025 10:55:52 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF634609DE\n\tfor ;\n\tThu, 27 Nov 2025 10:55:51 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 845E86AC;\n\tThu, 27 Nov 2025 10:53:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"AAYfdFdd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764237221;\n\tbh=TjdsxjQ8oSG9fYA3sLEbUFtPBV7O+inYkG9/7qrv0Yo=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=AAYfdFddwwuZFqqp8QhwJomf/TA5H0bwPIYCrlhd92HPaAaL1b/kGh5mN4v63gS1t\n\taBI6AQsAOiHJDO5BKA07UI2tqiNi9J1ONESg6dGjM4/qA0ynlhONCuvXow6LcEpYwb\n\tk6GTUos3g7YBeyqsPm5OIykR7vGaJhBy5dXns/xU=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251127022256.178929-21-bryan.odonoghue@linaro.org>","References":"<20251127022256.178929-1-bryan.odonoghue@linaro.org>\n\t<20251127022256.178929-21-bryan.odonoghue@linaro.org>","Subject":"Re: [PATCH v2 20/22] libcamera: software_isp: blacklevel: Make black\n\tlevel available in debayer params","From":"Kieran Bingham ","Cc":"pavel@ucw.cz, Bryan O'Donoghue ","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 27 Nov 2025 09:55:49 +0000","Message-ID":"<176423734915.567526.7647610475006194833@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]