[{"id":37091,"web_url":"https://patchwork.libcamera.org/comment/37091/","msgid":"<176423730548.567526.12129014326221865593@ping.linuxembedded.co.uk>","date":"2025-11-27T09:55:05","subject":"Re: [PATCH v2 19/22] libcamera: software_isp: lut: Make CCM\n\tavailable in debayer params","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Bryan O'Donoghue (2025-11-27 02:22:51)\n> Provide the CCM calculated in LUT to the debayer params structure for\n> consumption in the debayer shaders.\n> \n> Signed-off-by: Bryan O'Donoghue \n> ---\n> include/libcamera/internal/software_isp/debayer_params.h | 7 +++++++\n> src/ipa/simple/algorithms/lut.cpp | 1 +\n> src/libcamera/software_isp/debayer.cpp | 5 +++++\n> 3 files changed, 13 insertions(+)\n> \n> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n> index 217cd5d92..4b203e211 100644\n> --- a/include/libcamera/internal/software_isp/debayer_params.h\n> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n> @@ -13,6 +13,8 @@\n> #include \n> #include \n> \n> +#include \"libcamera/internal/matrix.h\"\n> +\n> namespace libcamera {\n> \n> struct DebayerParams {\n> @@ -49,6 +51,11 @@ struct DebayerParams {\n> CcmLookupTable greenCcm;\n> CcmLookupTable blueCcm;\n> LookupTable gammaLut;\n> +\n> + /*\n> + * Per frame corrections as calculated by the IPA\n> + */\n> + Matrix ccm;\n> };\n> \n> } /* namespace libcamera */\n> diff --git a/src/ipa/simple/algorithms/lut.cpp b/src/ipa/simple/algorithms/lut.cpp\n> index d4a79e101..49482d711 100644\n> --- a/src/ipa/simple/algorithms/lut.cpp\n> +++ b/src/ipa/simple/algorithms/lut.cpp\n> @@ -133,6 +133,7 @@ void Lut::prepare(IPAContext &context,\n> auto &red = params->redCcm;\n> auto &green = params->greenCcm;\n> auto &blue = params->blueCcm;\n> + params->ccm = ccm;\n> for (unsigned int i = 0; i < DebayerParams::kRGBLookupSize; i++) {\n> red[i].r = ccmValue(i, ccm[0][0]);\n> red[i].g = ccmValue(i, ccm[1][0]);\n> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\n> index 1d135b278..4ec76dce6 100644\n> --- a/src/libcamera/software_isp/debayer.cpp\n> +++ b/src/libcamera/software_isp/debayer.cpp\n> @@ -100,6 +100,11 @@ namespace libcamera {\n> * \\brief Gamma lookup table used with color correction matrix\n> */\n> \n> + /**\n> + * \\var DebayerParams::ccm\n> + * \\brief Per frame colour correction matrix for GPUISP\n> + */\n> +\n\nlint: This is incorrectly indented, but easily fixed:\n\nReviewed-by: Kieran Bingham \n\n> /**\n> * \\class Debayer\n> * \\brief Base debayering class\n> -- \n> 2.51.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64EDCC3257\n\tfor ;\n\tThu, 27 Nov 2025 09:55:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4535860A85;\n\tThu, 27 Nov 2025 10:55:09 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C695660805\n\tfor ;\n\tThu, 27 Nov 2025 10:55:07 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4A8B3593;\n\tThu, 27 Nov 2025 10:52:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"V+EtlVNg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764237177;\n\tbh=IATXjd9Lx+//rxW3q5tO/6LESPJa33Etm0WLLkMGDt4=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=V+EtlVNg21vO4Ru1UTSM6wHD3FOcRorsM9H0UbL93A0fuErHLI9hgTWMijTpeaP6T\n\t7vrkXlr3SRdU1WGftovFAha4WVu3hbOKgTbEjMLhAA6NWjyJd36o1udHgdvv2EiS/E\n\tbkroIA0vhMhiA2T6m5yLL/wnKndaPnnWxO/CJpTA=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251127022256.178929-20-bryan.odonoghue@linaro.org>","References":"<20251127022256.178929-1-bryan.odonoghue@linaro.org>\n\t<20251127022256.178929-20-bryan.odonoghue@linaro.org>","Subject":"Re: [PATCH v2 19/22] libcamera: software_isp: lut: Make CCM\n\tavailable in debayer params","From":"Kieran Bingham ","Cc":"pavel@ucw.cz, Bryan O'Donoghue ","To":"Bryan O'Donoghue ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 27 Nov 2025 09:55:05 +0000","Message-ID":"<176423730548.567526.12129014326221865593@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]