{"id":25229,"url":"https://patchwork.libcamera.org/api/patches/25229/?format=json","web_url":"https://patchwork.libcamera.org/patch/25229/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251127022256.178929-16-bryan.odonoghue@linaro.org>","date":"2025-11-27T02:22:47","name":"[v2,15/22] libcamera: software_isp: Start the ISP thread in configure","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f15eebb7c60746935ec55f953c786798ff77e881","submitter":{"id":175,"url":"https://patchwork.libcamera.org/api/people/175/?format=json","name":"Bryan O'Donoghue","email":"bryan.odonoghue@linaro.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25229/mbox/","series":[{"id":5616,"url":"https://patchwork.libcamera.org/api/series/5616/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5616","date":"2025-11-27T02:22:32","name":"GPUISP precursor series","version":2,"mbox":"https://patchwork.libcamera.org/series/5616/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25229/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25229/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 32A38C3260\n\tfor ;\n\tThu, 27 Nov 2025 02:23:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D656460AD2;\n\tThu, 27 Nov 2025 03:23:39 +0100 (CET)","from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8ECED60AA3\n\tfor ;\n\tThu, 27 Nov 2025 03:23:37 +0100 (CET)","by mail-wm1-x334.google.com with SMTP id\n\t5b1f17b1804b1-477a2ab455fso2941725e9.3\n\tfor ;\n\tWed, 26 Nov 2025 18:23:37 -0800 (PST)","from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4790b0e21e8sm71549495e9.15.2025.11.26.18.23.35\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 26 Nov 2025 18:23:35 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"A9xC+dQo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1764210217; x=1764815017;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=0FUA8kH36pvKSfSDc4qeO8M3Vhl+74knCB5rIoM7BX0=;\n\tb=A9xC+dQozvbrpzXsyAcNh/gUWCffMhaHJlaoMsaXU5KZLa9eQqbe06PrDNoNz4zLTK\n\tVpL4m/OZXyAERMtJmDVAuDbGf5LlSfrRYhpQ3T8VJYrleIC1QeYlaGASc4hN7DAbsUvc\n\tRiH/7RxnMHJB1WfOI+fycmXFqH+0P0emLkva0E1tkR145MCMJnNQa1iKViaUjD9pXNsz\n\t5iscxetofMpxADHxQyxAfR8qhCgOzsn46Dr3MCX+Xy474eSsadPeUniOUkQIF0aXH5nO\n\trY3QSbeuQqKkvcBdKIG1gYWGiodPuOyTuAkc89b8xW9Md0nHB5KOqDC3z9yDNBUej9U5\n\tRa+A==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1764210217; x=1764815017;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from\n\t:to:cc:subject:date:message-id:reply-to;\n\tbh=0FUA8kH36pvKSfSDc4qeO8M3Vhl+74knCB5rIoM7BX0=;\n\tb=pYHHE9zfip/yaD0dC3tuJNbBccrAv1inXNyyJPeDX3JU4z1pzAMDC0wDd46FQfFVwF\n\t6/aaeaEKBuo70sqh0LRt/P5ouPMVmLJXxB/HF8j2lcYnsFfh7EhGBzOgeSiy94b2z2FA\n\t20LU03mcL7J+QjGp59s6WzDvCa9Rh5c8MC6d7SW3QkpTmyxzh25szPrMj6j6mzK4Jiux\n\tL2Iqe3/B1j/mnpZltpuiTlmaYVsk1oSqpXzhvxVVTbNVOPLnxxNYx8JU/CpJiN/FblXh\n\t+P1oB+Fsv0rlRRmoDnaFTcvxI4vdHDtHbBs0LTUo0xrHt/66lKpNtrmyNnh2zuZURDKb\n\tzKFQ==","X-Gm-Message-State":"AOJu0Yz26NTMtL7CSmkCgoSPb6ZmQ40aeyY/Yp68wQOvqvPoj5VKG3h4\n\tlPpBaWERrMosBqWZv3rcWRy8g/+iXADZrj1lTmHhw18mtg3G25p/8StLGnV1epj75+SQ480TzXc\n\tvGo/xj+4=","X-Gm-Gg":"ASbGncsTPoSa1gbaoL+Hsr9IuJUjW7kjdaMeagrrcJAwWo0gPfHmuTY8OWMcJQ8AEy2\n\t3KDPfdnH9+Ybzda7YaoKI0NxxQeucAuNCGtkMXoI33l2tBTCxGSbC+8LTo7G35Qv20GHrrEX2Fj\n\toj8z3E6lMp/xH/1bebsWa2jpU5MDJOVIlXf7D5KUyHFOGh2Gnw4e+/Kb9X/TsU7nwupICuYSsfo\n\tgS+nb+UFXQ8yoqIhghnoj1UHvunuIrkRF9eD4ttp8r8xxr7ZGt0MFs+H5XDXn8xk4KBDL1ZWieq\n\tgwHafud3OoR53aHPzSkVzfowCd6Ps6dHCXUSyn/uzMgwYlmXDr13L2NDdDj66nCNQ63JdCta2/k\n\tDMwxTQcq/Y+0DYdlPPwTkKodXIef434W5izcWuLeIXSHdClwGf0g+1xCujNXQP8XGKavLgxSbQJ\n\t9BRWy5P3VxsIB0AIo76Xaij4Fp9+IcvgPdi/6Abeo8uPkw03n6D1GlS301+nCbLFJ6hvU=","X-Google-Smtp-Source":"AGHT+IHbonNS6BrdZt7W27wiLka/XPeOw0PAfe9byA2FgpSbXzuJVW1AdGr6rL9zLJ2sRGT9kCEWVA==","X-Received":"by 2002:a05:600c:4591:b0:477:b642:9dbf with SMTP id\n\t5b1f17b1804b1-477c1132adbmr212090575e9.32.1764210216983; \n\tWed, 26 Nov 2025 18:23:36 -0800 (PST)","From":"Bryan O'Donoghue ","To":"libcamera-devel@lists.libcamera.org","Cc":"pavel@ucw.cz, Bryan O'Donoghue ,\n\tRobert Mader ","Subject":"[PATCH v2 15/22] libcamera: software_isp: Start the ISP thread in\n\tconfigure","Date":"Thu, 27 Nov 2025 02:22:47 +0000","Message-ID":"<20251127022256.178929-16-bryan.odonoghue@linaro.org>","X-Mailer":"git-send-email 2.51.2","In-Reply-To":"<20251127022256.178929-1-bryan.odonoghue@linaro.org>","References":"<20251127022256.178929-1-bryan.odonoghue@linaro.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"EGL is not thread-safe and in fact associates invisible handles with the\nthreadid of the calling context.\n\nAs a result we need to make Deabyer::configure() and Debayer::process() in SoftISP execute on\nthe same thread.\n\nWhen we call Debayer::configure() in the egl class this will setup and egl context\nfor us which is associated with the calling thread context. Hence when\nDebayer::process(); runs it must run in the same thread as\nDebayer::configure() or the hidden Gegl context handles will not point\nto the same place.\n\nMove start thread into configure() as a first step towards this.\n\nCo-developed-by: Robert Mader \nSigned-off-by: Robert Mader \nSigned-off-by: Bryan O'Donoghue \n---\n src/libcamera/software_isp/software_isp.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 928a2520c..afa4eb7a8 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -265,6 +265,8 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tif (ret < 0)\n \t\treturn ret;\n \n+\tispWorkerThread_.start();\n+\n \treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n }\n \n@@ -346,7 +348,6 @@ int SoftwareIsp::start()\n \tif (ret)\n \t\treturn ret;\n \n-\tispWorkerThread_.start();\n \treturn 0;\n }\n \n","prefixes":["v2","15/22"]}