[{"id":37064,"web_url":"https://patchwork.libcamera.org/comment/37064/","msgid":"<176409314397.567526.1200467947924624660@ping.linuxembedded.co.uk>","date":"2025-11-25T17:52:23","subject":"Re: [PATCH v3 26/29] libcamera: Add and implement LensDewarpEnable\n\tcontrol","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-11-25 16:28:38)\n> Add a LensDewarpEnable control to enable or disable lens dewarping if it\n> is configured. Implement it inside the dw100 converter module.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Paul Elder \n> \n\nAll self contained in the module that handles it. Just what I like :-)\n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> \n> Changes in v3:\n> - Moved control handling into converter module\n> - Moved yaml handling into converter module\n> - Collected tag\n> \n> Changes in v2:\n> - Merged control definition and usage into one patch\n> - Improved control description\n> - Fixed actual handling of LensDewarpEnable control that got lost in a\n> previous rebase\n> ---\n> src/libcamera/control_ids_core.yaml | 7 +++++++\n> src/libcamera/converter/converter_dw100.cpp | 12 ++++++++++++\n> 2 files changed, 19 insertions(+)\n> \n> diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\n> index f781865859ac..3bcb475fd102 100644\n> --- a/src/libcamera/control_ids_core.yaml\n> +++ b/src/libcamera/control_ids_core.yaml\n> @@ -1346,4 +1346,11 @@ controls:\n> reduces the WdrExposureValue until the amount of pixels that are close\n> to saturation is lower than this value.\n> \n> + - LensDewarpEnable:\n> + type: bool\n> + direction: inout\n> + description: |\n> + Enable or disable lens dewarping. This control is only available if lens\n> + dewarp parameters are configured in the tuning file.\n> +\n> ...\n> diff --git a/src/libcamera/converter/converter_dw100.cpp b/src/libcamera/converter/converter_dw100.cpp\n> index 03ffd939dc63..7adad1b502f0 100644\n> --- a/src/libcamera/converter/converter_dw100.cpp\n> +++ b/src/libcamera/converter/converter_dw100.cpp\n> @@ -343,6 +343,9 @@ void ConverterDW100Module::updateControlInfos(const Stream *stream, ControlInfoM\n> controls[&controls::ScalerCrop] = ControlInfo(Rectangle(sensorCrop_.x, sensorCrop_.y, 1, 1),\n> sensorCrop_, sensorCrop_);\n> \n> + if (dewarpParams_.has_value())\n> + controls[&controls::LensDewarpEnable] = ControlInfo(false, true, true);\n> +\n> if (!converter_.supportsRequests())\n> LOG(Converter, Warning)\n> << \"dw100 kernel driver has no requests support.\"\n> @@ -366,6 +369,12 @@ void ConverterDW100Module::setControls(const Stream *stream, const ControlList &\n> auto &info = vertexMaps_[stream];\n> auto &vertexMap = info.map;\n> \n> + const auto &lensDewarpEnable = controls.get(controls::LensDewarpEnable);\n> + if (lensDewarpEnable) {\n> + vertexMap.setLensDewarpEnable(*lensDewarpEnable);\n> + info.update = true;\n> + }\n> +\n> const auto &crop = controls.get(controls::ScalerCrop);\n> if (crop) {\n> vertexMap.setScalerCrop(*crop);\n> @@ -394,6 +403,9 @@ void ConverterDW100Module::populateMetadata(const Stream *stream, ControlList &m\n> auto &vertexMap = vertexMaps_[stream].map;\n> \n> meta.set(controls::ScalerCrop, vertexMap.effectiveScalerCrop());\n> +\n> + if (dewarpParams_.has_value())\n> + meta.set(controls::LensDewarpEnable, vertexMap.lensDewarpEnable());\n> }\n> \n> /**\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE7ADC32F1\n\tfor ;\n\tTue, 25 Nov 2025 17:52:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6FB9A609E0;\n\tTue, 25 Nov 2025 18:52:29 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B4B0609D8\n\tfor ;\n\tTue, 25 Nov 2025 18:52:27 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 512F4236;\n\tTue, 25 Nov 2025 18:50:18 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"B/Zno40H\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764093018;\n\tbh=Lyzq44+ThzgS9Dflkmf1ZM14Uen5z2WadsVLUrDw6eg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=B/Zno40HKrjf6mAya/nzHJNoWRNsqv9N5OrLzjh/Nm5kA/xtmbXpf0l1lTNU6otgf\n\tb0zmqppDqwwEfByK9pUpoAk+4EigqtU3cWs2Ar0yVHwti4HZUARoG+6zYw48rQNeGY\n\tgDvBbwbohxi71xan6Iejkjs0/0UIgrhlojTQYMXI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251125162851.2301793-27-stefan.klug@ideasonboard.com>","References":"<20251125162851.2301793-1-stefan.klug@ideasonboard.com>\n\t<20251125162851.2301793-27-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v3 26/29] libcamera: Add and implement LensDewarpEnable\n\tcontrol","From":"Kieran Bingham ","Cc":"Stefan Klug ,\n\tPaul Elder ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 25 Nov 2025 17:52:23 +0000","Message-ID":"<176409314397.567526.1200467947924624660@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]