[{"id":37055,"web_url":"https://patchwork.libcamera.org/comment/37055/","msgid":"<176409059543.567526.4759632851462093923@ping.linuxembedded.co.uk>","date":"2025-11-25T17:09:55","subject":"Re: [PATCH v3 14/29] pipeline: rkisp1: Fix number of buffers\n\timported into the dewarper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-11-25 16:28:26)\n> When the dewarper is used, an addition buffer loop with\n> kRkISP1MinBufferCount buffers is created between ISP and dewarper. When\n> the dewarper is configured, it stores the bufferCount value of the\n> requested stream configurations. This number of buffers is then imported\n> when the dewarper is started.\n> \n> On the input stream of the dewarper the bufferCount is currently left\n> unchanged, meaning it carries the bufferCount as supplied by the user\n> instead of the bufferCount of the additional loop. Fix that by setting\n> the bufferCount to kRkISP1MinBufferCount.\n> \n> Signed-off-by: Stefan Klug \n> \n\nReviewed-by: Kieran Bingham \n\n> ---\n> \n> Changes in v3:\n> - Added this patch\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 79c8717c839a..138e1d5bf06b 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -954,6 +954,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)\n> if (data->usesDewarper_) {\n> outputCfgs.push_back(const_cast(cfg));\n> \n> + ispCfg.bufferCount = kRkISP1MinBufferCount;\n> ispCfg.size = format.size;\n> ispCfg.stride =\n> PixelFormatInfo::info(ispCfg.pixelFormat)\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C75A6C3257\n\tfor ;\n\tTue, 25 Nov 2025 17:09:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8046D60A85;\n\tTue, 25 Nov 2025 18:09:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 860E3609D8\n\tfor ;\n\tTue, 25 Nov 2025 18:09:58 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 94A1F6AF;\n\tTue, 25 Nov 2025 18:07:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cls9kx12\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764090469;\n\tbh=K1h0gruMGGKw4tiO8qVyhnh7JE9Y/0K2XynSf/X1iSM=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Cls9kx12OPnl2bHsOkIOWnHsjCX/vSbpk42us3++nBTwHHSwSmK7Ep87Q6ROtYDjB\n\tm4pWf/7QPgIrOUwDYsmhZuVa+V2bE7+1r1WBcq4pizgLm/K+bHxsbHCanuVBTIedBk\n\thPAGdJFxktqZij2aXamO7b06fwmV0CQDoN1r7PkE=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251125162851.2301793-15-stefan.klug@ideasonboard.com>","References":"<20251125162851.2301793-1-stefan.klug@ideasonboard.com>\n\t<20251125162851.2301793-15-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v3 14/29] pipeline: rkisp1: Fix number of buffers\n\timported into the dewarper","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 25 Nov 2025 17:09:55 +0000","Message-ID":"<176409059543.567526.4759632851462093923@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]