[{"id":37054,"web_url":"https://patchwork.libcamera.org/comment/37054/","msgid":"<176409053614.567526.7865436696975082079@ping.linuxembedded.co.uk>","date":"2025-11-25T17:08:56","subject":"Re: [PATCH v3 13/29] libcamera: rkisp1: Allow upscaling when the\n\tdewarper is present","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-11-25 16:28:25)\n> When the dewarper is present, there is no need to forbid upscaling of\n> the image data.\n> \n> Signed-off-by: Stefan Klug \n> Reviewed-by: Paul Elder \n> \nReviewed-by: Kieran Bingham \n> ---\n> \n> Changes in v3:\n> - Collected tag\n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> index 2d89b0b41958..79c8717c839a 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n> @@ -609,6 +609,11 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n> return false;\n> \n> if (useDewarper) {\n> + /*\n> + * The dewarper output is independent of the ISP path.\n> + * Reset to the originally requested size.\n> + */\n> + tryCfg.size = cfg.size;\n> bool adjusted;\n> \n> pipe->dewarper_->validateOutput(&tryCfg, &adjusted,\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD1F8C32DE\n\tfor ;\n\tTue, 25 Nov 2025 17:08:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 54C4360A85;\n\tTue, 25 Nov 2025 18:08:59 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4C97A609D8\n\tfor ;\n\tTue, 25 Nov 2025 18:08:58 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 599246AF;\n\tTue, 25 Nov 2025 18:06:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"af1qSPg9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764090409;\n\tbh=J2TbWmEY8A02Xfe3tmKpb7EU3AF7a7hnQpmbNWxopRg=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=af1qSPg9evCgR0t9h/i1X79zE2G9//mjdlZvw/Sdn1W83UvQq2DBx6ep7pgtjKG72\n\tOXPdAfDaHV9jSf5GfMN5DrOeewHH4j0Og0OWz4qLUS5yBQXAD+Wb/sK+ytPE8GdVtl\n\tmsty811BwnbvROnlJllacaqwYbFBn5QkizAf3XVc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251125162851.2301793-14-stefan.klug@ideasonboard.com>","References":"<20251125162851.2301793-1-stefan.klug@ideasonboard.com>\n\t<20251125162851.2301793-14-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH v3 13/29] libcamera: rkisp1: Allow upscaling when the\n\tdewarper is present","From":"Kieran Bingham ","Cc":"Stefan Klug ,\n\tPaul Elder ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 25 Nov 2025 17:08:56 +0000","Message-ID":"<176409053614.567526.7865436696975082079@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]