{"id":25185,"url":"https://patchwork.libcamera.org/api/patches/25185/?format=json","web_url":"https://patchwork.libcamera.org/patch/25185/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251125162851.2301793-7-stefan.klug@ideasonboard.com>","date":"2025-11-25T16:28:18","name":"[v3,06/29] libcamera: converter_v4l2_m2m: Always set stride","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f0014f8d7346ea54f7efcda1559b79970c59798f","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25185/mbox/","series":[{"id":5613,"url":"https://patchwork.libcamera.org/api/series/5613/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5613","date":"2025-11-25T16:28:12","name":"Full dewarper support on imx8mp","version":3,"mbox":"https://patchwork.libcamera.org/series/5613/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25185/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25185/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3AB20C333C\n\tfor ;\n\tTue, 25 Nov 2025 16:29:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CE64560AAC;\n\tTue, 25 Nov 2025 17:29:14 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8DC87609E0\n\tfor ;\n\tTue, 25 Nov 2025 17:29:13 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:bae1:340c:573c:570b])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id B36D41E4D; \n\tTue, 25 Nov 2025 17:27:03 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Y1MwhneN\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764088023;\n\tbh=KvkXT6rO8BXj40x8YoebfMZJGCSM/KBAKph2QcZzUz4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Y1MwhneNpXwf6owTwzPMGFTXHFYjeBuPlurxGzLnI/YONBVtrg46N54AFLf9VDmsi\n\tbCL75o+cbkNlqeVlSrvimGOO5GK8/dqYNxGOWq4IfzYvlikrQvI3NGa2SfGlS1HI2i\n\te8wjklcNYAMM+ZM6UaXKtRHfNzAzG6W7sSTQPCB8=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tKieran Bingham ,\n\tIsaac Scott ,\n\tUmang Jain , Paul Elder ","Subject":"[PATCH v3 06/29] libcamera: converter_v4l2_m2m: Always set stride","Date":"Tue, 25 Nov 2025 17:28:18 +0100","Message-ID":"<20251125162851.2301793-7-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.51.0","In-Reply-To":"<20251125162851.2301793-1-stefan.klug@ideasonboard.com>","References":"<20251125162851.2301793-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Ensure the stride is properly set after a call to validateOutput().\n\nSigned-off-by: Stefan Klug \nReviewed-by: Kieran Bingham \nReviewed-by: Isaac Scott \nReviewed-by: Umang Jain \nReviewed-by: Paul Elder \n\n---\n\nChanges in v3:\n- Collected tags\n\nChanges in v2:\n- Collected tag\n---\n src/libcamera/converter/converter_v4l2_m2m.cpp | 1 +\n 1 file changed, 1 insertion(+)","diff":"diff --git a/src/libcamera/converter/converter_v4l2_m2m.cpp b/src/libcamera/converter/converter_v4l2_m2m.cpp\nindex c6153d728c9a..e57db8a438ab 100644\n--- a/src/libcamera/converter/converter_v4l2_m2m.cpp\n+++ b/src/libcamera/converter/converter_v4l2_m2m.cpp\n@@ -680,6 +680,7 @@ int V4L2M2MConverter::validateOutput(StreamConfiguration *cfg, bool *adjusted,\n \n \tconst Size cfgSize = cfg->size;\n \tcfg->size = adjustSizes(cfgSize, it->second, align);\n+\tcfg->stride = PixelFormatInfo::info(cfg->pixelFormat).stride(cfg->size.width, 0);\n \n \tif (cfg->size.isNull())\n \t\treturn -EINVAL;\n","prefixes":["v3","06/29"]}