[{"id":3357,"web_url":"https://patchwork.libcamera.org/comment/3357/","msgid":"<20200107172429.GB533370@oden.dyn.berto.se>","date":"2020-01-07T17:24:29","subject":"Re: [libcamera-devel] [PATCH 3/4] v4l2: camera_proxy: Rationalize\n\targuments to format helpers","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your patch.\n\nOn 2020-01-06 18:14:16 +0200, Laurent Pinchart wrote:\n> To clarify code, adopt the following rules for format helpers:\n> \n> - All variables representing V4L2 pixel formats shall use uint32_t\n> - All variables representing DRM pixel formats shall use PixelFormat\n> - Functions returning positive values only shall not have a signed\n> return type\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> src/v4l2/v4l2_camera_proxy.cpp | 18 +++++++++---------\n> src/v4l2/v4l2_camera_proxy.h | 10 +++++-----\n> 2 files changed, 14 insertions(+), 14 deletions(-)\n> \n> diff --git a/src/v4l2/v4l2_camera_proxy.cpp b/src/v4l2/v4l2_camera_proxy.cpp\n> index dd3ee3e6c6ff..6a222d702e13 100644\n> --- a/src/v4l2/v4l2_camera_proxy.cpp\n> +++ b/src/v4l2/v4l2_camera_proxy.cpp\n> @@ -510,7 +510,7 @@ int V4L2CameraProxy::ioctl(unsigned long request, void *arg)\n> }\n> \n> /* \\todo make libcamera export these */\n> -int V4L2CameraProxy::bplMultiplier(unsigned int format)\n> +unsigned int V4L2CameraProxy::bplMultiplier(uint32_t format)\n> {\n> \tswitch (format) {\n> \tcase V4L2_PIX_FMT_NV12:\n> @@ -535,8 +535,8 @@ int V4L2CameraProxy::bplMultiplier(unsigned int format)\n> \t};\n> }\n> \n> -int V4L2CameraProxy::imageSize(unsigned int format,\n> -\t\t\t unsigned int width, unsigned int height)\n> +unsigned int V4L2CameraProxy::imageSize(uint32_t format, unsigned int width,\n> +\t\t\t\t\tunsigned int height)\n> {\n> \tswitch (format) {\n> \tcase V4L2_PIX_FMT_NV12:\n> @@ -563,9 +563,9 @@ int V4L2CameraProxy::imageSize(unsigned int format,\n> \t};\n> }\n> \n> -unsigned int V4L2CameraProxy::v4l2ToDrm(unsigned int pixelformat)\n> +PixelFormat V4L2CameraProxy::v4l2ToDrm(uint32_t format)\n> {\n> -\tswitch (pixelformat) {\n> +\tswitch (format) {\n> \t/* RGB formats. */\n> \tcase V4L2_PIX_FMT_RGB24:\n> \t\treturn DRM_FORMAT_BGR888;\n> @@ -598,13 +598,13 @@ unsigned int V4L2CameraProxy::v4l2ToDrm(unsigned int pixelformat)\n> \tcase V4L2_PIX_FMT_NV42:\n> \t\treturn DRM_FORMAT_NV42;\n> \tdefault:\n> -\t\treturn pixelformat;\n> +\t\treturn format;\n> \t};\n> }\n> \n> -unsigned int V4L2CameraProxy::drmToV4L2(unsigned int pixelformat)\n> +uint32_t V4L2CameraProxy::drmToV4L2(PixelFormat format)\n> {\n> -\tswitch (pixelformat) {\n> +\tswitch (format) {\n> \t/* RGB formats. */\n> \tcase DRM_FORMAT_BGR888:\n> \t\treturn V4L2_PIX_FMT_RGB24;\n> @@ -637,6 +637,6 @@ unsigned int V4L2CameraProxy::drmToV4L2(unsigned int pixelformat)\n> \tcase DRM_FORMAT_NV42:\n> \t\treturn V4L2_PIX_FMT_NV42;\n> \tdefault:\n> -\t\treturn pixelformat;\n> +\t\treturn format;\n> \t}\n> }\n> diff --git a/src/v4l2/v4l2_camera_proxy.h b/src/v4l2/v4l2_camera_proxy.h\n> index bef0f0afab3b..3d702084f8ff 100644\n> --- a/src/v4l2/v4l2_camera_proxy.h\n> +++ b/src/v4l2/v4l2_camera_proxy.h\n> @@ -54,12 +54,12 @@ private:\n> \tint vidioc_streamon(int *arg);\n> \tint vidioc_streamoff(int *arg);\n> \n> -\tstatic int bplMultiplier(unsigned int format);\n> -\tstatic int imageSize(unsigned int format, unsigned int width,\n> -\t\t\t unsigned int height);\n> +\tstatic unsigned int bplMultiplier(uint32_t format);\n> +\tstatic unsigned int imageSize(uint32_t format, unsigned int width,\n> +\t\t\t\t unsigned int height);\n> \n> -\tstatic unsigned int v4l2ToDrm(unsigned int pixelformat);\n> -\tstatic unsigned int drmToV4L2(unsigned int pixelformat);\n> +\tstatic PixelFormat v4l2ToDrm(uint32_t format);\n> +\tstatic uint32_t drmToV4L2(PixelFormat format);\n> \n> \tunsigned int refcount_;\n> \tunsigned int index_;\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lj1-x242.google.com (mail-lj1-x242.google.com\n\t[IPv6:2a00:1450:4864:20::242])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D0F16063B\n\tfor ;\n\tTue, 7 Jan 2020 18:24:31 +0100 (CET)","by mail-lj1-x242.google.com with SMTP id m26so341188ljc.13\n\tfor ;\n\tTue, 07 Jan 2020 09:24:31 -0800 (PST)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\ta9sm161239lfk.23.2020.01.07.09.24.29\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 07 Jan 2020 09:24:29 -0800 (PST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to;\n\tbh=4N5ZLGAqErIKheQ+Snxu3y1AFSWdOBFLyqZAzIgT/68=;\n\tb=CTXiGy1PpyKE4l5xFTbuShacuiKQeJxxGrWoKETtugw61vRphdc87s6zAno8quAPvd\n\tYj0o61zYsSNQ3aA6WB4a/MTgOzBKpzciOdQTpGFNL6+YpKF4FRJgg8soQn2i+0OiMgpY\n\tTWmJvXfqaOfEvxCHEkxO6zT2IMNXtvpTv+jIKlrpzv+xrni5H3L5wuQB+sH1aH5JMai9\n\tZwOzmYl8EmvgxTrSlEZ7Br9HU7tWgmPOw3rRn6v+llcITjtwTZBpUw9f6u0AJeMQFCzG\n\tu6/bxUbRBROCDO1xjzErFgw+VvJ+LNbSSvx2RKBxO/xUK6ef5C9ub0cgdfvJigZutvWJ\n\tJ6+Q==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to;\n\tbh=4N5ZLGAqErIKheQ+Snxu3y1AFSWdOBFLyqZAzIgT/68=;\n\tb=L7ud3HAVQxB3+Ll9jkVBrDAZt1HhMDLhcNnPRDXt6YSTB5ksBD6iOIYhyzK/bl2YGy\n\tvqI2altFYI5V5FqW9v0BXqwIiMNla+XZ42qj9LZRY2HD5hFQsyZgrxy00valPAJLySW4\n\tCrujBpq0jHv7/JB60QhCAWTOqQ7Ux76SUdvNfvpAlUGaBMSsJrxB3r8VKjAIZU4QTfvo\n\t7h31lt+zr3G0qrNwoJQq6Bn32fhglUlrf31/52if5oxEsjFEO52QeWKPqBdkMEEWOqr3\n\tWkX3Ftb+Rlmg+0QGK/TN1ZylZWnvuaKhXpCLoScDhe3HuW5aEQKJ6OIg+8VhA5uTzZJW\n\tu98g==","X-Gm-Message-State":"APjAAAUo1Uri33GIu3glFdjJ3gI59iWD7y7/77MDRwQmS9XC006n0doh\n\tXP+YfErLGVZT7nuMx2QgCcwp4B1eF5h7AA==","X-Google-Smtp-Source":"APXvYqwXaRwr5t3zlRPYBRhfHlth+fDKNYcJI4Vi30krNWtTwDEdPh9WNRT4soensH+JbdNLBERIGw==","X-Received":"by 2002:a2e:9883:: with SMTP id b3mr351813ljj.80.1578417870394; \n\tTue, 07 Jan 2020 09:24:30 -0800 (PST)","Date":"Tue, 7 Jan 2020 18:24:29 +0100","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20200107172429.GB533370@oden.dyn.berto.se>","References":"<20200106161417.19150-1-laurent.pinchart@ideasonboard.com>\n\t<20200106161417.19150-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20200106161417.19150-4-laurent.pinchart@ideasonboard.com>","Subject":"Re: [libcamera-devel] [PATCH 3/4] v4l2: camera_proxy: Rationalize\n\targuments to format helpers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 07 Jan 2020 17:24:31 -0000"}}]