{"id":25168,"url":"https://patchwork.libcamera.org/api/patches/25168/?format=json","web_url":"https://patchwork.libcamera.org/patch/25168/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20251125000848.4103786-2-rui.wang@ideasonboard.com>","date":"2025-11-25T00:08:38","name":"[v1,01/11] ipa: rkisp1: algorithms: Add exposure index computation helpers","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"62a4fedf07ed6d9a9cd74d73f74a8b923237a4db","submitter":{"id":241,"url":"https://patchwork.libcamera.org/api/people/241/?format=json","name":"Rui Wang","email":"rui.wang@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/25168/mbox/","series":[{"id":5612,"url":"https://patchwork.libcamera.org/api/series/5612/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=5612","date":"2025-11-25T00:08:37","name":"ipa: rkisp1: DPF refactor and tuning improvements","version":1,"mbox":"https://patchwork.libcamera.org/series/5612/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/25168/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/25168/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1AC4BC3257\n\tfor ;\n\tTue, 25 Nov 2025 00:09:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 95C2060A8A;\n\tTue, 25 Nov 2025 01:09:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0FCA4608CF\n\tfor ;\n\tTue, 25 Nov 2025 01:09:01 +0100 (CET)","from rui-Precision-7560.local (unknown\n\t[IPv6:2607:fea8:935b:7220:cb34:a7b8:53d:5466])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 068FAC75;\n\tTue, 25 Nov 2025 01:06:51 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ekordYg9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764029212;\n\tbh=c9z/FY4uG8M2ilmBF1G6vgwpSHEjI/ddJW8v9kh5h70=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ekordYg9aV6bWrcVLgxrrDWpz0yBF3AUScMXBKa4sTO+rRucl6SLxYvE7U72VvBdQ\n\tYnguZVHlsMf0HhjaTjdcCXiVRnboDkQHwWGFTLPbjGZrpizRCma57WVN83rXeE+78Q\n\tHe2pQIiS5o5lsy/S1CvV6nNZAMsVy9HVW/IHFU6U=","From":"Rui Wang ","To":"libcamera-devel@lists.libcamera.org","Cc":"Rui Wang ","Subject":"[PATCH v1 01/11] ipa: rkisp1: algorithms: Add exposure index\n\tcomputation helpers","Date":"Mon, 24 Nov 2025 19:08:38 -0500","Message-ID":"<20251125000848.4103786-2-rui.wang@ideasonboard.com>","X-Mailer":"git-send-email 2.43.0","In-Reply-To":"<20251125000848.4103786-1-rui.wang@ideasonboard.com>","References":"<20251125000848.4103786-1-rui.wang@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Introduce computeExposureIndex() to derive an exposure index value from\nthe AGC gain (approximately exposureIndex = gain * 100), and\nselectExposureIndexBand() to search through a container of exposure index\nlevels and select the appropriate tuning band for the current exposure\nindex.\n\nThese helpers provide reusable functionality for exposure-index-banded\ntuning in denoising algorithms, enabling more precise algorithm\nconfiguration based on lighting conditions.\n\nSigned-off-by: Rui Wang \n---\n src/ipa/rkisp1/algorithms/denoise.h | 55 +++++++++++++++++++++++++++++\n 1 file changed, 55 insertions(+)\n create mode 100644 src/ipa/rkisp1/algorithms/denoise.h","diff":"diff --git a/src/ipa/rkisp1/algorithms/denoise.h b/src/ipa/rkisp1/algorithms/denoise.h\nnew file mode 100644\nindex 00000000..8907dc4e\n--- /dev/null\n+++ b/src/ipa/rkisp1/algorithms/denoise.h\n@@ -0,0 +1,55 @@\n+/* SPDX-License-Identifier: LGPL-2.1-or-later */\n+/*\n+ * Copyright (C) 2025, Ideas On Board\n+ *\n+ * RkISP1 Denoising Algorithms Base Class\n+ */\n+\n+#pragma once\n+\n+#include \"../ipa_context.h\"\n+\n+#include \"algorithm.h\"\n+\n+namespace libcamera {\n+\n+namespace ipa::rkisp1::algorithms {\n+\n+class DenoiseBaseAlgorithm : public ipa::rkisp1::Algorithm\n+{\n+protected:\n+\tDenoiseBaseAlgorithm() = default;\n+\t~DenoiseBaseAlgorithm() = default;\n+\n+\tvirtual uint32_t computeExposureIndex(const IPAContext &context,\n+\t\t\t\t\t const IPAFrameContext &frameContext) const;\n+\ttemplate\n+\tuint32_t selectExposureIndexBand(unsigned exposureIndex,\n+\t\t\t\t\t const LevelContainer &levels) const;\n+};\n+\n+inline unsigned DenoiseBaseAlgorithm::computeExposureIndex(const IPAContext &context,\n+\t\t\t\t\t\t\t const IPAFrameContext &frameContext) const\n+{\n+\tdouble ag = frameContext.agc.gain ? frameContext.agc.gain\n+\t\t\t\t\t : context.activeState.agc.automatic.gain;\n+\treturn static_cast(ag * 100.0 + 0.5);\n+}\n+\n+template\n+uint32_t DenoiseBaseAlgorithm::selectExposureIndexBand(unsigned exposureIndex,\n+\t\t\t\t\t\t const LevelContainer &levels) const\n+{\n+\tif (levels.empty())\n+\t\treturn -1;\n+\tuint32_t idx = 0;\n+\twhile (idx < static_cast(levels.size()) && exposureIndex > levels[idx].maxExposureIndex)\n+\t\t++idx;\n+\tif (idx >= static_cast(levels.size()))\n+\t\tidx = static_cast(levels.size()) - 1;\n+\treturn idx;\n+}\n+\n+} /* namespace ipa::rkisp1::algorithms */\n+\n+} /* namespace libcamera */\n","prefixes":["v1","01/11"]}