[{"id":37038,"web_url":"https://patchwork.libcamera.org/comment/37038/","msgid":"<176402697984.3929989.8427889724591308457@ping.linuxembedded.co.uk>","date":"2025-11-24T23:29:39","subject":"Re: [PATCH] libipa: exposure_mode_helper: Set quantizationGain in\n\tabsence of a sensor helper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Stefan Klug (2025-11-24 19:52:41)\n\n> In commit f077c58e087e (\"libipa: exposure_mode_helper: Take\n> exposure/gain quantization into account\") calculation of the\n> quantization gain was added to ExposureModeHelper::clampGain(). This\n> works as expected when a sensor helper is configured but the gain is not\n> reset to 1.0 in case the sensor helper is not configured. This leads to\n> incorrect gain calculations in ExposureModeHelper::splitExposure() as\n> that expects the quantization gain to be valid in any case. Fix that by\n> setting the quantization gain to 1.0 in case no sensor helper is\n> configured.\n> \n> Fixes: f077c58e087e (\"libipa: exposure_mode_helper: Take exposure/gain quantization into account\")\n> Closes: https://gitlab.freedesktop.org/camera/libcamera/-/issues/292\n> Signed-off-by: Stefan Klug \n> ---\n> src/ipa/libipa/exposure_mode_helper.cpp | 10 +++++++---\n> 1 file changed, 7 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp\n> index 29e316d9d091..01c5cba8e22c 100644\n> --- a/src/ipa/libipa/exposure_mode_helper.cpp\n> +++ b/src/ipa/libipa/exposure_mode_helper.cpp\n> @@ -144,9 +144,13 @@ utils::Duration ExposureModeHelper::clampExposureTime(utils::Duration exposureTi\n> double ExposureModeHelper::clampGain(double gain, double *quantizationGain) const\n> {\n> double clamped = std::clamp(gain, minGain_, maxGain_);\n> - if (!sensorHelper_)\n> - return clamped;\n> - return sensorHelper_->quantizeGain(clamped, quantizationGain);\n> + if (sensorHelper_)\n> + return sensorHelper_->quantizeGain(clamped, quantizationGain);\n> +\n> + if (quantizationGain)\n> + *quantizationGain = 1.0;\n\nLooks good to me.\n\nReviewed-by: Kieran Bingham \n\n> +\n> + return clamped;\n> }\n> \n> /**\n> -- \n> 2.51.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06247C3260\n\tfor ;\n\tMon, 24 Nov 2025 23:29:46 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0539460A8B;\n\tTue, 25 Nov 2025 00:29:45 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 75CD1608CF\n\tfor ;\n\tTue, 25 Nov 2025 00:29:43 +0100 (CET)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B5EB10C4;\n\tTue, 25 Nov 2025 00:27:34 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m3OMYk1v\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764026854;\n\tbh=jGC8YkKAY2wJAslVcZSlhCOBS9PKpSyQjnI3DT4ZzLI=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=m3OMYk1vFfCH6+MdP+2LzWmwtOGmK6xL27LrGA7lyYB1zRxZ98vFi+7euH1iailMn\n\tjM6TZ63CIio61OzGl4AcpSQ4bFbyquSs5yJ51Dei3fkUD5QKTpTyNlGCC1fCL5yBuc\n\tDGR7vr8c0pakluG0u1meUUGh5yyArKm/D8YXumjo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20251124195254.1567409-1-stefan.klug@ideasonboard.com>","References":"<20251124195254.1567409-1-stefan.klug@ideasonboard.com>","Subject":"Re: [PATCH] libipa: exposure_mode_helper: Set quantizationGain in\n\tabsence of a sensor helper","From":"Kieran Bingham ","Cc":"Stefan Klug ","To":"Stefan Klug ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 24 Nov 2025 23:29:39 +0000","Message-ID":"<176402697984.3929989.8427889724591308457@ping.linuxembedded.co.uk>","User-Agent":"alot/0.9.1","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":37044,"web_url":"https://patchwork.libcamera.org/comment/37044/","msgid":"","date":"2025-11-25T08:31:20","subject":"Re: [PATCH] libipa: exposure_mode_helper: Set quantizationGain in\n\tabsence of a sensor helper","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Stefan\n\nOn Mon, Nov 24, 2025 at 11:29:39PM +0000, Kieran Bingham wrote:\n> Quoting Stefan Klug (2025-11-24 19:52:41)\n>\n> > In commit f077c58e087e (\"libipa: exposure_mode_helper: Take\n> > exposure/gain quantization into account\") calculation of the\n> > quantization gain was added to ExposureModeHelper::clampGain(). This\n> > works as expected when a sensor helper is configured but the gain is not\n> > reset to 1.0 in case the sensor helper is not configured. This leads to\n> > incorrect gain calculations in ExposureModeHelper::splitExposure() as\n> > that expects the quantization gain to be valid in any case. Fix that by\n> > setting the quantization gain to 1.0 in case no sensor helper is\n> > configured.\n> >\n> > Fixes: f077c58e087e (\"libipa: exposure_mode_helper: Take exposure/gain quantization into account\")\n> > Closes: https://gitlab.freedesktop.org/camera/libcamera/-/issues/292\n> > Signed-off-by: Stefan Klug \n> > ---\n> > src/ipa/libipa/exposure_mode_helper.cpp | 10 +++++++---\n> > 1 file changed, 7 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/ipa/libipa/exposure_mode_helper.cpp b/src/ipa/libipa/exposure_mode_helper.cpp\n> > index 29e316d9d091..01c5cba8e22c 100644\n> > --- a/src/ipa/libipa/exposure_mode_helper.cpp\n> > +++ b/src/ipa/libipa/exposure_mode_helper.cpp\n> > @@ -144,9 +144,13 @@ utils::Duration ExposureModeHelper::clampExposureTime(utils::Duration exposureTi\n> > double ExposureModeHelper::clampGain(double gain, double *quantizationGain) const\n> > {\n> > double clamped = std::clamp(gain, minGain_, maxGain_);\n> > - if (!sensorHelper_)\n> > - return clamped;\n> > - return sensorHelper_->quantizeGain(clamped, quantizationGain);\n> > + if (sensorHelper_)\n> > + return sensorHelper_->quantizeGain(clamped, quantizationGain);\n> > +\n> > + if (quantizationGain)\n> > + *quantizationGain = 1.0;\n>\n> Looks good to me.\n\nI think we should make sensorHelper_ mandatory.\n\nI can do this on top, as I need it anyway for the exposure series I\nhave in review and we should push for all IPAs that use libipa to be\nin par.\n\n>\n> Reviewed-by: Kieran Bingham \n\nBut this fixes a bug for me already on Mali, so please push it in the\nmeantime.\n\nReviewed-by: Jacopo Mondi \nTested-by: Jacopo Mondi \n\nThanks\n j\n\n>\n> > +\n> > + return clamped;\n> > }\n> >\n> > /**\n> > --\n> > 2.51.0\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6E9E8C326B\n\tfor ;\n\tTue, 25 Nov 2025 08:31:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97C1760A80;\n\tTue, 25 Nov 2025 09:31:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 82181606A0\n\tfor ;\n\tTue, 25 Nov 2025 09:31:24 +0100 (CET)","from ideasonboard.com (mob-5-90-51-179.net.vodafone.it\n\t[5.90.51.179])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 518A5C75;\n\tTue, 25 Nov 2025 09:29:15 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mFMeGcMD\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1764059355;\n\tbh=//ekP9Pp8MPIRfYwRRP92wTRujOUuo81r/dQGrS/H+A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mFMeGcMDnYpJvi9qhOglNfvujx8WWmR3Sh2T670R66Su5GWxPGescwLOvmzFh0k0/\n\tMaDDraJZ8Pgu+YBTuqr6pRb7eJc4qaV6IbrRrufSaB2/IHxyK19wUWG5bw3l+aufJz\n\tJLzzcMRxOXP1uaVuXVOjF0vMvuWAZ7oo1ZZ3+D/g=","Date":"Tue, 25 Nov 2025 09:31:20 +0100","From":"Jacopo Mondi ","To":"Kieran Bingham ","Cc":"Stefan Klug , \n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libipa: exposure_mode_helper: Set quantizationGain in\n\tabsence of a sensor helper","Message-ID":"","References":"<20251124195254.1567409-1-stefan.klug@ideasonboard.com>\n\t<176402697984.3929989.8427889724591308457@ping.linuxembedded.co.uk>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<176402697984.3929989.8427889724591308457@ping.linuxembedded.co.uk>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]